diff mbox series

[06/13] fstests: clean up open-coded golden output

Message ID 162317279504.653489.6631181052382825481.stgit@locust (mailing list archive)
State Superseded, archived
Headers show
Series fstests: move test group lists into test files | expand

Commit Message

Darrick J. Wong June 8, 2021, 5:19 p.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

Fix the handful of tests that open-coded 'QA output created by XXX'.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/btrfs/006.out   |    2 +-
 tests/btrfs/012.out   |    2 +-
 tests/generic/184.out |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Chandan Babu R June 10, 2021, 8:57 a.m. UTC | #1 
On 08 Jun 2021 at 22:49, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Fix the handful of tests that open-coded 'QA output created by XXX'.
>

Grep shows that the files modified by this patch are the only ones having open
coded header in a *.out file. Hence,

Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>

> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>  tests/btrfs/006.out   |    2 +-
>  tests/btrfs/012.out   |    2 +-
>  tests/generic/184.out |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
>
> diff --git a/tests/btrfs/006.out b/tests/btrfs/006.out
> index a9769721..b7f29f96 100644
> --- a/tests/btrfs/006.out
> +++ b/tests/btrfs/006.out
> @@ -1,4 +1,4 @@
> -== QA output created by 006
> +QA output created by 006
>  == Set filesystem label to TestLabel.006
>  == Get filesystem label
>  TestLabel.006
> diff --git a/tests/btrfs/012.out b/tests/btrfs/012.out
> index 2a41e7e4..7aa5ae94 100644
> --- a/tests/btrfs/012.out
> +++ b/tests/btrfs/012.out
> @@ -1 +1 @@
> -== QA output created by 012
> +QA output created by 012
> diff --git a/tests/generic/184.out b/tests/generic/184.out
> index 2d19691d..4c300543 100644
> --- a/tests/generic/184.out
> +++ b/tests/generic/184.out
> @@ -1 +1 @@
> -QA output created by 184 - silence is golden
> +QA output created by 184


--
chandan
Allison Henderson June 11, 2021, 9:55 p.m. UTC | #2 
On 6/8/21 10:19 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Fix the handful of tests that open-coded 'QA output created by XXX'.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Looks fine
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
>   tests/btrfs/006.out   |    2 +-
>   tests/btrfs/012.out   |    2 +-
>   tests/generic/184.out |    2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> 
> diff --git a/tests/btrfs/006.out b/tests/btrfs/006.out
> index a9769721..b7f29f96 100644
> --- a/tests/btrfs/006.out
> +++ b/tests/btrfs/006.out
> @@ -1,4 +1,4 @@
> -== QA output created by 006
> +QA output created by 006
>   == Set filesystem label to TestLabel.006
>   == Get filesystem label
>   TestLabel.006
> diff --git a/tests/btrfs/012.out b/tests/btrfs/012.out
> index 2a41e7e4..7aa5ae94 100644
> --- a/tests/btrfs/012.out
> +++ b/tests/btrfs/012.out
> @@ -1 +1 @@
> -== QA output created by 012
> +QA output created by 012
> diff --git a/tests/generic/184.out b/tests/generic/184.out
> index 2d19691d..4c300543 100644
> --- a/tests/generic/184.out
> +++ b/tests/generic/184.out
> @@ -1 +1 @@
> -QA output created by 184 - silence is golden
> +QA output created by 184
>
diff mbox series

Patch

diff --git a/tests/btrfs/006.out b/tests/btrfs/006.out
index a9769721..b7f29f96 100644
--- a/tests/btrfs/006.out
+++ b/tests/btrfs/006.out
@@ -1,4 +1,4 @@ 
-== QA output created by 006
+QA output created by 006
 == Set filesystem label to TestLabel.006
 == Get filesystem label
 TestLabel.006
diff --git a/tests/btrfs/012.out b/tests/btrfs/012.out
index 2a41e7e4..7aa5ae94 100644
--- a/tests/btrfs/012.out
+++ b/tests/btrfs/012.out
@@ -1 +1 @@ 
-== QA output created by 012
+QA output created by 012
diff --git a/tests/generic/184.out b/tests/generic/184.out
index 2d19691d..4c300543 100644
--- a/tests/generic/184.out
+++ b/tests/generic/184.out
@@ -1 +1 @@ 
-QA output created by 184 - silence is golden
+QA output created by 184