diff mbox series

[net-next] net: flow_dissector: fix RPS on DSA masters

Message ID 20210614135819.504455-1-olteanv@gmail.com (mailing list archive)
State Accepted
Commit ec13357263fb672390250fcfaa4c86b6dce66062
Delegated to: Netdev Maintainers
Headers show
Series [net-next] net: flow_dissector: fix RPS on DSA masters | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for net-next
netdev/subject_prefix success Link
netdev/cc_maintainers warning 9 maintainers not CCed: wangqing@vivo.com wenxu@ucloud.cn dcaratti@redhat.com andriin@fb.com alobakin@pm.me ast@kernel.org jakub@cloudflare.com eranbe@nvidia.com lariel@mellanox.com
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 1 this patch: 1
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 10 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 1 this patch: 1
netdev/header_inline success Link

Commit Message

Vladimir Oltean June 14, 2021, 1:58 p.m. UTC 
From: Vladimir Oltean <vladimir.oltean@nxp.com>

After the blamed patch, __skb_flow_dissect() on the DSA master stopped
adjusting for the length of the DSA headers. This is because it was told
to adjust only if the needed_headroom is zero, aka if there is no DSA
header. Of course, the adjustment should be done only if there _is_ a
DSA header.

Modify the comment too so it is clearer.

Fixes: 4e50025129ef ("net: dsa: generalize overhead for taggers that use both headers and trailers")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/core/flow_dissector.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org June 14, 2021, 8:20 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 14 Jun 2021 16:58:19 +0300 you wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> After the blamed patch, __skb_flow_dissect() on the DSA master stopped
> adjusting for the length of the DSA headers. This is because it was told
> to adjust only if the needed_headroom is zero, aka if there is no DSA
> header. Of course, the adjustment should be done only if there _is_ a
> DSA header.
> 
> [...]

Here is the summary with links:
  - [net-next] net: flow_dissector: fix RPS on DSA masters
    https://git.kernel.org/netdev/net-next/c/ec13357263fb

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index c04455981c1e..2aadbfc5193b 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -943,8 +943,8 @@  bool __skb_flow_dissect(const struct net *net,
 			int offset = 0;
 
 			ops = skb->dev->dsa_ptr->tag_ops;
-			/* Tail taggers don't break flow dissection */
-			if (!ops->needed_headroom) {
+			/* Only DSA header taggers break flow dissection */
+			if (ops->needed_headroom) {
 				if (ops->flow_dissect)
 					ops->flow_dissect(skb, &proto, &offset);
 				else