diff mbox series

[06/20] ARM: dts: imx6q-dhcom: Add the parallel system bus

Message ID 20210526105417.52996-7-cniedermaier@dh-electronics.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx6q-dhcom: Fix/update PDK2 board and adding PicoITX and DRC02 board | expand

Commit Message

Christoph Niedermaier May 26, 2021, 10:54 a.m. UTC 
Add the parallel system bus provided by the i.MX6 weim interface
via an address latch.

Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Marek Vasut <marex@denx.de>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: kernel@dh-electronics.com
To: linux-arm-kernel@lists.infradead.org
---
 arch/arm/boot/dts/imx6q-dhcom-som.dtsi | 56 ++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

Comments

Shawn Guo June 12, 2021, 4:19 a.m. UTC | #1 
On Wed, May 26, 2021 at 12:54:03PM +0200, Christoph Niedermaier wrote:
> Add the parallel system bus provided by the i.MX6 weim interface
> via an address latch.
> 
> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: kernel@dh-electronics.com
> To: linux-arm-kernel@lists.infradead.org
> ---
>  arch/arm/boot/dts/imx6q-dhcom-som.dtsi | 56 ++++++++++++++++++++++++++++++++++
>  1 file changed, 56 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> index 4bf51f3ce003..ad9cb50cdd0e 100644
> --- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> +++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> @@ -46,6 +46,13 @@
>  		vin-supply = <&sw2_reg>;
>  	};
>  
> +	reg_latch_oe_on: regulator-latch-oe-on {
> +		compatible = "regulator-fixed";
> +		gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;

enable-active-high is missing?

Shawn

> +		regulator-always-on;
> +		regulator-name = "latch_oe_on";
> +	};
> +
>  	reg_usb_otg_vbus: regulator-usb-otg-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "usb_otg_vbus";
> @@ -455,6 +462,43 @@
>  			MX6QDL_PAD_SD4_DAT7__SD4_DATA7		0x17059
>  		>;
>  	};
> +
> +	pinctrl_weim: weim-grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_EIM_OE__EIM_OE_B		0xb0a6
> +			MX6QDL_PAD_EIM_RW__EIM_RW		0xb0a6 /* WE */
> +			MX6QDL_PAD_EIM_LBA__EIM_LBA_B		0xb060 /* LE */
> +			MX6QDL_PAD_EIM_D22__GPIO3_IO22		0x130b0
> +			MX6QDL_PAD_EIM_DA15__EIM_AD15		0xb0a6
> +			MX6QDL_PAD_EIM_DA14__EIM_AD14		0xb0a6
> +			MX6QDL_PAD_EIM_DA13__EIM_AD13		0xb0a6
> +			MX6QDL_PAD_EIM_DA12__EIM_AD12		0xb0a6
> +			MX6QDL_PAD_EIM_DA11__EIM_AD11		0xb0a6
> +			MX6QDL_PAD_EIM_DA10__EIM_AD10		0xb0a6
> +			MX6QDL_PAD_EIM_DA9__EIM_AD09		0xb0a6
> +			MX6QDL_PAD_EIM_DA8__EIM_AD08		0xb0a6
> +			MX6QDL_PAD_EIM_DA7__EIM_AD07		0xb0a6
> +			MX6QDL_PAD_EIM_DA6__EIM_AD06		0xb0a6
> +			MX6QDL_PAD_EIM_DA5__EIM_AD05		0xb0a6
> +			MX6QDL_PAD_EIM_DA4__EIM_AD04		0xb0a6
> +			MX6QDL_PAD_EIM_DA3__EIM_AD03		0xb0a6
> +			MX6QDL_PAD_EIM_DA2__EIM_AD02		0xb0a6
> +			MX6QDL_PAD_EIM_DA1__EIM_AD01		0xb0a6
> +			MX6QDL_PAD_EIM_DA0__EIM_AD00		0xb0a6
> +		>;
> +	};
> +
> +	pinctrl_weim_cs0: weim-cs0-grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_EIM_CS0__EIM_CS0_B		0xb0b1
> +		>;
> +	};
> +
> +	pinctrl_weim_cs1: weim-cs1-grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_EIM_CS1__EIM_CS1_B		0xb0b1
> +		>;
> +	};
>  };
>  
>  &reg_arm {
> @@ -544,3 +588,15 @@
>  	keep-power-in-suspend;
>  	status = "okay";
>  };
> +
> +&weim {
> +	#address-cells = <2>;
> +	#size-cells = <1>;
> +	fsl,weim-cs-gpr = <&gpr>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_weim &pinctrl_weim_cs0 &pinctrl_weim_cs1>;
> +	/* It is necessary to setup 2x 64MB otherwise setting gpr fails */
> +	ranges = <0 0  0x08000000  0x04000000>, /* CS0 */
> +		 <1 0  0x0c000000  0x04000000>; /* CS1 */
> +	status = "disabled";
> +};
> -- 
> 2.11.0
>
Christoph Niedermaier June 16, 2021, 1:20 p.m. UTC | #2 
From: Shawn Guo [mailto:shawnguo@kernel.org]
Sent: Saturday, June 12, 2021 6:20 AM

> On Wed, May 26, 2021 at 12:54:03PM +0200, Christoph Niedermaier wrote:
>> Add the parallel system bus provided by the i.MX6 weim interface
>> via an address latch.
>>
>> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Marek Vasut <marex@denx.de>
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> Cc: kernel@dh-electronics.com
>> To: linux-arm-kernel@lists.infradead.org
>> ---
>>  arch/arm/boot/dts/imx6q-dhcom-som.dtsi | 56 ++++++++++++++++++++++++++++++++++
>>  1 file changed, 56 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
>> index 4bf51f3ce003..ad9cb50cdd0e 100644
>> --- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
>> +++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
>> @@ -46,6 +46,13 @@
>>               vin-supply = <&sw2_reg>;
>>       };
>>
>> +     reg_latch_oe_on: regulator-latch-oe-on {
>> +             compatible = "regulator-fixed";
>> +             gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
> 
> enable-active-high is missing?
> 
> Shawn

No, it is active low.
I will fix it on Version 2.

Christoph

> 
>> +             regulator-always-on;
>> +             regulator-name = "latch_oe_on";
>> +     };
>> +
>>       reg_usb_otg_vbus: regulator-usb-otg-vbus {
>>               compatible = "regulator-fixed";
>>               regulator-name = "usb_otg_vbus";
>> @@ -455,6 +462,43 @@
>>                       MX6QDL_PAD_SD4_DAT7__SD4_DATA7          0x17059
>>               >;
>>       };
>> +
>> +     pinctrl_weim: weim-grp {
>> +             fsl,pins = <
>> +                     MX6QDL_PAD_EIM_OE__EIM_OE_B             0xb0a6
>> +                     MX6QDL_PAD_EIM_RW__EIM_RW               0xb0a6 /* WE */
>> +                     MX6QDL_PAD_EIM_LBA__EIM_LBA_B           0xb060 /* LE */
>> +                     MX6QDL_PAD_EIM_D22__GPIO3_IO22          0x130b0
>> +                     MX6QDL_PAD_EIM_DA15__EIM_AD15           0xb0a6
>> +                     MX6QDL_PAD_EIM_DA14__EIM_AD14           0xb0a6
>> +                     MX6QDL_PAD_EIM_DA13__EIM_AD13           0xb0a6
>> +                     MX6QDL_PAD_EIM_DA12__EIM_AD12           0xb0a6
>> +                     MX6QDL_PAD_EIM_DA11__EIM_AD11           0xb0a6
>> +                     MX6QDL_PAD_EIM_DA10__EIM_AD10           0xb0a6
>> +                     MX6QDL_PAD_EIM_DA9__EIM_AD09            0xb0a6
>> +                     MX6QDL_PAD_EIM_DA8__EIM_AD08            0xb0a6
>> +                     MX6QDL_PAD_EIM_DA7__EIM_AD07            0xb0a6
>> +                     MX6QDL_PAD_EIM_DA6__EIM_AD06            0xb0a6
>> +                     MX6QDL_PAD_EIM_DA5__EIM_AD05            0xb0a6
>> +                     MX6QDL_PAD_EIM_DA4__EIM_AD04            0xb0a6
>> +                     MX6QDL_PAD_EIM_DA3__EIM_AD03            0xb0a6
>> +                     MX6QDL_PAD_EIM_DA2__EIM_AD02            0xb0a6
>> +                     MX6QDL_PAD_EIM_DA1__EIM_AD01            0xb0a6
>> +                     MX6QDL_PAD_EIM_DA0__EIM_AD00            0xb0a6
>> +             >;
>> +     };
>> +
>> +     pinctrl_weim_cs0: weim-cs0-grp {
>> +             fsl,pins = <
>> +                     MX6QDL_PAD_EIM_CS0__EIM_CS0_B           0xb0b1
>> +             >;
>> +     };
>> +
>> +     pinctrl_weim_cs1: weim-cs1-grp {
>> +             fsl,pins = <
>> +                     MX6QDL_PAD_EIM_CS1__EIM_CS1_B           0xb0b1
>> +             >;
>> +     };
>>  };
>>
>>  &reg_arm {
>> @@ -544,3 +588,15 @@
>>       keep-power-in-suspend;
>>       status = "okay";
>>  };
>> +
>> +&weim {
>> +     #address-cells = <2>;
>> +     #size-cells = <1>;
>> +     fsl,weim-cs-gpr = <&gpr>;
>> +     pinctrl-names = "default";
>> +     pinctrl-0 = <&pinctrl_weim &pinctrl_weim_cs0 &pinctrl_weim_cs1>;
>> +     /* It is necessary to setup 2x 64MB otherwise setting gpr fails */
>> +     ranges = <0 0  0x08000000  0x04000000>, /* CS0 */
>> +              <1 0  0x0c000000  0x04000000>; /* CS1 */
>> +     status = "disabled";
>> +};
>> --
>> 2.11.0
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
index 4bf51f3ce003..ad9cb50cdd0e 100644
--- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
+++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
@@ -46,6 +46,13 @@ 
 		vin-supply = <&sw2_reg>;
 	};
 
+	reg_latch_oe_on: regulator-latch-oe-on {
+		compatible = "regulator-fixed";
+		gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
+		regulator-always-on;
+		regulator-name = "latch_oe_on";
+	};
+
 	reg_usb_otg_vbus: regulator-usb-otg-vbus {
 		compatible = "regulator-fixed";
 		regulator-name = "usb_otg_vbus";
@@ -455,6 +462,43 @@ 
 			MX6QDL_PAD_SD4_DAT7__SD4_DATA7		0x17059
 		>;
 	};
+
+	pinctrl_weim: weim-grp {
+		fsl,pins = <
+			MX6QDL_PAD_EIM_OE__EIM_OE_B		0xb0a6
+			MX6QDL_PAD_EIM_RW__EIM_RW		0xb0a6 /* WE */
+			MX6QDL_PAD_EIM_LBA__EIM_LBA_B		0xb060 /* LE */
+			MX6QDL_PAD_EIM_D22__GPIO3_IO22		0x130b0
+			MX6QDL_PAD_EIM_DA15__EIM_AD15		0xb0a6
+			MX6QDL_PAD_EIM_DA14__EIM_AD14		0xb0a6
+			MX6QDL_PAD_EIM_DA13__EIM_AD13		0xb0a6
+			MX6QDL_PAD_EIM_DA12__EIM_AD12		0xb0a6
+			MX6QDL_PAD_EIM_DA11__EIM_AD11		0xb0a6
+			MX6QDL_PAD_EIM_DA10__EIM_AD10		0xb0a6
+			MX6QDL_PAD_EIM_DA9__EIM_AD09		0xb0a6
+			MX6QDL_PAD_EIM_DA8__EIM_AD08		0xb0a6
+			MX6QDL_PAD_EIM_DA7__EIM_AD07		0xb0a6
+			MX6QDL_PAD_EIM_DA6__EIM_AD06		0xb0a6
+			MX6QDL_PAD_EIM_DA5__EIM_AD05		0xb0a6
+			MX6QDL_PAD_EIM_DA4__EIM_AD04		0xb0a6
+			MX6QDL_PAD_EIM_DA3__EIM_AD03		0xb0a6
+			MX6QDL_PAD_EIM_DA2__EIM_AD02		0xb0a6
+			MX6QDL_PAD_EIM_DA1__EIM_AD01		0xb0a6
+			MX6QDL_PAD_EIM_DA0__EIM_AD00		0xb0a6
+		>;
+	};
+
+	pinctrl_weim_cs0: weim-cs0-grp {
+		fsl,pins = <
+			MX6QDL_PAD_EIM_CS0__EIM_CS0_B		0xb0b1
+		>;
+	};
+
+	pinctrl_weim_cs1: weim-cs1-grp {
+		fsl,pins = <
+			MX6QDL_PAD_EIM_CS1__EIM_CS1_B		0xb0b1
+		>;
+	};
 };
 
 &reg_arm {
@@ -544,3 +588,15 @@ 
 	keep-power-in-suspend;
 	status = "okay";
 };
+
+&weim {
+	#address-cells = <2>;
+	#size-cells = <1>;
+	fsl,weim-cs-gpr = <&gpr>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_weim &pinctrl_weim_cs0 &pinctrl_weim_cs1>;
+	/* It is necessary to setup 2x 64MB otherwise setting gpr fails */
+	ranges = <0 0  0x08000000  0x04000000>, /* CS0 */
+		 <1 0  0x0c000000  0x04000000>; /* CS1 */
+	status = "disabled";
+};