| Message ID | 20210618100155.101386-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 040c12570e6865b1a219c9d7f7f4a924a6570d1e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: bridge: remove redundant continue statement | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: nikolay@nvidia.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On 18/06/2021 13:01, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The continue statement at the end of a for-loop has no effect, > invert the if expression and remove the continue. > > Addresses-Coverity: ("Continue has no effect") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > net/bridge/br_vlan.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c > index da3256a3eed0..8789a57af543 100644 > --- a/net/bridge/br_vlan.c > +++ b/net/bridge/br_vlan.c > @@ -113,9 +113,7 @@ static void __vlan_add_list(struct net_bridge_vlan *v) > headp = &vg->vlan_list; > list_for_each_prev(hpos, headp) { > vent = list_entry(hpos, struct net_bridge_vlan, vlist); > - if (v->vid < vent->vid) > - continue; > - else > + if (v->vid >= vent->vid) > break; > } > list_add_rcu(&v->vlist, hpos); > This should be targeted at net-next. Thanks, Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 18 Jun 2021 11:01:55 +0100 you wrote: > From: Colin Ian King <colin.king@canonical.com> > > The continue statement at the end of a for-loop has no effect, > invert the if expression and remove the continue. > > Addresses-Coverity: ("Continue has no effect") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > [...] Here is the summary with links: - net: bridge: remove redundant continue statement https://git.kernel.org/netdev/net-next/c/040c12570e68 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c index da3256a3eed0..8789a57af543 100644 --- a/net/bridge/br_vlan.c +++ b/net/bridge/br_vlan.c @@ -113,9 +113,7 @@ static void __vlan_add_list(struct net_bridge_vlan *v) headp = &vg->vlan_list; list_for_each_prev(hpos, headp) { vent = list_entry(hpos, struct net_bridge_vlan, vlist); - if (v->vid < vent->vid) - continue; - else + if (v->vid >= vent->vid) break; } list_add_rcu(&v->vlist, hpos);