| Message ID | YMyixn98qQXjsiqe@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a25503617834920e772b9abda608d902dbf26b5c |
| Headers | show |
| Series | scsi: elx: efct: fix uninitialized variable in debug output | expand |
On 6/18/2021 6:42 AM, Dan Carpenter wrote: > Move the debug output down a couple lines so that "id" is initialized. > > Fixes: 692e5d73a811 ("scsi: elx: efct: LIO backend interface routines") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/scsi/elx/efct/efct_lio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Yep! Same patch sent by Nathan Chancellor: https://lore.kernel.org/linux-scsi/20210617061721.2405511-1-nathan@kernel.org/ -- james
diff --git a/drivers/scsi/elx/efct/efct_lio.c b/drivers/scsi/elx/efct/efct_lio.c index e1bab2b17e4d..b7d69ff29c09 100644 --- a/drivers/scsi/elx/efct/efct_lio.c +++ b/drivers/scsi/elx/efct/efct_lio.c @@ -1212,12 +1212,12 @@ static void efct_lio_setup_session(struct work_struct *work) return; } - efc_log_debug(efct, "new initiator sess=%p node=%p id: %llx\n", - se_sess, node, id); - tgt_node = node->tgt_node; id = (u64) tgt_node->port_fc_id << 32 | tgt_node->node_fc_id; + efc_log_debug(efct, "new initiator sess=%p node=%p id: %llx\n", + se_sess, node, id); + if (xa_err(xa_store(&efct->lookup, id, tgt_node, GFP_KERNEL))) efc_log_err(efct, "Node lookup store failed\n");
Move the debug output down a couple lines so that "id" is initialized. Fixes: 692e5d73a811 ("scsi: elx: efct: LIO backend interface routines") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/scsi/elx/efct/efct_lio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)