| Message ID | 1623840570-42004-1-git-send-email-wujianguo106@163.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix some mptcp syncookie process bugs | expand |
On Wed, 16 Jun 2021, wujianguo106@163.com wrote: > From: Jianguo Wu <wujianguo@chinatelecom.cn> > > v4->v5: > patch1: no changes > patch2: no changes > patch3: no changes > patch4: add comment Hi Jianguo - One other thing that's helpful for reviewers on the list is to use the patch prefixes listed at https://github.com/multipath-tcp/mptcp_net-next/wiki/Patch-prefixes when emailing patches to mptcp@lists.linux.dev For example, if these patches are intended for net-next they should be sent with [PATCH mptcp-next] in the subject line, or for the net tree they should have [PATCH mptcp-net]. If you're unsure where the patches belong, please ask! Thanks, Mat > > v3->v4: > patch1: using seq and sport/dport for hashing, and ignore network headers altogether, > as suggest by Florian > patch2: no changes > patch3: no changes > patch4: no changes > > v2->v3: > patch1: directly use inet6_ehashfn() for IPv6 > patch2: no changes > patch3: no changes > patch4: add Fixes tag. > > v1->v2: > patch1: handle ipv6 sockets/addresses, > always use 4-tuple drived hash and never look at skb->hash > patch2: no changes > patch3: split into 2 patches. > patch4: new added. > > Jianguo Wu (4): > mptcp: fix warning in __skb_flow_dissect() when do syn cookie for > subflow join > mptcp: remove redundant req destruct in subflow_check_req() > mptcp: fix syncookie process if mptcp can not_accept new subflow > mptcp: avoid processing packet if a subflow reset > > net/mptcp/options.c | 6 ++++++ > net/mptcp/subflow.c | 11 +++-------- > net/mptcp/syncookies.c | 16 +++++++++++++++- > 3 files changed, 24 insertions(+), 9 deletions(-) > > -- > 1.8.3.1 > > > -- Mat Martineau Intel
Hi Mat, On 2021/6/19 8:26, Mat Martineau wrote: > On Wed, 16 Jun 2021, wujianguo106@163.com wrote: > >> From: Jianguo Wu <wujianguo@chinatelecom.cn> >> >> v4->v5: >> patch1: no changes >> patch2: no changes >> patch3: no changes >> patch4: add comment > > Hi Jianguo - > > One other thing that's helpful for reviewers on the list is to use the patch prefixes listed at https://github.com/multipath-tcp/mptcp_net-next/wiki/Patch-prefixes > when emailing patches to mptcp@lists.linux.dev > Thanks for your reminding! > For example, if these patches are intended for net-next they should be sent with [PATCH mptcp-next] in the subject line, or for the net tree they should have [PATCH mptcp-net]. If you're unsure where the patches belong, please ask! > and this patchset should use [PATCH mptcp-next]? > Thanks, > > Mat > > >> >> v3->v4: >> patch1: using seq and sport/dport for hashing, and ignore network headers altogether, >> as suggest by Florian >> patch2: no changes >> patch3: no changes >> patch4: no changes >> >> v2->v3: >> patch1: directly use inet6_ehashfn() for IPv6 >> patch2: no changes >> patch3: no changes >> patch4: add Fixes tag. >> >> v1->v2: >> patch1: handle ipv6 sockets/addresses, >> always use 4-tuple drived hash and never look at skb->hash >> patch2: no changes >> patch3: split into 2 patches. >> patch4: new added. >> >> Jianguo Wu (4): >> mptcp: fix warning in __skb_flow_dissect() when do syn cookie for >> subflow join >> mptcp: remove redundant req destruct in subflow_check_req() >> mptcp: fix syncookie process if mptcp can not_accept new subflow >> mptcp: avoid processing packet if a subflow reset >> >> net/mptcp/options.c | 6 ++++++ >> net/mptcp/subflow.c | 11 +++-------- >> net/mptcp/syncookies.c | 16 +++++++++++++++- >> 3 files changed, 24 insertions(+), 9 deletions(-) >> >> -- >> 1.8.3.1 >> >> >> > > -- > Mat Martineau > Intel
On Mon, 21 Jun 2021, Jianguo Wu wrote: > Hi Mat, > > On 2021/6/19 8:26, Mat Martineau wrote: >> On Wed, 16 Jun 2021, wujianguo106@163.com wrote: >> >>> From: Jianguo Wu <wujianguo@chinatelecom.cn> >>> >>> v4->v5: >>> patch1: no changes >>> patch2: no changes >>> patch3: no changes >>> patch4: add comment >> >> Hi Jianguo - >> >> One other thing that's helpful for reviewers on the list is to use the patch prefixes listed at https://github.com/multipath-tcp/mptcp_net-next/wiki/Patch-prefixes >> when emailing patches to mptcp@lists.linux.dev >> > > Thanks for your reminding! > >> For example, if these patches are intended for net-next they should be sent with [PATCH mptcp-next] in the subject line, or for the net tree they should have [PATCH mptcp-net]. If you're unsure where the patches belong, please ask! >> > > and this patchset should use [PATCH mptcp-next]? I think these look like mptcp-net patches, especially considering the risk of double-free in patch 2. For patch 4 I'm not sure if that would be best for net-next. Is it an optimization or fixing a crash / error / warning? -Mat > >> Thanks, >> >> Mat >> >> >>> >>> v3->v4: >>> patch1: using seq and sport/dport for hashing, and ignore network headers altogether, >>> as suggest by Florian >>> patch2: no changes >>> patch3: no changes >>> patch4: no changes >>> >>> v2->v3: >>> patch1: directly use inet6_ehashfn() for IPv6 >>> patch2: no changes >>> patch3: no changes >>> patch4: add Fixes tag. >>> >>> v1->v2: >>> patch1: handle ipv6 sockets/addresses, >>> always use 4-tuple drived hash and never look at skb->hash >>> patch2: no changes >>> patch3: split into 2 patches. >>> patch4: new added. >>> >>> Jianguo Wu (4): >>> mptcp: fix warning in __skb_flow_dissect() when do syn cookie for >>> subflow join >>> mptcp: remove redundant req destruct in subflow_check_req() >>> mptcp: fix syncookie process if mptcp can not_accept new subflow >>> mptcp: avoid processing packet if a subflow reset >>> >>> net/mptcp/options.c | 6 ++++++ >>> net/mptcp/subflow.c | 11 +++-------- >>> net/mptcp/syncookies.c | 16 +++++++++++++++- >>> 3 files changed, 24 insertions(+), 9 deletions(-) >>> >>> -- ??>> 1.8.3.1 >>> >>> >>> >> >> -- >> Mat Martineau >> Intel > > -- Mat Martineau Intel
From: Jianguo Wu <wujianguo@chinatelecom.cn> v4->v5: patch1: no changes patch2: no changes patch3: no changes patch4: add comment v3->v4: patch1: using seq and sport/dport for hashing, and ignore network headers altogether, as suggest by Florian patch2: no changes patch3: no changes patch4: no changes v2->v3: patch1: directly use inet6_ehashfn() for IPv6 patch2: no changes patch3: no changes patch4: add Fixes tag. v1->v2: patch1: handle ipv6 sockets/addresses, always use 4-tuple drived hash and never look at skb->hash patch2: no changes patch3: split into 2 patches. patch4: new added. Jianguo Wu (4): mptcp: fix warning in __skb_flow_dissect() when do syn cookie for subflow join mptcp: remove redundant req destruct in subflow_check_req() mptcp: fix syncookie process if mptcp can not_accept new subflow mptcp: avoid processing packet if a subflow reset net/mptcp/options.c | 6 ++++++ net/mptcp/subflow.c | 11 +++-------- net/mptcp/syncookies.c | 16 +++++++++++++++- 3 files changed, 24 insertions(+), 9 deletions(-)