mbox series

[v2,0/3] soc: qcom: geni: add support for gpi dma

Message ID 20210618141839.3777270-1-vkoul@kernel.org (mailing list archive)
Headers show
Series soc: qcom: geni: add support for gpi dma | expand

Message

Vinod Koul June 18, 2021, 2:18 p.m. UTC
This is version 2 of the GPI dma series [1]

This series add the GPI DMA in qcom geni drivers. For this we
first need to move GENI_IF_DISABLE_RO and struct geni_wrapper to common
headers and then add support in the gpi dma in geni driver.

The SPI and I2C driver changes shall follow shortly

[1]: http://lore.kernel.org/r/20210111151651.1616813-1-vkoul@kernel.org

Changes in v2:
 - add r-b from Bjorn on patch 1
 - add more details in log for patch 2
 - Fix the comments from Doug and Bjorn for patch3, notable use read, modify
   update for irq registers, use geni_se_irq_clear() for irq, dont update
   single bit registers, add a bit more description for gpi dma etc

Vinod Koul (3):
  soc: qcom: geni: move GENI_IF_DISABLE_RO to common header
  soc: qcom: geni: move struct geni_wrapper to header
  soc: qcom: geni: Add support for gpi dma

 drivers/soc/qcom/qcom-geni-se.c | 47 ++++++++++++++++++++++-----------
 include/linux/qcom-geni-se.h    | 23 ++++++++++++++--
 2 files changed, 52 insertions(+), 18 deletions(-)

Comments

Bjorn Andersson June 18, 2021, 4:59 p.m. UTC | #1
On Fri 18 Jun 09:18 CDT 2021, Vinod Koul wrote:

> This is version 2 of the GPI dma series [1]
> 
> This series add the GPI DMA in qcom geni drivers. For this we
> first need to move GENI_IF_DISABLE_RO and struct geni_wrapper to common
> headers and then add support in the gpi dma in geni driver.
> 
> The SPI and I2C driver changes shall follow shortly
> 

Given that the continuation of this series will have build time
dependencies on these patches I think it would be good to see them all
as one chunk (and practically I can create a immutable branch of the
soc/qcom pieces and share with Wolfram and Mark).

Regards,
Bjorn

> [1]: http://lore.kernel.org/r/20210111151651.1616813-1-vkoul@kernel.org
> 
> Changes in v2:
>  - add r-b from Bjorn on patch 1
>  - add more details in log for patch 2
>  - Fix the comments from Doug and Bjorn for patch3, notable use read, modify
>    update for irq registers, use geni_se_irq_clear() for irq, dont update
>    single bit registers, add a bit more description for gpi dma etc
> 
> Vinod Koul (3):
>   soc: qcom: geni: move GENI_IF_DISABLE_RO to common header
>   soc: qcom: geni: move struct geni_wrapper to header
>   soc: qcom: geni: Add support for gpi dma
> 
>  drivers/soc/qcom/qcom-geni-se.c | 47 ++++++++++++++++++++++-----------
>  include/linux/qcom-geni-se.h    | 23 ++++++++++++++--
>  2 files changed, 52 insertions(+), 18 deletions(-)
> 
> -- 
> 2.31.1
>
Vinod Koul June 20, 2021, 11:06 a.m. UTC | #2
On 18-06-21, 11:59, Bjorn Andersson wrote:
> On Fri 18 Jun 09:18 CDT 2021, Vinod Koul wrote:
> 
> > This is version 2 of the GPI dma series [1]
> > 
> > This series add the GPI DMA in qcom geni drivers. For this we
> > first need to move GENI_IF_DISABLE_RO and struct geni_wrapper to common
> > headers and then add support in the gpi dma in geni driver.
> > 
> > The SPI and I2C driver changes shall follow shortly
> > 
> 
> Given that the continuation of this series will have build time
> dependencies on these patches I think it would be good to see them all
> as one chunk (and practically I can create a immutable branch of the
> soc/qcom pieces and share with Wolfram and Mark).

Okay, let me post full series in few days

> 
> Regards,
> Bjorn
> 
> > [1]: http://lore.kernel.org/r/20210111151651.1616813-1-vkoul@kernel.org
> > 
> > Changes in v2:
> >  - add r-b from Bjorn on patch 1
> >  - add more details in log for patch 2
> >  - Fix the comments from Doug and Bjorn for patch3, notable use read, modify
> >    update for irq registers, use geni_se_irq_clear() for irq, dont update
> >    single bit registers, add a bit more description for gpi dma etc
> > 
> > Vinod Koul (3):
> >   soc: qcom: geni: move GENI_IF_DISABLE_RO to common header
> >   soc: qcom: geni: move struct geni_wrapper to header
> >   soc: qcom: geni: Add support for gpi dma
> > 
> >  drivers/soc/qcom/qcom-geni-se.c | 47 ++++++++++++++++++++++-----------
> >  include/linux/qcom-geni-se.h    | 23 ++++++++++++++--
> >  2 files changed, 52 insertions(+), 18 deletions(-)
> > 
> > -- 
> > 2.31.1
> >