diff mbox series

fuse: use DIV_ROUND_UP helper macro for calculations

Message ID 1621928447-456653-1-git-send-email-wubo40@huawei.com (mailing list archive)
State New, archived
Headers show
Series fuse: use DIV_ROUND_UP helper macro for calculations | expand

Commit Message

Wu Bo May 25, 2021, 7:40 a.m. UTC 
From: Wu Bo <wubo40@huawei.com>

Replace open coded divisor calculations with the DIV_ROUND_UP kernel
macro for better readability.

Signed-off-by: Wu Bo <wubo40@huawei.com>
---
 fs/fuse/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wu Bo June 1, 2021, 6:10 a.m. UTC | #1 
ping ...

On 2021/5/25 15:40, Wu Bo wrote:
> From: Wu Bo <wubo40@huawei.com>
> 
> Replace open coded divisor calculations with the DIV_ROUND_UP kernel
> macro for better readability.
> 
> Signed-off-by: Wu Bo <wubo40@huawei.com>
> ---
>   fs/fuse/file.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 09ef2a4..62443eb 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -1405,7 +1405,7 @@ static int fuse_get_user_pages(struct fuse_args_pages *ap, struct iov_iter *ii,
>   		nbytes += ret;
>   
>   		ret += start;
> -		npages = (ret + PAGE_SIZE - 1) / PAGE_SIZE;
> +		npages = DIV_ROUND_UP(ret, PAGE_SIZE);
>   
>   		ap->descs[ap->num_pages].offset = start;
>   		fuse_page_descs_length_init(ap->descs, ap->num_pages, npages);
>
Miklos Szeredi June 21, 2021, 8:32 a.m. UTC | #2 
On Tue, 25 May 2021 at 09:15, Wu Bo <wubo40@huawei.com> wrote:
>
> From: Wu Bo <wubo40@huawei.com>
>
> Replace open coded divisor calculations with the DIV_ROUND_UP kernel
> macro for better readability.

Applied, thanks.

Miklos
diff mbox series

Patch

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 09ef2a4..62443eb 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1405,7 +1405,7 @@  static int fuse_get_user_pages(struct fuse_args_pages *ap, struct iov_iter *ii,
 		nbytes += ret;
 
 		ret += start;
-		npages = (ret + PAGE_SIZE - 1) / PAGE_SIZE;
+		npages = DIV_ROUND_UP(ret, PAGE_SIZE);
 
 		ap->descs[ap->num_pages].offset = start;
 		fuse_page_descs_length_init(ap->descs, ap->num_pages, npages);