| Message ID | 20210616144324.31652-6-julien@xen.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tools/xenstored: Bug fixes + Improve Live-Update | expand |
> On 16 Jun 2021, at 15:43, Julien Grall <julien@xen.org> wrote: > > From: Julien Grall <jgrall@amazon.com> > > xenstored_core.h will consider live-udpate is not supported if > O_CLOEXEC doesn't exist. However, the header doesn't include the one > defining O_CLOEXEC (i.e. fcntl.h). This means that depending on > the header included, some source file will think Live-Update is not > supported. > > I am not aware of any issue with the existing. Therefore this is just > a latent bug so far. > > Prevent any potential issue by including fcntl.h in xenstored_core.h > > Fixes: cd831ee438 ("tools/xenstore: handle CLOEXEC flag for local files and pipes") > Signed-off-by: Julien Grall <jgrall@amazon.com> Reviewed-by: Luca Fancellu <luca.fancellu@arm.com> > --- > tools/xenstore/xenstored_core.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h > index 34839b34f6e9..dac517156993 100644 > --- a/tools/xenstore/xenstored_core.h > +++ b/tools/xenstore/xenstored_core.h > @@ -24,6 +24,7 @@ > > #include <sys/types.h> > #include <dirent.h> > +#include <fcntl.h> > #include <stdbool.h> > #include <stdint.h> > #include <errno.h> > -- > 2.17.1 > >
On 16.06.21 16:43, Julien Grall wrote: > From: Julien Grall <jgrall@amazon.com> > > xenstored_core.h will consider live-udpate is not supported if > O_CLOEXEC doesn't exist. However, the header doesn't include the one > defining O_CLOEXEC (i.e. fcntl.h). This means that depending on > the header included, some source file will think Live-Update is not > supported. > > I am not aware of any issue with the existing. Therefore this is just > a latent bug so far. > > Prevent any potential issue by including fcntl.h in xenstored_core.h > > Fixes: cd831ee438 ("tools/xenstore: handle CLOEXEC flag for local files and pipes") > Signed-off-by: Julien Grall <jgrall@amazon.com> Reviewed-by: Juergen Gross <jgross@suse.com> Juergen
diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index 34839b34f6e9..dac517156993 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -24,6 +24,7 @@ #include <sys/types.h> #include <dirent.h> +#include <fcntl.h> #include <stdbool.h> #include <stdint.h> #include <errno.h>