| Message ID | 20210619112912.76136-1-rybak.a.v@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3fca954172274668e79df188924865265ed29d03 |
| Headers | show |
| Series | [v2] blame: correct name of config option in docs | expand |
On 19/06/21 18.29, Andrei Rybak wrote: > As can be seen in files "Documentation/blame-options.txt" and > "builtin/blame.c", the name of this configuration option is > "blame.markUnblamableLines". > > Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com> > --- > > Thanks to Bagas Sanjaya for review. Changes since v1: > > - tweaked commit message > > Range-diff: > > 1: e32c298ee8 ! 1: 6ea64765e7 blame: fix typo in documentation > @@ Metadata > Author: Andrei Rybak <rybak.a.v@gmail.com> > > ## Commit message ## > - blame: fix typo in documentation > + blame: correct name of config option in docs > > As can be seen in files "Documentation/blame-options.txt" and > - "builtin/blame.c", the name of this configuration variable is > + "builtin/blame.c", the name of this configuration option is > "blame.markUnblamableLines". > > Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com> > > Documentation/config/blame.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/config/blame.txt b/Documentation/config/blame.txt > index 9468e8599c..4d047c1790 100644 > --- a/Documentation/config/blame.txt > +++ b/Documentation/config/blame.txt > @@ -27,7 +27,7 @@ blame.ignoreRevsFile:: > file names will reset the list of ignored revisions. This option will > be handled before the command line option `--ignore-revs-file`. > > -blame.markUnblamables:: > +blame.markUnblamableLines:: > Mark lines that were changed by an ignored revision that we could not > attribute to another commit with a '*' in the output of > linkgit:git-blame[1]. > Looks OK, thanks for contributing. Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
On 6/20/21 5:37 AM, Bagas Sanjaya wrote: > On 19/06/21 18.29, Andrei Rybak wrote: >> As can be seen in files "Documentation/blame-options.txt" and >> "builtin/blame.c", the name of this configuration option is >> "blame.markUnblamableLines". >> >> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com> > Looks OK, thanks for contributing. > > Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com> > thanks for the fix. =)
diff --git a/Documentation/config/blame.txt b/Documentation/config/blame.txt index 9468e8599c..4d047c1790 100644 --- a/Documentation/config/blame.txt +++ b/Documentation/config/blame.txt @@ -27,7 +27,7 @@ blame.ignoreRevsFile:: file names will reset the list of ignored revisions. This option will be handled before the command line option `--ignore-revs-file`. -blame.markUnblamables:: +blame.markUnblamableLines:: Mark lines that were changed by an ignored revision that we could not attribute to another commit with a '*' in the output of linkgit:git-blame[1].