| Message ID | 20210620114756.31304-4-Kuan-Ying.Lee@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kasan: add memory corruption identification support for hw tag-based kasan | expand |
On Sun, Jun 20, 2021 at 1:48 PM Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com> wrote: > > Add memory corruption identification support for hardware tag-based > mode. We store one old free pointer tag and free backtrace. > > Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com> > Suggested-by: Marco Elver <elver@google.com> > Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> > Cc: Alexander Potapenko <glider@google.com> > Cc: Andrey Konovalov <andreyknvl@gmail.com> > Cc: Dmitry Vyukov <dvyukov@google.com> > Cc: Andrew Morton <akpm@linux-foundation.org> Reviewed-by: Alexander Potapenko <glider@google.com> > --- > lib/Kconfig.kasan | 2 +- > mm/kasan/kasan.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index 6f5d48832139..2cc25792bc2f 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -157,7 +157,7 @@ config KASAN_STACK > > config KASAN_TAGS_IDENTIFY > bool "Enable memory corruption identification" > - depends on KASAN_SW_TAGS > + depends on KASAN_SW_TAGS || KASAN_HW_TAGS > help > This option enables best-effort identification of bug type > (use-after-free or out-of-bounds) at the cost of increased > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index b0fc9a1eb7e3..d6f982b8a84e 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -153,7 +153,7 @@ struct kasan_track { > depot_stack_handle_t stack; > }; > > -#ifdef CONFIG_KASAN_TAGS_IDENTIFY > +#if defined(CONFIG_KASAN_TAGS_IDENTIFY) && defined(CONFIG_KASAN_SW_TAGS) > #define KASAN_NR_FREE_STACKS 5 > #else > #define KASAN_NR_FREE_STACKS 1 > -- > 2.18.0 > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20210620114756.31304-4-Kuan-Ying.Lee%40mediatek.com.
On Sun, Jun 20, 2021 at 2:48 PM Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com> wrote: > > Add memory corruption identification support for hardware tag-based > mode. We store one old free pointer tag and free backtrace. Please explain why only one. > Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com> > Suggested-by: Marco Elver <elver@google.com> > Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> > Cc: Alexander Potapenko <glider@google.com> > Cc: Andrey Konovalov <andreyknvl@gmail.com> > Cc: Dmitry Vyukov <dvyukov@google.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > --- > lib/Kconfig.kasan | 2 +- > mm/kasan/kasan.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index 6f5d48832139..2cc25792bc2f 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -157,7 +157,7 @@ config KASAN_STACK > > config KASAN_TAGS_IDENTIFY > bool "Enable memory corruption identification" > - depends on KASAN_SW_TAGS > + depends on KASAN_SW_TAGS || KASAN_HW_TAGS > help > This option enables best-effort identification of bug type > (use-after-free or out-of-bounds) at the cost of increased > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index b0fc9a1eb7e3..d6f982b8a84e 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -153,7 +153,7 @@ struct kasan_track { > depot_stack_handle_t stack; > }; > > -#ifdef CONFIG_KASAN_TAGS_IDENTIFY > +#if defined(CONFIG_KASAN_TAGS_IDENTIFY) && defined(CONFIG_KASAN_SW_TAGS) > #define KASAN_NR_FREE_STACKS 5 > #else > #define KASAN_NR_FREE_STACKS 1 > -- > 2.18.0 > Other than that: Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
On Tue, 2021-06-22 at 16:54 +0300, Andrey Konovalov wrote: > On Sun, Jun 20, 2021 at 2:48 PM Kuan-Ying Lee > <Kuan-Ying.Lee@mediatek.com> wrote: > > > > Add memory corruption identification support for hardware tag-based > > mode. We store one old free pointer tag and free backtrace. > > Please explain why only one. > Got it. I will rewrite this commit message in v4. > > Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com> > > Suggested-by: Marco Elver <elver@google.com> > > Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> > > Cc: Alexander Potapenko <glider@google.com> > > Cc: Andrey Konovalov <andreyknvl@gmail.com> > > Cc: Dmitry Vyukov <dvyukov@google.com> > > Cc: Andrew Morton <akpm@linux-foundation.org> > > --- > > lib/Kconfig.kasan | 2 +- > > mm/kasan/kasan.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > > index 6f5d48832139..2cc25792bc2f 100644 > > --- a/lib/Kconfig.kasan > > +++ b/lib/Kconfig.kasan > > @@ -157,7 +157,7 @@ config KASAN_STACK > > > > config KASAN_TAGS_IDENTIFY > > bool "Enable memory corruption identification" > > - depends on KASAN_SW_TAGS > > + depends on KASAN_SW_TAGS || KASAN_HW_TAGS > > help > > This option enables best-effort identification of bug > > type > > (use-after-free or out-of-bounds) at the cost of > > increased > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > > index b0fc9a1eb7e3..d6f982b8a84e 100644 > > --- a/mm/kasan/kasan.h > > +++ b/mm/kasan/kasan.h > > @@ -153,7 +153,7 @@ struct kasan_track { > > depot_stack_handle_t stack; > > }; > > > > -#ifdef CONFIG_KASAN_TAGS_IDENTIFY > > +#if defined(CONFIG_KASAN_TAGS_IDENTIFY) && > > defined(CONFIG_KASAN_SW_TAGS) > > #define KASAN_NR_FREE_STACKS 5 > > #else > > #define KASAN_NR_FREE_STACKS 1 > > -- > > 2.18.0 > > > > Other than that: > > Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan index 6f5d48832139..2cc25792bc2f 100644 --- a/lib/Kconfig.kasan +++ b/lib/Kconfig.kasan @@ -157,7 +157,7 @@ config KASAN_STACK config KASAN_TAGS_IDENTIFY bool "Enable memory corruption identification" - depends on KASAN_SW_TAGS + depends on KASAN_SW_TAGS || KASAN_HW_TAGS help This option enables best-effort identification of bug type (use-after-free or out-of-bounds) at the cost of increased diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h index b0fc9a1eb7e3..d6f982b8a84e 100644 --- a/mm/kasan/kasan.h +++ b/mm/kasan/kasan.h @@ -153,7 +153,7 @@ struct kasan_track { depot_stack_handle_t stack; }; -#ifdef CONFIG_KASAN_TAGS_IDENTIFY +#if defined(CONFIG_KASAN_TAGS_IDENTIFY) && defined(CONFIG_KASAN_SW_TAGS) #define KASAN_NR_FREE_STACKS 5 #else #define KASAN_NR_FREE_STACKS 1
Add memory corruption identification support for hardware tag-based mode. We store one old free pointer tag and free backtrace. Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com> Suggested-by: Marco Elver <elver@google.com> Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> Cc: Alexander Potapenko <glider@google.com> Cc: Andrey Konovalov <andreyknvl@gmail.com> Cc: Dmitry Vyukov <dvyukov@google.com> Cc: Andrew Morton <akpm@linux-foundation.org> --- lib/Kconfig.kasan | 2 +- mm/kasan/kasan.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)