| Message ID | 20210617182511.1257629-2-Rao.Shoaib@oracle.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [v1,1/3] RDMA/rxe: Increase value of RXE_MAX_UCONTEXT | expand |
On Thu, Jun 17, 2021 at 11:25:10AM -0700, Rao Shoaib wrote: > From: Rao Shoaib <rao.shoaib@oracle.com> > > In our internal testing we have found that the > current limit is too small, this patch bumps it > up to a higher value required for our tests, which > are indicative of our customer usage. > > Signed-off-by: Rao Shoaib <rao.shoaib@oracle.com> > --- > drivers/infiniband/sw/rxe/rxe_param.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Well, this doesn't apply anymore so please resend the series. I'd prefer you try to get rid of any hard limits that are not exposed in uverbs someplace - like ucontext. Jason
On 6/22/21 11:35 AM, Jason Gunthorpe wrote: > On Thu, Jun 17, 2021 at 11:25:10AM -0700, Rao Shoaib wrote: >> From: Rao Shoaib <rao.shoaib@oracle.com> >> >> In our internal testing we have found that the >> current limit is too small, this patch bumps it >> up to a higher value required for our tests, which >> are indicative of our customer usage. >> >> Signed-off-by: Rao Shoaib <rao.shoaib@oracle.com> >> --- >> drivers/infiniband/sw/rxe/rxe_param.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Well, this doesn't apply anymore so please resend the series. I'd > prefer you try to get rid of any hard limits that are not exposed in > uverbs someplace - like ucontext. > > Jason Jason, Most of the limits are exposed via uverbs. For example, following limits are most likely to be hit by a user application. RXE_MAX_QP RXE_MAX_QP_WR RXE_MAX_CQ RXE_MAX_MR RXE_MAX_PD RXE_MAX_AH RXE_MAX_FMR RXE_MAX_SRQ RXE_MAX_SRQ_WR RXE_MAX_PKEYS RXE_MAX_UCONTEXT However, they are reported in ib_device_attr/ib_uverbs_query_device and these are the limits that I am interested in. So unless I misunderstand you the current patch still applies? Kindly elaborate. Regards, Shoaib
diff --git a/drivers/infiniband/sw/rxe/rxe_param.h b/drivers/infiniband/sw/rxe/rxe_param.h index 2fd5af44258c..3b9b1ff4234f 100644 --- a/drivers/infiniband/sw/rxe/rxe_param.h +++ b/drivers/infiniband/sw/rxe/rxe_param.h @@ -67,7 +67,7 @@ enum rxe_device_param { RXE_MAX_MCAST_QP_ATTACH = 56, RXE_MAX_TOT_MCAST_QP_ATTACH = 0x70000, RXE_MAX_AH = 100, - RXE_MAX_SRQ = 960, + RXE_MAX_SRQ = 17408, RXE_MAX_SRQ_WR = 0x4000, RXE_MIN_SRQ_WR = 1, RXE_MAX_SRQ_SGE = 27,