| Message ID | YNLRn/5JkyYhYwxi@matsya |
|---|---|
| State | Mainlined |
| Headers | show |
| Series | [GIT,PULL] : Generic phy updates for v5.14 | expand |
On Wed, Jun 23, 2021 at 11:45:59AM +0530, Vinod Koul wrote: > Hello Greg, > > Please pull to receive Generic phy subsystem updates for v5.14 > > The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: > > Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tags/phy-for-5.14 > > for you to fetch changes up to f7eedcb8539ddcbb6fe7791f1b4ccf43f905c72f: > > phy: ti: dm816x: Fix the error handling path in 'dm816x_usb_phy_probe() (2021-06-21 12:04:18 +0530) > > ---------------------------------------------------------------- > phy-for-5.14 > > - Updates: > - Yaml conversion for renesas,rcar-gen3 pcie phy and > rockchip-usb-phy bindings > - Support for devm_phy_get() taking NULL phy name > > - New support: > - PCIe phy for Qualcomm IPQ60xx > - PCIe phy for Qualcomm SDX55 > - USB phy for RK3308 > - CAN transceivers phy for TI TCAN104x > - Innosilicon-based CSI dphy for rockchip Why is PHY_MT7621_PCI only y/n? Shouldn't this be able to be built as a module? The USB phy enables this driver, which now forces me to build it into my kernel, which does not seem like a wise idea. I'm not sure which commit in this series does this, but that isn't a good thing. Ah, it's 6eded551cefe ("phy: ralink: Kconfig: convert mt7621-pci-phy into 'bool'"), why is that needed? We are working to turn more code into modules, not force them to be built in, this feels like the wrong way to go :( I don't want to take this series because of this at the moment. thanks, greg k-h
Hi Greg, On Wed, Jun 23, 2021 at 9:21 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Wed, Jun 23, 2021 at 11:45:59AM +0530, Vinod Koul wrote: > > Hello Greg, > > > > Please pull to receive Generic phy subsystem updates for v5.14 > > > > The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: > > > > Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tags/phy-for-5.14 > > > > for you to fetch changes up to f7eedcb8539ddcbb6fe7791f1b4ccf43f905c72f: > > > > phy: ti: dm816x: Fix the error handling path in 'dm816x_usb_phy_probe() (2021-06-21 12:04:18 +0530) > > > > ---------------------------------------------------------------- > > phy-for-5.14 > > > > - Updates: > > - Yaml conversion for renesas,rcar-gen3 pcie phy and > > rockchip-usb-phy bindings > > - Support for devm_phy_get() taking NULL phy name > > > > - New support: > > - PCIe phy for Qualcomm IPQ60xx > > - PCIe phy for Qualcomm SDX55 > > - USB phy for RK3308 > > - CAN transceivers phy for TI TCAN104x > > - Innosilicon-based CSI dphy for rockchip > > Why is PHY_MT7621_PCI only y/n? Shouldn't this be able to be built as a > module? > > The USB phy enables this driver, which now forces me to build it into my > kernel, which does not seem like a wise idea. I'm not sure which commit > in this series does this, but that isn't a good thing. > > Ah, it's 6eded551cefe ("phy: ralink: Kconfig: convert mt7621-pci-phy > into 'bool'"), why is that needed? We are working to turn more code > into modules, not force them to be built in, this feels like the wrong > way to go :( This was turned into bool to automatically be included if CONFIG_PCI_MT7621 is set. This should be the only requirement to add this phy driver for real hardware since it has nothing to do if there is no CONFIG_PCI_MT7621. That's why Kconfig is now: depends on (RALINK && OF && PCI_MT7621) || COMPILE_TEST Am I missing something here??? Thanks, Sergio Paracuellos > > I don't want to take this series because of this at the moment. > > thanks, > > greg k-h
On 23-06-21, 09:29, Sergio Paracuellos wrote: > Hi Greg, > > On Wed, Jun 23, 2021 at 9:21 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > On Wed, Jun 23, 2021 at 11:45:59AM +0530, Vinod Koul wrote: > > > Hello Greg, > > > > > > Please pull to receive Generic phy subsystem updates for v5.14 > > > > > > The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: > > > > > > Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tags/phy-for-5.14 > > > > > > for you to fetch changes up to f7eedcb8539ddcbb6fe7791f1b4ccf43f905c72f: > > > > > > phy: ti: dm816x: Fix the error handling path in 'dm816x_usb_phy_probe() (2021-06-21 12:04:18 +0530) > > > > > > ---------------------------------------------------------------- > > > phy-for-5.14 > > > > > > - Updates: > > > - Yaml conversion for renesas,rcar-gen3 pcie phy and > > > rockchip-usb-phy bindings > > > - Support for devm_phy_get() taking NULL phy name > > > > > > - New support: > > > - PCIe phy for Qualcomm IPQ60xx > > > - PCIe phy for Qualcomm SDX55 > > > - USB phy for RK3308 > > > - CAN transceivers phy for TI TCAN104x > > > - Innosilicon-based CSI dphy for rockchip > > > > Why is PHY_MT7621_PCI only y/n? Shouldn't this be able to be built as a > > module? > > > > The USB phy enables this driver, which now forces me to build it into my > > kernel, which does not seem like a wise idea. I'm not sure which commit > > in this series does this, but that isn't a good thing. > > > > Ah, it's 6eded551cefe ("phy: ralink: Kconfig: convert mt7621-pci-phy > > into 'bool'"), why is that needed? We are working to turn more code > > into modules, not force them to be built in, this feels like the wrong > > way to go :( Agree, I should have _not_ picked this, sorry. I am reverting this commit and sending updated series shortly > This was turned into bool to automatically be included if CONFIG_PCI_MT7621 > is set. This should be the only requirement to add this phy driver for > real hardware since it has nothing to do if there is no > CONFIG_PCI_MT7621. That's why Kconfig is now: > > depends on (RALINK && OF && PCI_MT7621) || COMPILE_TEST > Am I missing something here??? Yes a module can also be added. I think you should select PHY_MT7621_PCI in the PCI_MT7621 Kconfig
On Wed, Jun 23, 2021 at 09:29:06AM +0200, Sergio Paracuellos wrote: > Hi Greg, > > On Wed, Jun 23, 2021 at 9:21 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > On Wed, Jun 23, 2021 at 11:45:59AM +0530, Vinod Koul wrote: > > > Hello Greg, > > > > > > Please pull to receive Generic phy subsystem updates for v5.14 > > > > > > The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: > > > > > > Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tags/phy-for-5.14 > > > > > > for you to fetch changes up to f7eedcb8539ddcbb6fe7791f1b4ccf43f905c72f: > > > > > > phy: ti: dm816x: Fix the error handling path in 'dm816x_usb_phy_probe() (2021-06-21 12:04:18 +0530) > > > > > > ---------------------------------------------------------------- > > > phy-for-5.14 > > > > > > - Updates: > > > - Yaml conversion for renesas,rcar-gen3 pcie phy and > > > rockchip-usb-phy bindings > > > - Support for devm_phy_get() taking NULL phy name > > > > > > - New support: > > > - PCIe phy for Qualcomm IPQ60xx > > > - PCIe phy for Qualcomm SDX55 > > > - USB phy for RK3308 > > > - CAN transceivers phy for TI TCAN104x > > > - Innosilicon-based CSI dphy for rockchip > > > > Why is PHY_MT7621_PCI only y/n? Shouldn't this be able to be built as a > > module? > > > > The USB phy enables this driver, which now forces me to build it into my > > kernel, which does not seem like a wise idea. I'm not sure which commit > > in this series does this, but that isn't a good thing. > > > > Ah, it's 6eded551cefe ("phy: ralink: Kconfig: convert mt7621-pci-phy > > into 'bool'"), why is that needed? We are working to turn more code > > into modules, not force them to be built in, this feels like the wrong > > way to go :( > > This was turned into bool to automatically be included if CONFIG_PCI_MT7621 > is set. This should be the only requirement to add this phy driver for > real hardware since it has nothing to do if there is no > CONFIG_PCI_MT7621. That's why Kconfig is now: > > depends on (RALINK && OF && PCI_MT7621) || COMPILE_TEST > Am I missing something here??? It is forcing it to be built into the kernel, why can it not just be a module? You took that ability away here by making the value a 'bool'. thanks, greg k-h
Hi Vinod, On Wed, Jun 23, 2021 at 9:35 AM Vinod Koul <vkoul@kernel.org> wrote: > > On 23-06-21, 09:29, Sergio Paracuellos wrote: > > Hi Greg, > > > > On Wed, Jun 23, 2021 at 9:21 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > On Wed, Jun 23, 2021 at 11:45:59AM +0530, Vinod Koul wrote: > > > > Hello Greg, > > > > > > > > Please pull to receive Generic phy subsystem updates for v5.14 > > > > > > > > The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: > > > > > > > > Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) > > > > > > > > are available in the Git repository at: > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tags/phy-for-5.14 > > > > > > > > for you to fetch changes up to f7eedcb8539ddcbb6fe7791f1b4ccf43f905c72f: > > > > > > > > phy: ti: dm816x: Fix the error handling path in 'dm816x_usb_phy_probe() (2021-06-21 12:04:18 +0530) > > > > > > > > ---------------------------------------------------------------- > > > > phy-for-5.14 > > > > > > > > - Updates: > > > > - Yaml conversion for renesas,rcar-gen3 pcie phy and > > > > rockchip-usb-phy bindings > > > > - Support for devm_phy_get() taking NULL phy name > > > > > > > > - New support: > > > > - PCIe phy for Qualcomm IPQ60xx > > > > - PCIe phy for Qualcomm SDX55 > > > > - USB phy for RK3308 > > > > - CAN transceivers phy for TI TCAN104x > > > > - Innosilicon-based CSI dphy for rockchip > > > > > > Why is PHY_MT7621_PCI only y/n? Shouldn't this be able to be built as a > > > module? > > > > > > The USB phy enables this driver, which now forces me to build it into my > > > kernel, which does not seem like a wise idea. I'm not sure which commit > > > in this series does this, but that isn't a good thing. > > > > > > Ah, it's 6eded551cefe ("phy: ralink: Kconfig: convert mt7621-pci-phy > > > into 'bool'"), why is that needed? We are working to turn more code > > > into modules, not force them to be built in, this feels like the wrong > > > way to go :( > > Agree, I should have _not_ picked this, sorry. > > I am reverting this commit and sending updated series shortly > > > This was turned into bool to automatically be included if CONFIG_PCI_MT7621 > > is set. This should be the only requirement to add this phy driver for > > real hardware since it has nothing to do if there is no > > CONFIG_PCI_MT7621. That's why Kconfig is now: > > > > depends on (RALINK && OF && PCI_MT7621) || COMPILE_TEST > > Am I missing something here??? > > Yes a module can also be added. I think you should select PHY_MT7621_PCI > in the PCI_MT7621 Kconfig I see. My bad understanding here, sorry. Thanks for reverting this. Best regards, Sergio Paracuellos > > -- > ~Vinod
Hi Greg, On Wed, Jun 23, 2021 at 9:36 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Wed, Jun 23, 2021 at 09:29:06AM +0200, Sergio Paracuellos wrote: > > Hi Greg, > > > > On Wed, Jun 23, 2021 at 9:21 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > On Wed, Jun 23, 2021 at 11:45:59AM +0530, Vinod Koul wrote: > > > > Hello Greg, > > > > > > > > Please pull to receive Generic phy subsystem updates for v5.14 > > > > > > > > The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: > > > > > > > > Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) > > > > > > > > are available in the Git repository at: > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tags/phy-for-5.14 > > > > > > > > for you to fetch changes up to f7eedcb8539ddcbb6fe7791f1b4ccf43f905c72f: > > > > > > > > phy: ti: dm816x: Fix the error handling path in 'dm816x_usb_phy_probe() (2021-06-21 12:04:18 +0530) > > > > > > > > ---------------------------------------------------------------- > > > > phy-for-5.14 > > > > > > > > - Updates: > > > > - Yaml conversion for renesas,rcar-gen3 pcie phy and > > > > rockchip-usb-phy bindings > > > > - Support for devm_phy_get() taking NULL phy name > > > > > > > > - New support: > > > > - PCIe phy for Qualcomm IPQ60xx > > > > - PCIe phy for Qualcomm SDX55 > > > > - USB phy for RK3308 > > > > - CAN transceivers phy for TI TCAN104x > > > > - Innosilicon-based CSI dphy for rockchip > > > > > > Why is PHY_MT7621_PCI only y/n? Shouldn't this be able to be built as a > > > module? > > > > > > The USB phy enables this driver, which now forces me to build it into my > > > kernel, which does not seem like a wise idea. I'm not sure which commit > > > in this series does this, but that isn't a good thing. > > > > > > Ah, it's 6eded551cefe ("phy: ralink: Kconfig: convert mt7621-pci-phy > > > into 'bool'"), why is that needed? We are working to turn more code > > > into modules, not force them to be built in, this feels like the wrong > > > way to go :( > > > > This was turned into bool to automatically be included if CONFIG_PCI_MT7621 > > is set. This should be the only requirement to add this phy driver for > > real hardware since it has nothing to do if there is no > > CONFIG_PCI_MT7621. That's why Kconfig is now: > > > > depends on (RALINK && OF && PCI_MT7621) || COMPILE_TEST > > Am I missing something here??? > > It is forcing it to be built into the kernel, why can it not just be a > module? You took that ability away here by making the value a 'bool'. I see. Thanks for clarification and sorry for the inconvenience. Thanks, Sergio Paracuellos > > thanks, > > greg k-h
Hello Greg, Please pull to receive Generic phy subsystem updates for v5.14 The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tags/phy-for-5.14 for you to fetch changes up to f7eedcb8539ddcbb6fe7791f1b4ccf43f905c72f: phy: ti: dm816x: Fix the error handling path in 'dm816x_usb_phy_probe() (2021-06-21 12:04:18 +0530) ---------------------------------------------------------------- phy-for-5.14 - Updates: - Yaml conversion for renesas,rcar-gen3 pcie phy and rockchip-usb-phy bindings - Support for devm_phy_get() taking NULL phy name - New support: - PCIe phy for Qualcomm IPQ60xx - PCIe phy for Qualcomm SDX55 - USB phy for RK3308 - CAN transceivers phy for TI TCAN104x - Innosilicon-based CSI dphy for rockchip ---------------------------------------------------------------- Amelie Delaunay (2): dt-bindings: phy: add vbus-supply optional property to phy-stm32-usbphyc phy: stm32: manage optional vbus regulator on phy_power_on/off Aswath Govindraju (3): phy: core: Reword the comment specifying the units of max_link_rate to be Mbps dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers phy: phy-can-transceiver: Add support for generic CAN transceiver driver Baruch Siach (2): dt-bindings: phy: qcom,qmp: Add IPQ60xx PCIe PHY bindings dt-bindings: pci: qcom: Document PCIe bindings for IPQ6018 SoC Christophe JAILLET (1): phy: ti: dm816x: Fix the error handling path in 'dm816x_usb_phy_probe() Chunfeng Yun (1): phy: qcom-qmp: remove redundant error of clock bulk Colin Ian King (1): phy: rockchip: remove redundant initialization of pointer cfg Geert Uytterhoeven (1): dt-bindings: phy: renesas,rcar-gen3-pcie-phy: Convert to json-schema He Ying (4): phy: bcm-ns-usb3: Remove redundant dev_err call in bcm_ns_usb3_mdio_probe() phy: phy-mmp3-hsic: Remove redundant dev_err call in mmp3_hsic_phy_probe() phy: phy-mtk-mipi-dsi: Remove redundant dev_err call in mtk_mipi_tx_probe() phy: phy-mtk-hdmi: Remove redundant dev_err call in mtk_hdmi_phy_probe() Heiko Stuebner (2): dt-bindings: phy: add yaml binding for rockchip-inno-csi-dphy phy/rockchip: add Innosilicon-based CSI dphy Johan Jonker (1): dt-bindings: phy: convert rockchip-usb-phy.txt to YAML Kunihiko Hayashi (1): phy: uniphier-pcie: Fix updating phy parameters Manivannan Sadhasivam (3): dt-bindings: phy: qcom,qmp: Add binding for SDX55 PCIe PHY phy: qcom-qmp: Use phy_status field for the status bit offset phy: qcom-qmp: Add support for SDX55 QMP PCIe PHY Mauro Carvalho Chehab (1): MAINTAINERS: update marvell,armada-3700-utmi-phy.yaml reference Rob Herring (1): phy: Allow a NULL phy name for devm_phy_get() Sebastian Fricke (1): phy: phy-core-mipi-dphy.c: Correct reference version Selvam Sathappan Periakaruppan (1): phy: qcom-qmp: add QMP V2 PCIe PHY support for ipq60xx Sergio Paracuellos (5): dt-bindings: phy: mediatek,mt7621-pci-phy: add clock entries phy: ralink: phy-mt7621-pci: use kernel clock APIS phy: ralink: Kconfig: enable COMPILE_TEST on mt7621-pci-phy driver phy: ralink: Kconfig: convert mt7621-pci-phy into 'bool' phy: ralink: phy-mt7621-pci: properly print pointer address Shubhankar Kuranagatti (1): phy: phy-xgene.c: Fix alignment of comment Tobias Schramm (2): dt-bindings: phy: rockchip-inno-usb2: add compatible for rk3308 USB phy phy: phy-rockchip-inno-usb2: add support for RK3308 USB phy YueHaibing (1): phy: phy-twl4030-usb: use DEVICE_ATTR_RO macro .../devicetree/bindings/pci/qcom,pcie.txt | 24 ++ .../bindings/phy/mediatek,mt7621-pci-phy.yaml | 5 + .../bindings/phy/phy-rockchip-inno-usb2.yaml | 1 + .../devicetree/bindings/phy/phy-stm32-usbphyc.yaml | 11 + .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 27 ++ .../devicetree/bindings/phy/rcar-gen3-phy-pcie.txt | 24 -- .../bindings/phy/renesas,rcar-gen3-pcie-phy.yaml | 53 +++ .../bindings/phy/rockchip-inno-csi-dphy.yaml | 79 ++++ .../devicetree/bindings/phy/rockchip-usb-phy.txt | 52 --- .../devicetree/bindings/phy/rockchip-usb-phy.yaml | 81 ++++ .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 56 +++ MAINTAINERS | 4 +- drivers/phy/Kconfig | 9 + drivers/phy/Makefile | 1 + drivers/phy/broadcom/phy-bcm-ns-usb3.c | 4 +- drivers/phy/marvell/phy-mmp3-hsic.c | 4 +- drivers/phy/mediatek/phy-mtk-hdmi.c | 4 +- drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 4 +- drivers/phy/phy-can-transceiver.c | 146 +++++++ drivers/phy/phy-core-mipi-dphy.c | 2 +- drivers/phy/phy-core.c | 16 +- drivers/phy/phy-xgene.c | 3 +- drivers/phy/qualcomm/phy-qcom-qmp.c | 315 +++++++++++++- drivers/phy/qualcomm/phy-qcom-qmp.h | 189 ++++++++- drivers/phy/ralink/Kconfig | 4 +- drivers/phy/ralink/phy-mt7621-pci.c | 37 +- drivers/phy/rockchip/Kconfig | 9 + drivers/phy/rockchip/Makefile | 1 + drivers/phy/rockchip/phy-rockchip-inno-csidphy.c | 459 +++++++++++++++++++++ drivers/phy/rockchip/phy-rockchip-inno-hdmi.c | 4 +- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 44 ++ drivers/phy/socionext/phy-uniphier-pcie.c | 11 +- drivers/phy/st/phy-stm32-usbphyc.c | 31 ++ drivers/phy/ti/phy-dm816x-usb.c | 17 +- drivers/phy/ti/phy-twl4030-usb.c | 6 +- include/linux/phy/phy.h | 2 +- 36 files changed, 1602 insertions(+), 137 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen3-phy-pcie.txt create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen3-pcie-phy.yaml create mode 100644 Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml delete mode 100644 Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt create mode 100644 Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml create mode 100644 Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml create mode 100644 drivers/phy/phy-can-transceiver.c create mode 100644 drivers/phy/rockchip/phy-rockchip-inno-csidphy.c