| Message ID | 20210624080505.21628-1-nicolas.dichtel@6wind.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ff70202b2d1ad522275c6aadc8c53519b6a22c57 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] dev_forward_skb: do not scrub skb mark within the same name space | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | fail | Series targets non-next tree, but doesn't contain any Fixes tags |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 9 maintainers not CCed: yhs@fb.com kpsingh@kernel.org daniel@iogearbox.net andrii@kernel.org bpf@vger.kernel.org kafai@fb.com ast@kernel.org john.fastabend@gmail.com songliubraving@fb.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 5220 this patch: 5220 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 5285 this patch: 5285 |
| netdev/header_inline | success | Link |
Hi Nicholas, On 24/06/2021 11:05, Nicolas Dichtel wrote: > The goal is to keep the mark during a bpf_redirect(), like it is done for > legacy encapsulation / decapsulation, when there is no x-netns. > This was initially done in commit 213dd74aee76 ("skbuff: Do not scrub skb > mark within the same name space"). > > When the call to skb_scrub_packet() was added in dev_forward_skb() (commit > 8b27f27797ca ("skb: allow skb_scrub_packet() to be used by tunnels")), the > second argument (xnet) was set to true to force a call to skb_orphan(). At > this time, the mark was always cleanned up by skb_scrub_packet(), whatever > xnet value was. > This call to skb_orphan() was removed later in commit > 9c4c325252c5 ("skbuff: preserve sock reference when scrubbing the skb."). > But this 'true' stayed here without any real reason. > > Let's correctly set xnet in ____dev_forward_skb(), this function has access > to the previous interface and to the new interface. This change was suggested in the past [1] and I think one of the main concerns was breaking existing callers which assume the mark would be cleared [2]. Personally, I think the suggestion made in [3] adding a flag to bpf_redirect() makes a lot of sense for this use case. Eyal. [1] https://lore.kernel.org/netdev/1520953642-8145-1-git-send-email-liran.alon@oracle.com/ [2] https://lore.kernel.org/netdev/20180315112150.58586758@halley/ [3] https://lore.kernel.org/netdev/cd0b73e3-2cde-1442-4312-566c69571e8a@iogearbox.net/ > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > --- > include/linux/netdevice.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 5cbc950b34df..5ab2d1917ca1 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -4114,7 +4114,7 @@ static __always_inline int ____dev_forward_skb(struct net_device *dev, > return NET_RX_DROP; > } > > - skb_scrub_packet(skb, true); > + skb_scrub_packet(skb, !net_eq(dev_net(dev), dev_net(skb->dev))); > skb->priority = 0; > return 0; > } >
Hi Eyal, Le 24/06/2021 à 14:16, Eyal Birger a écrit : > Hi Nicholas, > > On 24/06/2021 11:05, Nicolas Dichtel wrote: >> The goal is to keep the mark during a bpf_redirect(), like it is done for >> legacy encapsulation / decapsulation, when there is no x-netns. >> This was initially done in commit 213dd74aee76 ("skbuff: Do not scrub skb >> mark within the same name space"). >> >> When the call to skb_scrub_packet() was added in dev_forward_skb() (commit >> 8b27f27797ca ("skb: allow skb_scrub_packet() to be used by tunnels")), the >> second argument (xnet) was set to true to force a call to skb_orphan(). At >> this time, the mark was always cleanned up by skb_scrub_packet(), whatever >> xnet value was. >> This call to skb_orphan() was removed later in commit >> 9c4c325252c5 ("skbuff: preserve sock reference when scrubbing the skb."). >> But this 'true' stayed here without any real reason. >> >> Let's correctly set xnet in ____dev_forward_skb(), this function has access >> to the previous interface and to the new interface. > > This change was suggested in the past [1] and I think one of the main concerns > was breaking existing callers which assume the mark would be cleared [2]. Thank you for the pointers! > > Personally, I think the suggestion made in [3] adding a flag to bpf_redirect() > makes a lot of sense for this use case. I began with this approach, but actually, as I tried to explain in the commit log, this looks more like a bug. This function is called almost everywhere in the kernel (except for openvswitch and wireguard) with the xnet argument reflecting a netns change. In other words, the behavior is different between legacy encapsulation and the one made with ebpf :/ Regards, Nicolas > > Eyal. > > [1] > https://lore.kernel.org/netdev/1520953642-8145-1-git-send-email-liran.alon@oracle.com/ > > > [2] https://lore.kernel.org/netdev/20180315112150.58586758@halley/ > > [3] > https://lore.kernel.org/netdev/cd0b73e3-2cde-1442-4312-566c69571e8a@iogearbox.net/
On 24/06/2021 18:26, Nicolas Dichtel wrote: > Hi Eyal, > > Le 24/06/2021 à 14:16, Eyal Birger a écrit : >> Hi Nicholas, >> >> On 24/06/2021 11:05, Nicolas Dichtel wrote: >>> The goal is to keep the mark during a bpf_redirect(), like it is done for >>> legacy encapsulation / decapsulation, when there is no x-netns. >>> This was initially done in commit 213dd74aee76 ("skbuff: Do not scrub skb >>> mark within the same name space"). >>> >>> When the call to skb_scrub_packet() was added in dev_forward_skb() (commit >>> 8b27f27797ca ("skb: allow skb_scrub_packet() to be used by tunnels")), the >>> second argument (xnet) was set to true to force a call to skb_orphan(). At >>> this time, the mark was always cleanned up by skb_scrub_packet(), whatever >>> xnet value was. >>> This call to skb_orphan() was removed later in commit >>> 9c4c325252c5 ("skbuff: preserve sock reference when scrubbing the skb."). >>> But this 'true' stayed here without any real reason. >>> >>> Let's correctly set xnet in ____dev_forward_skb(), this function has access >>> to the previous interface and to the new interface. >> >> This change was suggested in the past [1] and I think one of the main concerns >> was breaking existing callers which assume the mark would be cleared [2]. > Thank you for the pointers! > >> >> Personally, I think the suggestion made in [3] adding a flag to bpf_redirect() >> makes a lot of sense for this use case. > I began with this approach, but actually, as I tried to explain in the commit > log, this looks more like a bug. This function is called almost everywhere in > the kernel (except for openvswitch and wireguard) with the xnet argument > reflecting a netns change. In other words, the behavior is different between > legacy encapsulation and the one made with ebpf :/ > I agree, and was also surprised that ebpf redirection scrubs the mark in the same ns - and only on ingress! - so I think keeping the mark should have been the default behavior. As noted in the thread though it is not clear whether this would break existing deployments both for ebpf and veth pairs on the same ns. Eyal.
Le 25/06/2021 à 10:45, Eyal Birger a écrit : > > > On 24/06/2021 18:26, Nicolas Dichtel wrote: >> Hi Eyal, >> >> Le 24/06/2021 à 14:16, Eyal Birger a écrit : >>> Hi Nicholas, >>> >>> On 24/06/2021 11:05, Nicolas Dichtel wrote: >>>> The goal is to keep the mark during a bpf_redirect(), like it is done for >>>> legacy encapsulation / decapsulation, when there is no x-netns. >>>> This was initially done in commit 213dd74aee76 ("skbuff: Do not scrub skb >>>> mark within the same name space"). >>>> >>>> When the call to skb_scrub_packet() was added in dev_forward_skb() (commit >>>> 8b27f27797ca ("skb: allow skb_scrub_packet() to be used by tunnels")), the >>>> second argument (xnet) was set to true to force a call to skb_orphan(). At >>>> this time, the mark was always cleanned up by skb_scrub_packet(), whatever >>>> xnet value was. >>>> This call to skb_orphan() was removed later in commit >>>> 9c4c325252c5 ("skbuff: preserve sock reference when scrubbing the skb."). >>>> But this 'true' stayed here without any real reason. >>>> >>>> Let's correctly set xnet in ____dev_forward_skb(), this function has access >>>> to the previous interface and to the new interface. >>> >>> This change was suggested in the past [1] and I think one of the main concerns >>> was breaking existing callers which assume the mark would be cleared [2]. >> Thank you for the pointers! >> >>> >>> Personally, I think the suggestion made in [3] adding a flag to bpf_redirect() >>> makes a lot of sense for this use case. >> I began with this approach, but actually, as I tried to explain in the commit >> log, this looks more like a bug. This function is called almost everywhere in >> the kernel (except for openvswitch and wireguard) with the xnet argument >> reflecting a netns change. In other words, the behavior is different between >> legacy encapsulation and the one made with ebpf :/ >> > > I agree, and was also surprised that ebpf redirection scrubs the mark in the > same ns - and only on ingress! - so I think keeping the mark should have been Yes, there is also this asymmetry :/ > the default behavior. As noted in the thread though it is not clear whether this > would break existing deployments both for ebpf and veth pairs on the same ns. To summarize: - it's not consistent between legacy tunnels and ebpf; - it's not consistent between ingress and egress; - it was already fixed in the past for legacy tunnel (commit 213dd74aee76); - this kind of patch has already been done in the past, see commit + 963a88b31ddb ("tunnels: harmonize cleanup done on skb on xmit path"); + ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx path"); - nobody stated (on netdev at least) that he relied on this behavior. For all those reasons, I'm inclined to think that this patch is acceptable. Obviously, it's not my decision ;-) Note also that clearing the mark is possible directly in the ebpf prog, preserving it not. It means that, in the worst case of someone relying on this, the bug can be fixed without patching the kernel. A trade-off could be to reset the mark in the veth case only. Side note: the mark was not cleared (for veth) between 2.6.34 and 3.4, see commit 59b9997baba5 ("Revert "net: maintain namespace isolation between vlan and real device"") and the revert was not done due to this ;-) Comments are welcomed. Regards, Nicolas
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 24 Jun 2021 10:05:05 +0200 you wrote: > The goal is to keep the mark during a bpf_redirect(), like it is done for > legacy encapsulation / decapsulation, when there is no x-netns. > This was initially done in commit 213dd74aee76 ("skbuff: Do not scrub skb > mark within the same name space"). > > When the call to skb_scrub_packet() was added in dev_forward_skb() (commit > 8b27f27797ca ("skb: allow skb_scrub_packet() to be used by tunnels")), the > second argument (xnet) was set to true to force a call to skb_orphan(). At > this time, the mark was always cleanned up by skb_scrub_packet(), whatever > xnet value was. > This call to skb_orphan() was removed later in commit > 9c4c325252c5 ("skbuff: preserve sock reference when scrubbing the skb."). > But this 'true' stayed here without any real reason. > > [...] Here is the summary with links: - [net] dev_forward_skb: do not scrub skb mark within the same name space https://git.kernel.org/netdev/net/c/ff70202b2d1a You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 5cbc950b34df..5ab2d1917ca1 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -4114,7 +4114,7 @@ static __always_inline int ____dev_forward_skb(struct net_device *dev, return NET_RX_DROP; } - skb_scrub_packet(skb, true); + skb_scrub_packet(skb, !net_eq(dev_net(dev), dev_net(skb->dev))); skb->priority = 0; return 0; }
The goal is to keep the mark during a bpf_redirect(), like it is done for legacy encapsulation / decapsulation, when there is no x-netns. This was initially done in commit 213dd74aee76 ("skbuff: Do not scrub skb mark within the same name space"). When the call to skb_scrub_packet() was added in dev_forward_skb() (commit 8b27f27797ca ("skb: allow skb_scrub_packet() to be used by tunnels")), the second argument (xnet) was set to true to force a call to skb_orphan(). At this time, the mark was always cleanned up by skb_scrub_packet(), whatever xnet value was. This call to skb_orphan() was removed later in commit 9c4c325252c5 ("skbuff: preserve sock reference when scrubbing the skb."). But this 'true' stayed here without any real reason. Let's correctly set xnet in ____dev_forward_skb(), this function has access to the previous interface and to the new interface. Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> --- include/linux/netdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)