| Message ID | 20210623103039.9881-1-msuchanek@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amdgpu/dc: Really fix DCN3.1 Makefile for PPC64 | expand |
On 2021-06-23 6:30 a.m., Michal Suchanek wrote: > Also copy over the part that makes old gcc handling cross-platform. > > Fixes: df7a1658f257 ("drm/amdgpu/dc: fix DCN3.1 Makefile for PPC64") > Fixes: 926d6972efb6 ("drm/amd/display: Add DCN3.1 blocks to the DC Makefile") > Signed-off-by: Michal Suchanek <msuchanek@suse.de> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > The fact that the old gcc handling triggers on gcc 10 and 11 is another > story I don't want to delve into. > --- > drivers/gpu/drm/amd/display/dc/dcn31/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/Makefile b/drivers/gpu/drm/amd/display/dc/dcn31/Makefile > index 5dcdc5a858fe..4bab97acb155 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn31/Makefile > +++ b/drivers/gpu/drm/amd/display/dc/dcn31/Makefile > @@ -28,6 +28,7 @@ endif > CFLAGS_$(AMDDALPATH)/dc/dcn31/dcn31_resource.o += -mhard-float > endif > > +ifdef CONFIG_X86 > ifdef IS_OLD_GCC > # Stack alignment mismatch, proceed with caution. > # GCC < 7.1 cannot compile code using `double` and -mpreferred-stack-boundary=3 > @@ -36,6 +37,7 @@ CFLAGS_$(AMDDALPATH)/dc/dcn31/dcn31_resource.o += -mpreferred-stack-boundary=4 > else > CFLAGS_$(AMDDALPATH)/dc/dcn31/dcn31_resource.o += -msse2 > endif > +endif > > AMD_DAL_DCN31 = $(addprefix $(AMDDALPATH)/dc/dcn31/,$(DCN31)) > >
Applied. Thanks! Alex On Fri, Jun 25, 2021 at 4:14 PM Harry Wentland <harry.wentland@amd.com> wrote: > > On 2021-06-23 6:30 a.m., Michal Suchanek wrote: > > Also copy over the part that makes old gcc handling cross-platform. > > > > Fixes: df7a1658f257 ("drm/amdgpu/dc: fix DCN3.1 Makefile for PPC64") > > Fixes: 926d6972efb6 ("drm/amd/display: Add DCN3.1 blocks to the DC Makefile") > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > > Harry > > > --- > > The fact that the old gcc handling triggers on gcc 10 and 11 is another > > story I don't want to delve into. > > --- > > drivers/gpu/drm/amd/display/dc/dcn31/Makefile | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/Makefile b/drivers/gpu/drm/amd/display/dc/dcn31/Makefile > > index 5dcdc5a858fe..4bab97acb155 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dcn31/Makefile > > +++ b/drivers/gpu/drm/amd/display/dc/dcn31/Makefile > > @@ -28,6 +28,7 @@ endif > > CFLAGS_$(AMDDALPATH)/dc/dcn31/dcn31_resource.o += -mhard-float > > endif > > > > +ifdef CONFIG_X86 > > ifdef IS_OLD_GCC > > # Stack alignment mismatch, proceed with caution. > > # GCC < 7.1 cannot compile code using `double` and -mpreferred-stack-boundary=3 > > @@ -36,6 +37,7 @@ CFLAGS_$(AMDDALPATH)/dc/dcn31/dcn31_resource.o += -mpreferred-stack-boundary=4 > > else > > CFLAGS_$(AMDDALPATH)/dc/dcn31/dcn31_resource.o += -msse2 > > endif > > +endif > > > > AMD_DAL_DCN31 = $(addprefix $(AMDDALPATH)/dc/dcn31/,$(DCN31)) > > > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/Makefile b/drivers/gpu/drm/amd/display/dc/dcn31/Makefile index 5dcdc5a858fe..4bab97acb155 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn31/Makefile +++ b/drivers/gpu/drm/amd/display/dc/dcn31/Makefile @@ -28,6 +28,7 @@ endif CFLAGS_$(AMDDALPATH)/dc/dcn31/dcn31_resource.o += -mhard-float endif +ifdef CONFIG_X86 ifdef IS_OLD_GCC # Stack alignment mismatch, proceed with caution. # GCC < 7.1 cannot compile code using `double` and -mpreferred-stack-boundary=3 @@ -36,6 +37,7 @@ CFLAGS_$(AMDDALPATH)/dc/dcn31/dcn31_resource.o += -mpreferred-stack-boundary=4 else CFLAGS_$(AMDDALPATH)/dc/dcn31/dcn31_resource.o += -msse2 endif +endif AMD_DAL_DCN31 = $(addprefix $(AMDDALPATH)/dc/dcn31/,$(DCN31))
Also copy over the part that makes old gcc handling cross-platform. Fixes: df7a1658f257 ("drm/amdgpu/dc: fix DCN3.1 Makefile for PPC64") Fixes: 926d6972efb6 ("drm/amd/display: Add DCN3.1 blocks to the DC Makefile") Signed-off-by: Michal Suchanek <msuchanek@suse.de> --- The fact that the old gcc handling triggers on gcc 10 and 11 is another story I don't want to delve into. --- drivers/gpu/drm/amd/display/dc/dcn31/Makefile | 2 ++ 1 file changed, 2 insertions(+)