| Message ID | 20210628054522.1718786-2-steffen.klassert@secunet.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 335a2a1fcefc948927e8c15636d9dc5d983b8f50 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [01/17] esp: drop unneeded assignment in esp4_gro_receive() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Pull request |
| netdev/fixes_present | success | Link |
| netdev/patch_count | warning | Series longer than 15 patches |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: yoshfuji@linux-ipv6.org dsahern@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 13 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 28 Jun 2021 07:45:06 +0200 you wrote: > From: Yang Li <yang.lee@linux.alibaba.com> > > Making '!=' operation with 0 directly after calling > the function xfrm_parse_spi() is more efficient, > assignment to err is redundant. > > Eliminate the following clang_analyzer warning: > net/ipv4/esp4_offload.c:41:7: warning: Although the value stored to > 'err' is used in the enclosing expression, the value is never actually > read from 'err' > > [...] Here is the summary with links: - [01/17] esp: drop unneeded assignment in esp4_gro_receive() https://git.kernel.org/netdev/net-next/c/335a2a1fcefc - [02/17] xfrm: add state hashtable keyed by seq https://git.kernel.org/netdev/net-next/c/fe9f1d8779cb - [03/17] net: Remove unnecessary variables https://git.kernel.org/netdev/net-next/c/a925316af80a - [04/17] xfrm: remove description from xfrm_type struct https://git.kernel.org/netdev/net-next/c/152bca090243 - [05/17] xfrm: policy: fix a spelling mistake https://git.kernel.org/netdev/net-next/c/7a7ae1eba24a - [06/17] xfrm: ipv6: add xfrm6_hdr_offset helper https://git.kernel.org/netdev/net-next/c/9acf4d3b9ec1 - [07/17] xfrm: ipv6: move mip6_destopt_offset into xfrm core https://git.kernel.org/netdev/net-next/c/37b9e7eb5565 - [08/17] xfrm: ipv6: move mip6_rthdr_offset into xfrm core https://git.kernel.org/netdev/net-next/c/848b18fb7fbd - [09/17] xfrm: remove hdr_offset indirection https://git.kernel.org/netdev/net-next/c/d1002d2490e3 - [10/17] xfrm: merge dstopt and routing hdroff functions https://git.kernel.org/netdev/net-next/c/3ca5ca83e206 - [11/17] xfrm: delete xfrm4_output_finish xfrm6_output_finish declarations https://git.kernel.org/netdev/net-next/c/1b50dd478f49 - [12/17] xfrm: avoid compiler warning when ipv6 is disabled https://git.kernel.org/netdev/net-next/c/30ad6a84f60b - [13/17] xfrm: replay: avoid xfrm replay notify indirection https://git.kernel.org/netdev/net-next/c/cfc61c598e43 - [14/17] xfrm: replay: remove advance indirection https://git.kernel.org/netdev/net-next/c/c7f877833c9f - [15/17] xfrm: replay: remove recheck indirection https://git.kernel.org/netdev/net-next/c/25cfb8bc97c2 - [16/17] xfrm: replay: avoid replay indirection https://git.kernel.org/netdev/net-next/c/adfc2fdbae30 - [17/17] xfrm: replay: remove last replay indirection https://git.kernel.org/netdev/net-next/c/b5a1d1fe0cbb You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/ipv4/esp4_offload.c b/net/ipv4/esp4_offload.c index 33687cf58286..be019a1fe3af 100644 --- a/net/ipv4/esp4_offload.c +++ b/net/ipv4/esp4_offload.c @@ -33,12 +33,11 @@ static struct sk_buff *esp4_gro_receive(struct list_head *head, struct xfrm_state *x; __be32 seq; __be32 spi; - int err; if (!pskb_pull(skb, offset)) return NULL; - if ((err = xfrm_parse_spi(skb, IPPROTO_ESP, &spi, &seq)) != 0) + if (xfrm_parse_spi(skb, IPPROTO_ESP, &spi, &seq) != 0) goto out; xo = xfrm_offload(skb);