[-next] clk: stm32mp1: fix missing spin_lock_init()

Commit Message

Wang Hai June 30, 2021, 1:58 a.m. UTC

The driver allocates the spinlock but not initialize it.
Use spin_lock_init() on it to initialize it correctly.

Fixes: c392df194a2d ("clk: stm32mp1: move RCC reset controller into RCC clock driver")
Reported-by: Hulk Robot <[e-mail]>
Signed-off-by: Wang Hai <[e-mail]>
---
 drivers/clk/clk-stm32mp1.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Boyd June 30, 2021, 6:17 p.m. UTC | #1

Quoting Wang Hai (2021-06-29 18:58:23)
> The driver allocates the spinlock but not initialize it.
> Use spin_lock_init() on it to initialize it correctly.
> 
> Fixes: c392df194a2d ("clk: stm32mp1: move RCC reset controller into RCC clock driver")
> Reported-by: Hulk Robot <[e-mail]>
> Signed-off-by: Wang Hai <[e-mail]>
> ---

Applied to clk-next

Patch

diff --git a/drivers/clk/clk-stm32mp1.c b/drivers/clk/clk-stm32mp1.c
index 6adc625e79c..256575bd29b 100644
--- a/drivers/clk/clk-stm32mp1.c
+++ b/drivers/clk/clk-stm32mp1.c
@@ -2263,6 +2263,7 @@  static int stm32_rcc_reset_init(struct device *dev, void __iomem *base,
 	if (!reset_data)
 		return -ENOMEM;
 
+	spin_lock_init(&reset_data->lock);
 	reset_data->membase = base;
 	reset_data->rcdev.owner = THIS_MODULE;
 	reset_data->rcdev.ops = &stm32_reset_ops;