| Message ID | 1624560727-6870-12-git-send-email-sibis@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Use qmp_send to update co-processor load state | expand |
On Fri, Jun 25, 2021 at 12:22:05AM +0530, Sibi Sankar wrote: > The load state resources are expected to follow the life cycle of the > remote processor it tracks. However, modeling load state resources as > power-domains result in them getting turned off during system suspend > and thereby falling out of sync with the remote processors that are still > on. Fix this by replacing load state resource control through the generic > qmp message send interface instead. nit: the above sounds as if this patch does all of that, when it only removes power domain support. Instead you could start with saying what the patch actually does (remove power domain support), followed by why PD support isn't needed anymore (now done by sending QMP messages directly). > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > --- > drivers/soc/qcom/qcom_aoss.c | 109 ++----------------------------------------- > 1 file changed, 3 insertions(+), 106 deletions(-) > > diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c > index 998ee7605eb2..f0c3726e8c46 100644 > --- a/drivers/soc/qcom/qcom_aoss.c > +++ b/drivers/soc/qcom/qcom_aoss.c > > ... > > @@ -650,13 +550,11 @@ static int qmp_probe(struct platform_device *pdev) > if (ret) > goto err_close_qmp; > > - ret = qmp_pd_add(qmp); > - if (ret) > - goto err_remove_qdss_clk; > - > ret = qmp_cooling_devices_register(qmp); > - if (ret) > + if (ret) { > dev_err(&pdev->dev, "failed to register aoss cooling devices\n"); > + goto err_remove_qdss_clk; This isn't really related with the PD removal, right? I wonder if it was intentional to have _probe() succeed even when the cooling device registration failed, since the cooling devices aren't essential. If it is still desirable to fail the change should be done in a separate patch, unless it is actually related with removing PD support.
On 2021-06-26 03:31, Matthias Kaehlcke wrote: > On Fri, Jun 25, 2021 at 12:22:05AM +0530, Sibi Sankar wrote: >> The load state resources are expected to follow the life cycle of the >> remote processor it tracks. However, modeling load state resources as >> power-domains result in them getting turned off during system suspend >> and thereby falling out of sync with the remote processors that are >> still >> on. Fix this by replacing load state resource control through the >> generic >> qmp message send interface instead. > > nit: the above sounds as if this patch does all of that, when it only > removes power domain support. Instead you could start with saying what > the patch actually does (remove power domain support), followed by why > PD support isn't needed anymore (now done by sending QMP messages > directly). > sure, will fix this up in the next re-spin. >> Signed-off-by: Sibi Sankar <sibis@codeaurora.org> >> --- >> drivers/soc/qcom/qcom_aoss.c | 109 >> ++----------------------------------------- >> 1 file changed, 3 insertions(+), 106 deletions(-) >> >> diff --git a/drivers/soc/qcom/qcom_aoss.c >> b/drivers/soc/qcom/qcom_aoss.c >> index 998ee7605eb2..f0c3726e8c46 100644 >> --- a/drivers/soc/qcom/qcom_aoss.c >> +++ b/drivers/soc/qcom/qcom_aoss.c >> >> ... >> >> @@ -650,13 +550,11 @@ static int qmp_probe(struct platform_device >> *pdev) >> if (ret) >> goto err_close_qmp; >> >> - ret = qmp_pd_add(qmp); >> - if (ret) >> - goto err_remove_qdss_clk; >> - >> ret = qmp_cooling_devices_register(qmp); >> - if (ret) >> + if (ret) { >> dev_err(&pdev->dev, "failed to register aoss cooling devices\n"); >> + goto err_remove_qdss_clk; > > This isn't really related with the PD removal, right? I wonder if it > was > intentional to have _probe() succeed even when the cooling device > registration failed, since the cooling devices aren't essential. > Thanks for catching ^^ > If it is still desirable to fail the change should be done in a > separate > patch, unless it is actually related with removing PD support.
diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c index 998ee7605eb2..f0c3726e8c46 100644 --- a/drivers/soc/qcom/qcom_aoss.c +++ b/drivers/soc/qcom/qcom_aoss.c @@ -2,7 +2,6 @@ /* * Copyright (c) 2019, Linaro Ltd */ -#include <dt-bindings/power/qcom-aoss-qmp.h> #include <linux/clk-provider.h> #include <linux/debugfs.h> #include <linux/interrupt.h> @@ -11,7 +10,6 @@ #include <linux/module.h> #include <linux/of_platform.h> #include <linux/platform_device.h> -#include <linux/pm_domain.h> #include <linux/thermal.h> #include <linux/slab.h> #include <linux/soc/qcom/qcom_aoss.h> @@ -68,7 +66,6 @@ struct qmp_cooling_device { * @event: wait_queue for synchronization with the IRQ * @tx_lock: provides synchronization between multiple callers of qmp_send() * @qdss_clk: QDSS clock hw struct - * @pd_data: genpd data * @cooling_devs: thermal cooling devices */ struct qmp { @@ -88,20 +85,12 @@ struct qmp { struct mutex tx_lock; struct clk_hw qdss_clk; - struct genpd_onecell_data pd_data; struct qmp_cooling_device *cooling_devs; #if IS_ENABLED(CONFIG_DEBUG_FS) struct dentry *debugfs_file; #endif /* CONFIG_DEBUG_FS */ }; -struct qmp_pd { - struct qmp *qmp; - struct generic_pm_domain pd; -}; - -#define to_qmp_pd_resource(res) container_of(res, struct qmp_pd, pd) - static void qmp_kick(struct qmp *qmp) { mbox_send_message(qmp->mbox_chan, NULL); @@ -330,95 +319,6 @@ static void qmp_qdss_clk_remove(struct qmp *qmp) clk_hw_unregister(&qmp->qdss_clk); } -static int qmp_pd_power_toggle(struct qmp_pd *res, bool enable) -{ - char buf[QMP_MSG_LEN] = {}; - - snprintf(buf, sizeof(buf), - "{class: image, res: load_state, name: %s, val: %s}", - res->pd.name, enable ? "on" : "off"); - return qmp_send(res->qmp, buf, sizeof(buf)); -} - -static int qmp_pd_power_on(struct generic_pm_domain *domain) -{ - return qmp_pd_power_toggle(to_qmp_pd_resource(domain), true); -} - -static int qmp_pd_power_off(struct generic_pm_domain *domain) -{ - return qmp_pd_power_toggle(to_qmp_pd_resource(domain), false); -} - -static const char * const sdm845_resources[] = { - [AOSS_QMP_LS_CDSP] = "cdsp", - [AOSS_QMP_LS_LPASS] = "adsp", - [AOSS_QMP_LS_MODEM] = "modem", - [AOSS_QMP_LS_SLPI] = "slpi", - [AOSS_QMP_LS_SPSS] = "spss", - [AOSS_QMP_LS_VENUS] = "venus", -}; - -static int qmp_pd_add(struct qmp *qmp) -{ - struct genpd_onecell_data *data = &qmp->pd_data; - struct device *dev = qmp->dev; - struct qmp_pd *res; - size_t num = ARRAY_SIZE(sdm845_resources); - int ret; - int i; - - res = devm_kcalloc(dev, num, sizeof(*res), GFP_KERNEL); - if (!res) - return -ENOMEM; - - data->domains = devm_kcalloc(dev, num, sizeof(*data->domains), - GFP_KERNEL); - if (!data->domains) - return -ENOMEM; - - for (i = 0; i < num; i++) { - res[i].qmp = qmp; - res[i].pd.name = sdm845_resources[i]; - res[i].pd.power_on = qmp_pd_power_on; - res[i].pd.power_off = qmp_pd_power_off; - - ret = pm_genpd_init(&res[i].pd, NULL, true); - if (ret < 0) { - dev_err(dev, "failed to init genpd\n"); - goto unroll_genpds; - } - - data->domains[i] = &res[i].pd; - } - - data->num_domains = i; - - ret = of_genpd_add_provider_onecell(dev->of_node, data); - if (ret < 0) - goto unroll_genpds; - - return 0; - -unroll_genpds: - for (i--; i >= 0; i--) - pm_genpd_remove(data->domains[i]); - - return ret; -} - -static void qmp_pd_remove(struct qmp *qmp) -{ - struct genpd_onecell_data *data = &qmp->pd_data; - struct device *dev = qmp->dev; - int i; - - of_genpd_del_provider(dev->of_node); - - for (i = 0; i < data->num_domains; i++) - pm_genpd_remove(data->domains[i]); -} - static int qmp_cdev_get_max_state(struct thermal_cooling_device *cdev, unsigned long *state) { @@ -650,13 +550,11 @@ static int qmp_probe(struct platform_device *pdev) if (ret) goto err_close_qmp; - ret = qmp_pd_add(qmp); - if (ret) - goto err_remove_qdss_clk; - ret = qmp_cooling_devices_register(qmp); - if (ret) + if (ret) { dev_err(&pdev->dev, "failed to register aoss cooling devices\n"); + goto err_remove_qdss_clk; + } platform_set_drvdata(pdev, qmp); @@ -689,7 +587,6 @@ static int qmp_remove(struct platform_device *pdev) #endif /* CONFIG_DEBUG_FS */ qmp_qdss_clk_remove(qmp); - qmp_pd_remove(qmp); qmp_cooling_devices_remove(qmp); qmp_close(qmp);
The load state resources are expected to follow the life cycle of the remote processor it tracks. However, modeling load state resources as power-domains result in them getting turned off during system suspend and thereby falling out of sync with the remote processors that are still on. Fix this by replacing load state resource control through the generic qmp message send interface instead. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- drivers/soc/qcom/qcom_aoss.c | 109 ++----------------------------------------- 1 file changed, 3 insertions(+), 106 deletions(-)