| Message ID | 1625038079-25815-1-git-send-email-kyrie.wu@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Support jpeg encode for MT8195 | expand |
On Wed, Jun 30, 2021 at 3:28 PM kyrie.wu <kyrie.wu@mediatek.com> wrote: > add component framework to using multi-HW for MT8195 jpeg encode. Could you add some summary for each patch for getting an overview of the series? > dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible > media: mtk-jpegenc: Add MT8195 JPEG venc driver > media: mtk-jpegenc: remove redundant code of irq > media: mtk-jpegenc: Refactor jpeg clock interface > media: mtk-jpegenc: Generalize jpeg encode irq interfaces > media: mtk-jpegenc: Generalize jpegenc HW timeout interfaces > media: mtk-jpegenc: Use component framework to manage each hardware > information > media: mtk-jpegenc: Generalize jpegenc HW operations interfaces > media: mtk-jpegenc: Refactor jpegenc device run interface The series has some consistency issues which would make readers feel uncomfortable. For example: - Whether to capitalize the first characters in the commit messages/titles. - Whether to add a period at the end of English sentences.
On Tue, Jul 06, 2021 at 07:00:17PM +0800, Tzung-Bi Shih wrote: > On Wed, Jun 30, 2021 at 3:28 PM kyrie.wu <kyrie.wu@mediatek.com> wrote: > > add component framework to using multi-HW for MT8195 jpeg encode. > Could you add some summary for each patch for getting an overview of the series? > > > dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible > > media: mtk-jpegenc: Add MT8195 JPEG venc driver > > media: mtk-jpegenc: remove redundant code of irq > > media: mtk-jpegenc: Refactor jpeg clock interface > > media: mtk-jpegenc: Generalize jpeg encode irq interfaces > > media: mtk-jpegenc: Generalize jpegenc HW timeout interfaces > > media: mtk-jpegenc: Use component framework to manage each hardware > > information > > media: mtk-jpegenc: Generalize jpegenc HW operations interfaces > > media: mtk-jpegenc: Refactor jpegenc device run interface > The series has some consistency issues which would make readers feel > uncomfortable. > > For example: > - Whether to capitalize the first characters in the commit messages/titles. > - Whether to add a period at the end of English sentences. FWIW, it's not customary to add a period at the end of a patch subject. Best regards, Tomasz
Hi Kyrie, On Wed, Jun 30, 2021 at 4:31 PM kyrie.wu <kyrie.wu@mediatek.com> wrote: > > add component framework to using multi-HW for MT8195 jpeg encode. > > kyrie.wu (9): > dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible > media: mtk-jpegenc: Add MT8195 JPEG venc driver > media: mtk-jpegenc: remove redundant code of irq > media: mtk-jpegenc: Refactor jpeg clock interface > media: mtk-jpegenc: Generalize jpeg encode irq interfaces > media: mtk-jpegenc: Generalize jpegenc HW timeout interfaces > media: mtk-jpegenc: Use component framework to manage each hardware > information > media: mtk-jpegenc: Generalize jpegenc HW operations interfaces > media: mtk-jpegenc: Refactor jpegenc device run interface > > .../bindings/media/mediatek-jpeg-encoder.yaml | 3 + > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 600 +++++++++++++++++---- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h | 69 ++- > drivers/media/platform/mtk-jpeg/mtk_jpeg_enc_hw.c | 208 +++++++ > 4 files changed, 786 insertions(+), 94 deletions(-) > > --- > This patch dependents on "dt-bindings: mediatek: convert mtk jpeg decoder/encoder to yaml"[1] > > Please also accept this patch together with [1]. > > [1]https://lore.kernel.org/patchwork/patch/1445298/ Thank you for the series. However, I gave reviewing it a try and unfortunately had a very hard time following it, because of the way the patches are organized. Please make sure to read and understand the kernel patch submission guide[1], adjust the series appropriately and send a new version which I'll review. [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html Best regards, Tomasz
add component framework to using multi-HW for MT8195 jpeg encode. kyrie.wu (9): dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible media: mtk-jpegenc: Add MT8195 JPEG venc driver media: mtk-jpegenc: remove redundant code of irq media: mtk-jpegenc: Refactor jpeg clock interface media: mtk-jpegenc: Generalize jpeg encode irq interfaces media: mtk-jpegenc: Generalize jpegenc HW timeout interfaces media: mtk-jpegenc: Use component framework to manage each hardware information media: mtk-jpegenc: Generalize jpegenc HW operations interfaces media: mtk-jpegenc: Refactor jpegenc device run interface .../bindings/media/mediatek-jpeg-encoder.yaml | 3 + drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 600 +++++++++++++++++---- drivers/media/platform/mtk-jpeg/mtk_jpeg_core.h | 69 ++- drivers/media/platform/mtk-jpeg/mtk_jpeg_enc_hw.c | 208 +++++++ 4 files changed, 786 insertions(+), 94 deletions(-) --- This patch dependents on "dt-bindings: mediatek: convert mtk jpeg decoder/encoder to yaml"[1] Please also accept this patch together with [1]. [1]https://lore.kernel.org/patchwork/patch/1445298/ ---