| Message ID | 20210716151447.833967-1-tudor.ambarus@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers | expand |
On 16/07/2021 18:14:46+0300, Tudor Ambarus wrote: > Even since the addition CONFIG_VIDEO_HANTRO was set to n because > it did not respect the dependency chain. It doesn't respect it now > either, remove it. > Shouldn't you rather ensure it is enabled so we get it for sama5d4? > Fixes: a0e6830c95b7 ("ARM: configs: at91: sama5: enable the Hantro G1 engine") > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> > --- > arch/arm/configs/sama5_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig > index 17db3b3e2dd3..1ccf84091dd7 100644 > --- a/arch/arm/configs/sama5_defconfig > +++ b/arch/arm/configs/sama5_defconfig > @@ -207,7 +207,6 @@ CONFIG_AT_HDMAC=y > CONFIG_AT_XDMAC=y > CONFIG_STAGING=y > CONFIG_STAGING_MEDIA=y > -CONFIG_VIDEO_HANTRO=m > # CONFIG_IOMMU_SUPPORT is not set > CONFIG_IIO=y > CONFIG_AT91_ADC=y > -- > 2.25.1 >
On 7/16/21 6:59 PM, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 16/07/2021 18:14:46+0300, Tudor Ambarus wrote: >> Even since the addition CONFIG_VIDEO_HANTRO was set to n because >> it did not respect the dependency chain. It doesn't respect it now >> either, remove it. >> > > Shouldn't you rather ensure it is enabled so we get it for sama5d4? CONFIG_VIDEO_HANTRO has the following dependency chain: Depends on: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && (ARCH_MXC [=n] || ARCH_ROCKCHIP [=n] || COMPILE_TEST [=n]) && VIDEO_DEV [=y] && VIDEO_V4L2 [=y] Maybe a better fix is to add ARCH_AT91 in the list of supported archs. Emil, can you shed some light on this? > >> Fixes: a0e6830c95b7 ("ARM: configs: at91: sama5: enable the Hantro G1 engine") >> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> >> --- >> arch/arm/configs/sama5_defconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig >> index 17db3b3e2dd3..1ccf84091dd7 100644 >> --- a/arch/arm/configs/sama5_defconfig >> +++ b/arch/arm/configs/sama5_defconfig >> @@ -207,7 +207,6 @@ CONFIG_AT_HDMAC=y >> CONFIG_AT_XDMAC=y >> CONFIG_STAGING=y >> CONFIG_STAGING_MEDIA=y >> -CONFIG_VIDEO_HANTRO=m >> # CONFIG_IOMMU_SUPPORT is not set >> CONFIG_IIO=y >> CONFIG_AT91_ADC=y >> -- >> 2.25.1 >> > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com >
diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index 17db3b3e2dd3..1ccf84091dd7 100644 --- a/arch/arm/configs/sama5_defconfig +++ b/arch/arm/configs/sama5_defconfig @@ -207,7 +207,6 @@ CONFIG_AT_HDMAC=y CONFIG_AT_XDMAC=y CONFIG_STAGING=y CONFIG_STAGING_MEDIA=y -CONFIG_VIDEO_HANTRO=m # CONFIG_IOMMU_SUPPORT is not set CONFIG_IIO=y CONFIG_AT91_ADC=y
Even since the addition CONFIG_VIDEO_HANTRO was set to n because it did not respect the dependency chain. It doesn't respect it now either, remove it. Fixes: a0e6830c95b7 ("ARM: configs: at91: sama5: enable the Hantro G1 engine") Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> --- arch/arm/configs/sama5_defconfig | 1 - 1 file changed, 1 deletion(-)