[00/15] Subject: Protection information and block size cleanup

Message ID	20210609033929.3815-1-martin.petersen@oracle.com (mailing list archive)
Headers	show Return-Path: <linux-scsi-owner@kernel.org> From: "Martin K. Petersen" <martin.petersen@oracle.com> To: linux-scsi@vger.kernel.org Cc: "Martin K. Petersen" <martin.petersen@oracle.com> Subject: [PATCH 00/15] Subject: Protection information and block size cleanup Date: Tue, 8 Jun 2021 23:39:14 -0400 Message-Id: <20210609033929.3815-1-martin.petersen@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Precedence: bulk
Series	Subject: Protection information and block size cleanup \| expand [00/15] Subject: Protection information and block size cleanup [01/15] scsi: core: Add scsi_prot_ref_tag() helper [02/15] scsi: lpfc: Use the proper SCSI midlayer interfaces for PI [03/15] scsi: qla2xxx: Use the proper SCSI midlayer interfaces for PI [04/15] scsi: mpt3sas: Use the proper SCSI midlayer interfaces for PI [05/15] scsi: mpi3mr: Use the proper SCSI midlayer interfaces for PI [06/15] scsi: zfcp: Use the proper SCSI midlayer interfaces for PI [07/15] scsi: isci: Use the proper SCSI midlayer interfaces for PI [08/15] scsi: scsi_debug: Remove dump_sector() [09/15] scsi: scsi_debug: Improve RDPROTECT/WRPROTECT handling [10/15] scsi: core: Introduce scsi_get_sector() [11/15] scsi: iser: Use scsi_get_sector() instead of scsi_get_lba() [12/15] scsi: core: Make scsi_get_lba() return the LBA [13/15] scsi: core: Add helper to return number of logical blocks in a request [14/15] scsi: lpfc: Switch to scsi_get_block_count() [15/15] scsi: ufs: core: Use scsi_get_lba() to get LBA

Message ID

20210609033929.3815-1-martin.petersen@oracle.com (mailing list archive)

Headers

From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: linux-scsi@vger.kernel.org
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 00/15] Subject: Protection information and block size cleanup
Date: Tue,  8 Jun 2021 23:39:14 -0400
Message-Id: <20210609033929.3815-1-martin.petersen@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.mkp.ca.oracle.com (138.3.201.9) by
 SN7PR04CA0034.namprd04.prod.outlook.com (2603:10b6:806:120::9) with Microsoft
 SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend
 Transport; Wed, 9 Jun 2021 03:39:31 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 71d21e97-61ee-499c-f74d-08d92af83193
X-MS-TrafficTypeDiagnostic: PH0PR10MB4422:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
 <PH0PR10MB44221061BBA6A5C9B1BC1C238E369@PH0PR10MB4422.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
 tRUqGzFdnd4rqs0ez25negPR0pKMLM2Z/C/SLMa/mxBimyPrX8d5/B4LtCySFKpDayR0+JVlSFVtPgKcVGnUjBBJ91E4MdZaI6GP2agLSbkTUp7uQBLnKupg0r+r1w3ezJMxlE1nnSF0I0H2MORawUeLa9Lw29WnYdqPynQxKqRVqJqBV57VUlUq5cGYGotLbzBYANZAadv6JXjhivkS7kroDrVyQhuRCNKGklXkZbgdAF0yYdq2I9EcRu9raKqZ5YwXz3Q6Ty4ZBqzbRpSoAqmJxpJrSdn/kWYmr98JKGqeiRJo4ucZRhlk5Ai3rFOTiAa0Mg1HcKWdOXMxH6Pn1mOIZXlePfe/kAqWOAIgkI/R0nGCouCiNt0kPsRBTHeybxRLJ4bw33iY9TnBGXZXG8LBZ4UUvNghaH630Tfzz/8S56rvLPN+nAx6kgFxZ+Yne5LuDweW9V4HAwvmV5xSJFW3K6ORAom4JlUFOat65fy9Hd4F38W5jebVhsmgiCjsxBm9adb7W56+rDXbpwAZTGwR40DAG1aMVRoS1Ar2cHxwabARh/pHTnV4k2uCalX4+hbSlvput2u8zBmd7yg1YHvNDpeDToEjdCpxByLC9g9qSnjzVapCyo+60KN4852mL1EoVpmksh2Z3UwjXGDpvi3JhDZrl73sRtaqgWJCHPR6Pr9SahLOzvUQ5BSfth2Wd55wYXZIq9OjbkM8XLpWsRK/i0YZS9Yd6LoQPmAd8qhWa22m/DN2LkBZ7ClwmfmNUHrulxxsmlrA0C3GJGagalnV5Jse1v+TSGKCGE56Y8vvMEz6Lasv7VB2IE6MFZb4
X-Forefront-Antispam-Report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(376002)(346002)(136003)(396003)(1076003)(4326008)(6486002)(316002)(8676002)(8936002)(66476007)(186003)(16526019)(107886003)(66946007)(38100700002)(6916009)(26005)(5660300002)(52116002)(478600001)(956004)(2906002)(2616005)(7696005)(83380400001)(966005)(66556008)(6666004)(86362001)(38350700002)(36756003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
 +09GDY/E8Ie40iEgy2nBFJyItYkCJ8JZFmypKgUgFtRbqu3wSYZOBdhHmAtukk2rb5aAfPg2+zG38pWpXlqE75QAyCYMoj5GtRJlAXZ4SCUI6aOuQSR5xPrZtMPBnfP89QUlgCQijXuwnUFE72439u40KjDSHgzfwPzin4s2+c7lgjA1GFD3g9hF0v8rLDSsOHja8Uhz+oAcs26ue0bpxiAgw395HCNl0u4EmdeLgVA1OPNKntVVgDM2Q65zlxJ+9nhqdJXTG4W21bFDZ8CBtYAA/ZY2K5oF3wInul08CBry+iJQ0xHQWczuFrDLbMFzwg4zkSOQ/sXhyVbCUpjw8b9cVgYvAVWxuxj4nfg4BV1IEDQtKj60MISEgLqqd3vlxXvTIiFPVJdLNn7v5xa3gxWTBZrURQfE+m0uB1ALiwEaWVQRtGzRS+q1v18Xeb1EnZTUqBEWC2lw2qHhu687NcoT1rjdckmSwujmd/LJALeKSUUGdQpon4BG+tLnqukuXba8QjDI8j8sa4uAClmezM6NlstKn8disQhxwy1Eq4KhoyX47FupPsACO7Q+9iKyOYazGMdDmF64pjSq+vaEuJNHsHAoks6WcjIDSR9l78q13IKaQoZkjQVvsLdKeahz9CaFWQd+EaXaSgQ2IFv3hGH0zJjz4rRARd5wt9TnJOP/bu+RfZP+84FhJv5eCBa1IDE9q+m14ONQfJZQfZhoi1S+CRKbZtk9aV68NCj4QGpz8/ad/duuUqNMPvg6/Dui6O9vhwFGw41oiLBD03m6S+aY9y8dUdORmUZpHqpKr0Z+3vNqoSi1lEQ6tp9WT5u3kbrJoqvUBrsOHn6uXryY9UJX3cqT5PAy8gFUCFrVxsqtjsG+hZaeofoGlgPBq/HAi5nZ99JzixPfs1z/nHBb4H1aGkkdTUOUMEgCVJ3OUHmz0ZAUpRn2tnPz+krsZA4FdWfOp9CXBG4hgv7GSUen8bhE27crkSMlGHGOO0X2NHYr0aUcGEgSlg9ROL7EXc/9n5SHoXCry0T0ePoBNJNe30XQK4A4Rhc4VUy+rALM6IBhL+tw6Chd9Z5HX0yi28T+EDYr9d02RqoAEi5Rcp/S+4RQmcewFTSUYuiVnbiZ1PjcDK0K6MIdJKbeO/MGyVSl0gKv71vTStv26UEwtZVOK4PyasQdwnRCm5rtcVy+nTx6gQ68XhzBPspu10p4thqTigfJY9ppP1k8KhfpoJFQ8F65+Lk2ifW/M5bRLBOalCvlLS7A44LduOEp8rHEncK1kdxqzTCU7k1MBHTDkcodFud5gFbylPCN3TCyTHSvL5zwfZ0Ev1wVzaFStjlTDOCM
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 71d21e97-61ee-499c-f74d-08d92af83193
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2021 03:39:32.3295
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 
 tqGyfZ3a7g6Be1/E/sPUwKX1fZ4kjbnFZkAR8ZGnRzVHgZRbE13MA1weS1cW14z9Ft1LIHtezYE1mc92noigUu30SA0gC/0BuVlPxVOoawQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4422
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10009
 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0
 mlxscore=0 adultscore=0
 malwarescore=0 phishscore=0 mlxlogscore=962 suspectscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2106090001
X-Proofpoint-ORIG-GUID: kP07YDaCT3UKcEs2LavvRRfSv7Hr6rkb
X-Proofpoint-GUID: kP07YDaCT3UKcEs2LavvRRfSv7Hr6rkb
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10009
 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0
 phishscore=0
 spamscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0
 priorityscore=1501 adultscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2106090001
Precedence: bulk
List-ID: <linux-scsi.vger.kernel.org>
X-Mailing-List: linux-scsi@vger.kernel.org

Series

Subject: Protection information and block size cleanup | expand

Message

Martin K. Petersen June 9, 2021, 3:39 a.m. UTC

This series cleans up how low-level device drivers go about handling
protection information. The SCSI midlayer provides a set of flags and
helpers but not all drivers currently use them. This series updates
the drivers to use the proper calls to query things like the
protection interval, reference tag seed value, etc.

In addition scsi_debug is enhanced to validate and store protection
information the same way as a regular PI-capable disk drive or
SSD. With these changes scsi_debug is now able to pass the same PI
qualification tests as physical hardware.

And finally: Bart's recent series [1] attempted to clean up some of
the confusion between logical block addresses and block layer sector
addresses. Part of Bart's work is included in this series as well as
some fixes to the remainder of the scsi_get_lba() call sites.
Sometimes it is appropriate use sectors, in other cases logical blocks
are a better choice. For instance when printing something with a
reference tag given that the latter typically contains the lower 32
bits of the LBA.

The changes done in this series are also meant to facilitate removing
the request pointer from struct scsi_cmnd [2]. By removing several
references to struct request in the various drivers that transition
will now be easier.

[1] https://lore.kernel.org/linux-scsi/20210513223757.3938-1-bvanassche@acm.org/
[2] https://lore.kernel.org/linux-scsi/20210524030856.2824-1-bvanassche@acm.org/

--
Martin K. Petersen	Oracle Linux Engineering

Bart Van Assche (2):
  scsi: core: Introduce scsi_get_sector()
  scsi: iser: Use scsi_get_sector() instead of scsi_get_lba()

Martin K. Petersen (13):
  scsi: core: Add scsi_prot_ref_tag() helper
  scsi: lpfc: Use the proper SCSI midlayer interfaces for PI
  scsi: qla2xxx: Use the proper SCSI midlayer interfaces for PI
  scsi: mpt3sas: Use the proper SCSI midlayer interfaces for PI
  scsi: mpi3mr: Use the proper SCSI midlayer interfaces for PI
  scsi: zfcp: Use the proper SCSI midlayer interfaces for PI
  scsi: isci: Use the proper SCSI midlayer interfaces for PI
  scsi: scsi_debug: Remove dump_sector()
  scsi: scsi_debug: Improve RDPROTECT/WRPROTECT handling
  scsi: core: Make scsi_get_lba() return the LBA
  scsi: core: Add helper to return number of logical blocks in a request
  scsi: lpfc: Switch to scsi_get_block_count()
  scsi: ufs: core: Use scsi_get_lba() to get LBA

 drivers/infiniband/ulp/iser/iser_verbs.c |   2 +-
 drivers/s390/scsi/zfcp_fsf.c             |   4 +-
 drivers/scsi/isci/request.c              |   4 +-
 drivers/scsi/lpfc/lpfc_scsi.c            | 116 +++++++++--------------
 drivers/scsi/mpi3mr/mpi3mr_os.c          |  59 ++++--------
 drivers/scsi/mpt3sas/mpt3sas_scsih.c     |  28 ++----
 drivers/scsi/qla2xxx/qla_iocb.c          |  84 +++-------------
 drivers/scsi/scsi_debug.c                | 112 +++++++++++++---------
 drivers/scsi/ufs/ufshcd.c                |   3 +-
 include/scsi/scsi_cmnd.h                 |  25 ++++-
 10 files changed, 182 insertions(+), 255 deletions(-)

Comments

Bart Van Assche July 16, 2021, 9:27 p.m. UTC | #1

On 6/8/21 8:39 PM, Martin K. Petersen wrote:
> This series cleans up how low-level device drivers go about handling
> protection information. The SCSI midlayer provides a set of flags and
> helpers but not all drivers currently use them. This series updates
> the drivers to use the proper calls to query things like the
> protection interval, reference tag seed value, etc.

Hi Martin,

Do you plan to queue or repost this patch series?

Thanks,

Bart.

Martin K. Petersen July 19, 2021, 1:43 a.m. UTC | #2

Bart,

> Do you plan to queue or repost this patch series?

Yes. Still haven't pushed my 5.15 tree because I had several issues with
-rc1, including the configfs bug which broke most of my test setup. I am
rebasing to -rc2.

Bart Van Assche July 21, 2021, 3:53 a.m. UTC | #3

On 7/18/21 6:43 PM, Martin K. Petersen wrote:
> Yes. Still haven't pushed my 5.15 tree because I had several issues with
> -rc1, including the configfs bug which broke most of my test setup.
Hi Martin,

To test my configfs patch I used LIO scripts that I wrote many years
ago. It was only after I received a bug report that I realized that
these scripts only write configfs attributes but do not read any
configfs attribute. The configfs breakage shouldn't have happened but
this explains how read testing got overlooked.

Bart.

Martin K. Petersen July 24, 2021, 2:13 a.m. UTC | #4

On Tue, 8 Jun 2021 23:39:14 -0400, Martin K. Petersen wrote:

> This series cleans up how low-level device drivers go about handling
> protection information. The SCSI midlayer provides a set of flags and
> helpers but not all drivers currently use them. This series updates
> the drivers to use the proper calls to query things like the
> protection interval, reference tag seed value, etc.
> 
> In addition scsi_debug is enhanced to validate and store protection
> information the same way as a regular PI-capable disk drive or
> SSD. With these changes scsi_debug is now able to pass the same PI
> qualification tests as physical hardware.
> 
> [...]

Applied to 5.15/scsi-queue, thanks!

[01/15] scsi: core: Add scsi_prot_ref_tag() helper
        https://git.kernel.org/mkp/scsi/c/7ba46799d346
[03/15] scsi: qla2xxx: Use the proper SCSI midlayer interfaces for PI
        https://git.kernel.org/mkp/scsi/c/e2e9cd68fb3c
[06/15] scsi: zfcp: Use the proper SCSI midlayer interfaces for PI
        https://git.kernel.org/mkp/scsi/c/73e61d5c22bf
[08/15] scsi: scsi_debug: Remove dump_sector()
        https://git.kernel.org/mkp/scsi/c/c78be80d20cd
[09/15] scsi: scsi_debug: Improve RDPROTECT/WRPROTECT handling
        https://git.kernel.org/mkp/scsi/c/f7be677227a5
[10/15] scsi: core: Introduce scsi_get_sector()
        https://git.kernel.org/mkp/scsi/c/f0f214fe8cd3
[11/15] scsi: iser: Use scsi_get_sector() instead of scsi_get_lba()
        https://git.kernel.org/mkp/scsi/c/87662a472a9d
[12/15] scsi: core: Make scsi_get_lba() return the LBA
        https://git.kernel.org/mkp/scsi/c/d2c945f01d23
[15/15] scsi: ufs: core: Use scsi_get_lba() to get LBA
        https://git.kernel.org/mkp/scsi/c/54815088859f