| Message ID | 20210712060928.4161649-4-hch@lst.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/6] mmc: JZ4740: remove the flush_kernel_dcache_page call in jz4740_mmc_read_data | expand |
Hi Christoph, On 7/11/21 11:09 PM, Christoph Hellwig wrote: > +++ b/drivers/block/ps3disk.c > offset += size; > - flush_kernel_dcache_page(bvec.bv_page); > + flush_dcache_page(bvec.bv_page); > bvec_kunmap_irq(buf, &flags); I tested your series applied to v5.14-rc1 on the PS3 and it seems to be working OK. Tested-by: Geoff Levand <geoff@infradead.org>
diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c index f374ea2c67ce..32bfb0487bdb 100644 --- a/drivers/block/ps3disk.c +++ b/drivers/block/ps3disk.c @@ -100,7 +100,7 @@ static void ps3disk_scatter_gather(struct ps3_storage_device *dev, else memcpy(buf, dev->bounce_buf+offset, size); offset += size; - flush_kernel_dcache_page(bvec.bv_page); + flush_dcache_page(bvec.bv_page); bvec_kunmap_irq(buf, &flags); i++; }
Pages passed to block drivers can be mapped page cache pages, so we must use flush_dcache_page here instead of the more limited flush_kernel_dcache_page that is intended for highmem pages only. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/block/ps3disk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)