| Message ID | 20210623114025.v13.4.Id45138610b749ff775186ac10b3d01c504ddf4f3@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: misc: Add onboard_usb_hub driver | expand |
Will/Catalin, does this change looks good to you and could get an Acked-by? If so: would it be ok to land it through the USB tree with the rest of the series? It seems a conflict would be relatively unlikely. Thanks Matthias On Wed, Jun 23, 2021 at 11:41:20AM -0700, Matthias Kaehlcke wrote: > The dependency of USB_DWC3 on USB_XHCI_PLATFORM is being changed > from 'select' to 'depends on' by another patch. The defconfig selects > USB_DWC3 and implicitly USB_DWC3_DUAL_ROLE, to keep this unchanged > USB_XHCI_PLATFORM now needs to be selected explicitly. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > > Changes in v13: > - patch added to the series > > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 08c6f769df9a..d7f22b18e37a 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -795,6 +795,7 @@ CONFIG_USB_CONN_GPIO=m > CONFIG_USB=y > CONFIG_USB_OTG=y > CONFIG_USB_XHCI_HCD=y > +CONFIG_USB_XHCI_PLATFORM=y > CONFIG_USB_XHCI_TEGRA=y > CONFIG_USB_EHCI_HCD=y > CONFIG_USB_EHCI_EXYNOS=y > -- > 2.32.0.288.g62a8d224e6-goog >
Hi, On Mon, Jul 19, 2021 at 8:58 AM Matthias Kaehlcke <mka@chromium.org> wrote: > > Will/Catalin, > > does this change looks good to you and could get an Acked-by? > > If so: would it be ok to land it through the USB tree with the > rest of the series? It seems a conflict would be relatively > unlikely. Officially I don't think you really need an Ack for most changes to this file. So says Will [1]: > although there are a few things I really care about > in defconfig (e.g. things like page size!), generally speaking we don't > need to Ack everything that changes in there. In case it helps, you can stick my Reviewed-by on there... Reviewed-by: Douglas Anderson <dianders@chromium.org> [1] https://lore.kernel.org/r/20201208160029.GA6461@willie-the-truck
On Mon, Jul 19, 2021 at 11:07:23AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jul 19, 2021 at 8:58 AM Matthias Kaehlcke <mka@chromium.org> wrote: > > > > Will/Catalin, > > > > does this change looks good to you and could get an Acked-by? > > > > If so: would it be ok to land it through the USB tree with the > > rest of the series? It seems a conflict would be relatively > > unlikely. > > Officially I don't think you really need an Ack for most changes to > this file. So says Will [1]: > > > although there are a few things I really care about > > in defconfig (e.g. things like page size!), generally speaking we don't > > need to Ack everything that changes in there. Good to know, thanks! > In case it helps, you can stick my Reviewed-by on there... > > Reviewed-by: Douglas Anderson <dianders@chromium.org> Thanks I figured the next step is actually a rebase due to a conflict in v5.14-rc1, commit 8ae030c34dce ("arm64: defconfig: Enable renesas usb xhci pci host controller") made changes in the same area of the config.
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 08c6f769df9a..d7f22b18e37a 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -795,6 +795,7 @@ CONFIG_USB_CONN_GPIO=m CONFIG_USB=y CONFIG_USB_OTG=y CONFIG_USB_XHCI_HCD=y +CONFIG_USB_XHCI_PLATFORM=y CONFIG_USB_XHCI_TEGRA=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_EXYNOS=y
The dependency of USB_DWC3 on USB_XHCI_PLATFORM is being changed from 'select' to 'depends on' by another patch. The defconfig selects USB_DWC3 and implicitly USB_DWC3_DUAL_ROLE, to keep this unchanged USB_XHCI_PLATFORM now needs to be selected explicitly. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- Changes in v13: - patch added to the series arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)