| Message ID | 20210719182359.5262-1-ericwouds@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7e777021780e9c373fc0c04d40b8407ce8c3b5d5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 13 of 13 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 9 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On 7/19/21 11:23 AM, ericwouds@gmail.com wrote: > From: Eric Woudstra <ericwouds@gmail.com> > > Fixes my earlier patch which broke vlan unaware bridges. > > The IVL bit now only gets set for vid's larger than 1. > > Fixes: 11d8d98cbeef ("mt7530 fix mt7530_fdb_write vid missing ivl bit") > Signed-off-by: Eric Woudstra <ericwouds@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 19 Jul 2021 20:23:57 +0200 you wrote: > From: Eric Woudstra <ericwouds@gmail.com> > > Fixes my earlier patch which broke vlan unaware bridges. > > The IVL bit now only gets set for vid's larger than 1. > > Fixes: 11d8d98cbeef ("mt7530 fix mt7530_fdb_write vid missing ivl bit") > Signed-off-by: Eric Woudstra <ericwouds@gmail.com> > > [...] Here is the summary with links: - [net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1 https://git.kernel.org/netdev/net/c/7e777021780e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 9e4df35f9..69f21b716 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -366,7 +366,8 @@ mt7530_fdb_write(struct mt7530_priv *priv, u16 vid, int i; reg[1] |= vid & CVID_MASK; - reg[1] |= ATA2_IVL; + if (vid > 1) + reg[1] |= ATA2_IVL; reg[2] |= (aging & AGE_TIMER_MASK) << AGE_TIMER; reg[2] |= (port_mask & PORT_MAP_MASK) << PORT_MAP; /* STATIC_ENT indicate that entry is static wouldn't