diff mbox series

[1/2] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

Message ID 1626430843-23823-2-git-send-email-dillon.minfei@gmail.com (mailing list archive)
State New, archived
Headers show
Series Add ilitek ili9341 panel driver | expand

Commit Message

Dillon Min July 16, 2021, 10:20 a.m. UTC 
From: Dillon Min <dillon.minfei@gmail.com>

Add documentation for "ilitek,ili9341" panel.

Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
---
 .../bindings/display/panel/ilitek,ili9341.yaml     | 69 ++++++++++++++++++++++
 1 file changed, 69 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml

Comments

Linus Walleij July 18, 2021, 12:16 a.m. UTC | #1 
Hi Dillon,

thanks for your patch!

On Fri, Jul 16, 2021 at 12:20 PM <dillon.minfei@gmail.com> wrote:

> From: Dillon Min <dillon.minfei@gmail.com>
>
> Add documentation for "ilitek,ili9341" panel.
>
> Signed-off-by: Dillon Min <dillon.minfei@gmail.com>

> +  dc-gpios:
> +    maxItems: 1
> +    description: Display data/command selection (D/CX)

This is a DBI feature so mention in the description that this is a
DBI panel.

> +  spi-3wire: true
> +
> +  spi-max-frequency:
> +    const: 10000000
> +
> +  port: true
> +
> +additionalProperties: false

Please add regulator supplies for the power lines, it's fine
not to implement code handling them in the driver but they
should be in the bindings.

For the ili9341 it should be

  vci-supply:
    description: Analog voltage supply (2.5 .. 3.3V)

  vddi-supply:
    description: Voltage supply for interface logic (1.65 .. 3.3 V)

  vddi-led-supply:
    description: Voltage supply for the LED driver (1.65 .. 3.3 V)

Yours,
Linus Walleij
kernel test robot July 20, 2021, 5:32 a.m. UTC | #2 
Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v5.14-rc2 next-20210719]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/dillon-minfei-gmail-com/Add-ilitek-ili9341-panel-driver/20210718-103113
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0
reproduce: make ARCH=arm dtbs_check

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


dtcheck warnings: (new ones prefixed by >>)
   arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /interrupt-controller@e000e100: failed to match any schema with compatible: ['arm,armv7m-nvic']
   arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /timer@e000e010: failed to match any schema with compatible: ['arm,armv7m-systick']
   arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /soc/i2c@40005c00/stmpe811@41: failed to match any schema with compatible: ['st,stmpe811']
   arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /soc/i2c@40005c00/stmpe811@41/stmpe_touchscreen: failed to match any schema with compatible: ['st,stmpe-ts']
   arch/arm/boot/dts/stm32f429-disco.dt.yaml: l3gd20@0: 'spi-max-frequency' does not match any of the regexes: 'pinctrl-[0-9]+'
   	From schema: Documentation/devicetree/bindings/iio/st,st-sensors.yaml
>> arch/arm/boot/dts/stm32f429-disco.dt.yaml: display@1: compatible: ['st,sf-tc240t-9370-t'] is too short
   	From schema: Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
   arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /soc/crc@40023000: failed to match any schema with compatible: ['st,stm32f4-crc']
   arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /soc/rcc@40023800: failed to match any schema with compatible: ['st,stm32f42xx-rcc', 'st,stm32-rcc']
   arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /soc/rcc@40023800: failed to match any schema with compatible: ['st,stm32f42xx-rcc', 'st,stm32-rcc']

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Dillon Min July 21, 2021, 7:29 a.m. UTC | #3 
Hi Linus,

Thanks for your detailed reply.

On Sun, 18 Jul 2021 at 08:17, Linus Walleij <linus.walleij@linaro.org>
wrote:

> Hi Dillon,
>
> thanks for your patch!
>
> On Fri, Jul 16, 2021 at 12:20 PM <dillon.minfei@gmail.com> wrote:
>
> > From: Dillon Min <dillon.minfei@gmail.com>
> >
> > Add documentation for "ilitek,ili9341" panel.
> >
> > Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
>
> > +  dc-gpios:
> > +    maxItems: 1
> > +    description: Display data/command selection (D/CX)
>
> This is a DBI feature so mention in the description that this is a
> DBI panel.
>

Okay, I will add the DBI panel to v2.


>
> > +  spi-3wire: true
> > +
> > +  spi-max-frequency:
> > +    const: 10000000
> > +
> > +  port: true
> > +
> > +additionalProperties: false
>
> Please add regulator supplies for the power lines, it's fine
> not to implement code handling them in the driver but they
> should be in the bindings.
>
> For the ili9341 it should be
>
>   vci-supply:
>     description: Analog voltage supply (2.5 .. 3.3V)
>
>   vddi-supply:
>     description: Voltage supply for interface logic (1.65 .. 3.3 V)
>
>   vddi-led-supply:
>     description: Voltage supply for the LED driver (1.65 .. 3.3 V)
>
>
Thanks so much, I will add it to v2.


> Yours,
> Linus Walleij
>
Dillon Min July 21, 2021, 7:39 a.m. UTC | #4 
Hi Kernel test robot,

Thanks for your time to test my patch.

I did the dtbs_check on my side, and got the same warnings.

But I guess these warnings do not come from this submission,
So, I will not be going to fix it at this time, but will at other
submissions
to fix these, add arm,armv7m-nvic.yaml ... to describe compatibles, etc.

by the way, i did find a warning from the stm32f429-disco.dts and fixt it
in "[PATCH v2 2/3] ARM: dts: stm32: fix dtbs_check warning on ili9341
dts binding",

the warning:
arch/arm/boot/dts/stm32f429-disco.dt.yaml: display@1: compatible:
['st,sf-tc240t-9370-t'] is too short

my make command:
make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml

Best regards
thanks

Dillon

On Tue, 20 Jul 2021 at 14:12, kernel test robot <lkp@intel.com> wrote:

> Hi,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on robh/for-next]
> [also build test WARNING on linus/master v5.14-rc2 next-20210719]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:
> https://github.com/0day-ci/linux/commits/dillon-minfei-gmail-com/Add-ilitek-ili9341-panel-driver/20210718-103113
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> for-next
> compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0
> reproduce: make ARCH=arm dtbs_check
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> dtcheck warnings: (new ones prefixed by >>)
>    arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0:
> /interrupt-controller@e000e100: failed to match any schema with
> compatible: ['arm,armv7m-nvic']
>    arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /timer@e000e010: failed
> to match any schema with compatible: ['arm,armv7m-systick']
>    arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /soc/i2c@40005c00
> /stmpe811@41: failed to match any schema with compatible: ['st,stmpe811']
>    arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /soc/i2c@40005c00
> /stmpe811@41/stmpe_touchscreen: failed to match any schema with
> compatible: ['st,stmpe-ts']
>    arch/arm/boot/dts/stm32f429-disco.dt.yaml: l3gd20@0:
> 'spi-max-frequency' does not match any of the regexes: 'pinctrl-[0-9]+'
>         From schema:
> Documentation/devicetree/bindings/iio/st,st-sensors.yaml
> >> arch/arm/boot/dts/stm32f429-disco.dt.yaml: display@1: compatible:
> ['st,sf-tc240t-9370-t'] is too short
>         From schema:
> Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
>    arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /soc/crc@40023000:
> failed to match any schema with compatible: ['st,stm32f4-crc']
>    arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /soc/rcc@40023800:
> failed to match any schema with compatible: ['st,stm32f42xx-rcc',
> 'st,stm32-rcc']
>    arch/arm/boot/dts/stm32f429-disco.dt.yaml:0:0: /soc/rcc@40023800:
> failed to match any schema with compatible: ['st,stm32f42xx-rcc',
> 'st,stm32-rcc']
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
new file mode 100644
index 000000000000..2172f889af3c
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
@@ -0,0 +1,69 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/ilitek,ili9341.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Ilitek-9341 Display Panel
+
+maintainers:
+  - Dillon Min <dillon.minfei@gmail.com>
+
+description: |
+  Ilitek ILI9341 TFT panel driver with SPI control bus
+  This is a driver for 320x240 TFT panels, accepting a rgb input
+  streams with 16 bits or 18 bits.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    items:
+      - enum:
+          # ili9341 240*320 Color on stm32f429-disco board
+        - st,sf-tc240t-9370-t
+      - const: ilitek,ili9341
+
+  reg: true
+
+  dc-gpios:
+    maxItems: 1
+    description: Display data/command selection (D/CX)
+
+  spi-3wire: true
+
+  spi-max-frequency:
+    const: 10000000
+
+  port: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - dc-gpios
+  - port
+
+examples:
+  - |+
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        panel: display@0 {
+                 compatible = "st,sf-tc240t-9370-t",
+                              "ilitek,ili9341";
+                 reg = <0>;
+                 spi-3wire;
+                 spi-max-frequency = <10000000>;
+                 dc-gpios = <&gpiod 13 0>;
+                 port {
+                         panel_in: endpoint {
+                           remote-endpoint = <&display_out>;
+                      };
+                 };
+             };
+        };
+...
+