| Message ID | 20210720124813.59331-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | atm: idt77252: clean up trigraph warning on ??) string | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 27 this patch: 27 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: printk() should include KERN_<LEVEL> facility level |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 27 this patch: 27 |
| netdev/header_inline | success | Link |
On 7/20/2021 5:48 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The character sequence ??) is a trigraph and causes the following > clang warning: > > drivers/atm/idt77252.c:3544:35: warning: trigraph ignored [-Wtrigraphs] > > Clean this by replacing it with single ?. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> This looks good to me but I am curious how you say this warning in the first place since the main Makefile disables this unconditionally. Did you just pass -Wtrigraphs via KCFLAGS or something similar? Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/atm/idt77252.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c > index 9e4bd751db79..81ce81a75fc6 100644 > --- a/drivers/atm/idt77252.c > +++ b/drivers/atm/idt77252.c > @@ -3536,7 +3536,7 @@ static int idt77252_preset(struct idt77252_dev *card) > return -1; > } > if (!(pci_command & PCI_COMMAND_IO)) { > - printk("%s: PCI_COMMAND: %04x (???)\n", > + printk("%s: PCI_COMMAND: %04x (?)\n", > card->name, pci_command); > deinit_card(card); > return (-1); >
On 20/07/2021 18:17, Nathan Chancellor wrote: > On 7/20/2021 5:48 AM, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> The character sequence ??) is a trigraph and causes the following >> clang warning: >> >> drivers/atm/idt77252.c:3544:35: warning: trigraph ignored [-Wtrigraphs] >> >> Clean this by replacing it with single ?. >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> > > This looks good to me but I am curious how you say this warning in the > first place since the main Makefile disables this unconditionally. Did > you just pass -Wtrigraphs via KCFLAGS or something similar? I used W=1 > > Reviewed-by: Nathan Chancellor <nathan@kernel.org> > >> --- >> drivers/atm/idt77252.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c >> index 9e4bd751db79..81ce81a75fc6 100644 >> --- a/drivers/atm/idt77252.c >> +++ b/drivers/atm/idt77252.c >> @@ -3536,7 +3536,7 @@ static int idt77252_preset(struct idt77252_dev >> *card) >> return -1; >> } >> if (!(pci_command & PCI_COMMAND_IO)) { >> - printk("%s: PCI_COMMAND: %04x (???)\n", >> + printk("%s: PCI_COMMAND: %04x (?)\n", >> card->name, pci_command); >> deinit_card(card); >> return (-1); >>
diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index 9e4bd751db79..81ce81a75fc6 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@ -3536,7 +3536,7 @@ static int idt77252_preset(struct idt77252_dev *card) return -1; } if (!(pci_command & PCI_COMMAND_IO)) { - printk("%s: PCI_COMMAND: %04x (???)\n", + printk("%s: PCI_COMMAND: %04x (?)\n", card->name, pci_command); deinit_card(card); return (-1);