diff mbox series

[1/6] python: disable pylint errors for aqmp-tui

Message ID 20210702212603.26465-2-niteesh.gs@gmail.com (mailing list archive)
State New, archived
Headers show
Series python: AQMP-TUI Prototype | expand

Commit Message

Niteesh G. S. July 2, 2021, 9:25 p.m. UTC
Disable missing-docstring and fixme pylint warnings.
This is because since the AQMP is just a prototype
it is currently not documented properly and lot
of todo and fixme's are still in place.

Signed-off-by: G S Niteesh Babu <niteesh.gs@gmail.com>
---
 python/setup.cfg | 2 ++
 1 file changed, 2 insertions(+)

Comments

John Snow July 20, 2021, 6 p.m. UTC | #1
On Fri, Jul 2, 2021 at 5:26 PM G S Niteesh Babu <niteesh.gs@gmail.com>
wrote:

> Disable missing-docstring and fixme pylint warnings.
> This is because since the AQMP is just a prototype
> it is currently not documented properly and lot
> of todo and fixme's are still in place.
>
> Signed-off-by: G S Niteesh Babu <niteesh.gs@gmail.com>
> ---
>  python/setup.cfg | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/python/setup.cfg b/python/setup.cfg
> index bce8807702..1a552d672a 100644
> --- a/python/setup.cfg
> +++ b/python/setup.cfg
> @@ -89,6 +89,8 @@ ignore_missing_imports = True
>  # no Warning level messages displayed, use "--disable=all --enable=classes
>  # --disable=W".
>  disable=too-many-function-args,  # mypy handles this with less false
> positives.
> +        missing-docstring, # FIXME
> +        fixme, # FIXME
>

You aren't actually using any FIXME statements in this branch right now
that I can see, so you don't need that suppression. It could be removed in
V3.


>
>  [pylint.basic]
>  # Good variable names which should always be accepted, separated by a
> comma.
> --
> 2.17.1
>
>
John Snow July 20, 2021, 6:30 p.m. UTC | #2
On Tue, Jul 20, 2021 at 2:00 PM John Snow <jsnow@redhat.com> wrote:

>
>
> On Fri, Jul 2, 2021 at 5:26 PM G S Niteesh Babu <niteesh.gs@gmail.com>
> wrote:
>
>> Disable missing-docstring and fixme pylint warnings.
>> This is because since the AQMP is just a prototype
>> it is currently not documented properly and lot
>> of todo and fixme's are still in place.
>>
>> Signed-off-by: G S Niteesh Babu <niteesh.gs@gmail.com>
>> ---
>>  python/setup.cfg | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/python/setup.cfg b/python/setup.cfg
>> index bce8807702..1a552d672a 100644
>> --- a/python/setup.cfg
>> +++ b/python/setup.cfg
>> @@ -89,6 +89,8 @@ ignore_missing_imports = True
>>  # no Warning level messages displayed, use "--disable=all
>> --enable=classes
>>  # --disable=W".
>>  disable=too-many-function-args,  # mypy handles this with less false
>> positives.
>> +        missing-docstring, # FIXME
>> +        fixme, # FIXME
>>
>
> You aren't actually using any FIXME statements in this branch right now
> that I can see, so you don't need that suppression. It could be removed in
> V3.
>
>

Sorry, I was mistaken, this will trigger on the TODO entries that you *are*
using.

--js
diff mbox series

Patch

diff --git a/python/setup.cfg b/python/setup.cfg
index bce8807702..1a552d672a 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -89,6 +89,8 @@  ignore_missing_imports = True
 # no Warning level messages displayed, use "--disable=all --enable=classes
 # --disable=W".
 disable=too-many-function-args,  # mypy handles this with less false positives.
+        missing-docstring, # FIXME
+        fixme, # FIXME
 
 [pylint.basic]
 # Good variable names which should always be accepted, separated by a comma.