| Message ID | 20210720173557.999534-2-vladimir.oltean@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 94111dfc18b8b8cb3c72006e0e7b31c038709ab4 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Fixes for the switchdev FDB fan-out helpers | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: jiri@resnulli.us ivecera@redhat.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | fail | Errors and warnings before: 40 this patch: 40 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | WARNING: line length of 86 exceeds 80 columns |
| netdev/build_allmodconfig_warn | fail | Errors and warnings before: 52 this patch: 52 |
| netdev/header_inline | success | Link |
Hi Vladimir, On 20/07/2021 19:35, Vladimir Oltean wrote: > With the semicolon at the end, the compiler sees the shim function as a > declaration and not as a definition, and warns: > > 'switchdev_handle_fdb_del_to_device' declared 'static' but never defined Thank you for the patch! My CI also reported the same issue and I confirm it removes the warning. Tested-by: Matthieu Baerts <matthieu.baerts@tessares.net> Cheers, Matt
diff --git a/include/net/switchdev.h b/include/net/switchdev.h index 6f57eb2e89cc..66468ff8cc0a 100644 --- a/include/net/switchdev.h +++ b/include/net/switchdev.h @@ -406,7 +406,7 @@ switchdev_handle_fdb_del_to_device(struct net_device *dev, const struct switchdev_notifier_fdb_info *fdb_info), int (*lag_del_cb)(struct net_device *dev, const struct net_device *orig_dev, const void *ctx, - const struct switchdev_notifier_fdb_info *fdb_info)); + const struct switchdev_notifier_fdb_info *fdb_info)) { return 0; }
With the semicolon at the end, the compiler sees the shim function as a declaration and not as a definition, and warns: 'switchdev_handle_fdb_del_to_device' declared 'static' but never defined Reported-by: kernel test robot <lkp@intel.com> Fixes: 8ca07176ab00 ("net: switchdev: introduce a fanout helper for SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE") Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- include/net/switchdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)