| Message ID | 20210709162922.udxjidc3kgxkgzx3@fiona (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: mark compressed range uptodate only if all bio succeed | expand |
On Fri, Jul 09, 2021 at 11:29:22AM -0500, Goldwyn Rodrigues wrote: > In compression write endio sequence, the range which the compressed_bio > writes is marked as uptodate if the last bio of the compressed (sub)bios > is completed successfully. There could be previous bio which may > have failed which is recorded in cb->errors. > > Set the writeback range as uptodate only if cb->errors is zero, as opposed > to checking only the last bio's status. > > Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com> > --- > fs/btrfs/compression.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c > index 9a023ae0f98b..30d82cdf128c 100644 > --- a/fs/btrfs/compression.c > +++ b/fs/btrfs/compression.c > @@ -352,7 +352,7 @@ static void end_compressed_bio_write(struct bio *bio) > btrfs_record_physical_zoned(inode, cb->start, bio); > btrfs_writepage_endio_finish_ordered(BTRFS_I(inode), NULL, > cb->start, cb->start + cb->len - 1, > - bio->bi_status == BLK_STS_OK); > + !cb->errors); Right, that would only test the last bio. Have been able to reproduce it? Anyway, added to misc-next, thanks.
On 16:34 22/07, David Sterba wrote: > On Fri, Jul 09, 2021 at 11:29:22AM -0500, Goldwyn Rodrigues wrote: > > In compression write endio sequence, the range which the compressed_bio > > writes is marked as uptodate if the last bio of the compressed (sub)bios > > is completed successfully. There could be previous bio which may > > have failed which is recorded in cb->errors. > > > > Set the writeback range as uptodate only if cb->errors is zero, as opposed > > to checking only the last bio's status. > > > > Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com> > > --- > > fs/btrfs/compression.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c > > index 9a023ae0f98b..30d82cdf128c 100644 > > --- a/fs/btrfs/compression.c > > +++ b/fs/btrfs/compression.c > > @@ -352,7 +352,7 @@ static void end_compressed_bio_write(struct bio *bio) > > btrfs_record_physical_zoned(inode, cb->start, bio); > > btrfs_writepage_endio_finish_ordered(BTRFS_I(inode), NULL, > > cb->start, cb->start + cb->len - 1, > > - bio->bi_status == BLK_STS_OK); > > + !cb->errors); > > Right, that would only test the last bio. Have been able to reproduce > it? > No, I don't have a reproducer. Just observed it while reading the code. > Anyway, added to misc-next, thanks. Thanks.
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index 9a023ae0f98b..30d82cdf128c 100644 --- a/fs/btrfs/compression.c +++ b/fs/btrfs/compression.c @@ -352,7 +352,7 @@ static void end_compressed_bio_write(struct bio *bio) btrfs_record_physical_zoned(inode, cb->start, bio); btrfs_writepage_endio_finish_ordered(BTRFS_I(inode), NULL, cb->start, cb->start + cb->len - 1, - bio->bi_status == BLK_STS_OK); + !cb->errors); end_compressed_writeback(inode, cb); /* note, our inode could be gone now */
In compression write endio sequence, the range which the compressed_bio writes is marked as uptodate if the last bio of the compressed (sub)bios is completed successfully. There could be previous bio which may have failed which is recorded in cb->errors. Set the writeback range as uptodate only if cb->errors is zero, as opposed to checking only the last bio's status. Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com> --- fs/btrfs/compression.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)