| Message ID | 20210721214830.25690-1-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panfrost: devfreq: Don't display error for EPROBE_DEFER | expand |
On 21/07/2021 22:48, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Set a condition for the message of "Couldn't set OPP regulators" to not > display if the error code is EPROBE_DEFER. Note that I used an if > statement to capture the condition instead of the dev_err_probe > function because I didn't want to change the DRM_DEV_ERROR usage. Note that this file (panfost_devfreq.c) is actually the odd one out in terms of using the DRM_DEV_xxx macros. The rest of the panfrost driver uses the standard dev_xxx ones. So tidying this up to match the rest of the driver would also allow us to use dev_err_probe(). But as a point fix this patch is fine and correct. Thanks! > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> Reviewed-by: Steven Price <steven.price@arm.com> I'll apply this to drm-misc-next. Thanks, Steve > --- > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c > index 3644652f726f..194af7f607a6 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c > +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c > @@ -106,7 +106,8 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) > if (ret) { > /* Continue if the optional regulator is missing */ > if (ret != -ENODEV) { > - DRM_DEV_ERROR(dev, "Couldn't set OPP regulators\n"); > + if (ret != -EPROBE_DEFER) > + DRM_DEV_ERROR(dev, "Couldn't set OPP regulators\n"); > return ret; > } > } >
diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c index 3644652f726f..194af7f607a6 100644 --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c @@ -106,7 +106,8 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) if (ret) { /* Continue if the optional regulator is missing */ if (ret != -ENODEV) { - DRM_DEV_ERROR(dev, "Couldn't set OPP regulators\n"); + if (ret != -EPROBE_DEFER) + DRM_DEV_ERROR(dev, "Couldn't set OPP regulators\n"); return ret; } }