| Message ID | 20210721140424.725744-9-maxime@cerno.tech (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | None | expand |
On Wed, 21 Jul 2021 16:03:38 +0200, Maxime Ripard wrote: > additionalProperties prevent any property not explicitly defined in the > binding to be used. Yet, some serial properties like max-speed are valid > and validated through the serial/serial.yaml binding. > > Even though the ideal solution would be to use unevaluatedProperties > instead, it's not pratical due to the way the bus bindings have been > described. Let's add max-speed to remove the warning. > > Cc: Alistair Francis <alistair@alistair23.me> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: netdev@vger.kernel.org > Cc: Vasily Khoruzhick <anarsoul@gmail.com> > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- > Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, Jul 22, 2021, at 12:03 AM, Maxime Ripard wrote: > additionalProperties prevent any property not explicitly defined in the > binding to be used. Yet, some serial properties like max-speed are valid > and validated through the serial/serial.yaml binding. > > Even though the ideal solution would be to use unevaluatedProperties > instead, it's not pratical due to the way the bus bindings have been > described. Let's add max-speed to remove the warning. > > Cc: Alistair Francis <alistair@alistair23.me> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: netdev@vger.kernel.org > Cc: Vasily Khoruzhick <anarsoul@gmail.com> > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Reviewed-by: Alistair Francis <alistair@alistair23.me> Alistair > --- > Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > index 4f485df69ac3..deae94ef54b8 100644 > --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > @@ -34,6 +34,8 @@ properties: > maxItems: 1 > description: GPIO specifier, used to wakeup the host processor > > + max-speed: true > + > required: > - compatible > > -- > 2.31.1 > >
diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml index 4f485df69ac3..deae94ef54b8 100644 --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml @@ -34,6 +34,8 @@ properties: maxItems: 1 description: GPIO specifier, used to wakeup the host processor + max-speed: true + required: - compatible
additionalProperties prevent any property not explicitly defined in the binding to be used. Yet, some serial properties like max-speed are valid and validated through the serial/serial.yaml binding. Even though the ideal solution would be to use unevaluatedProperties instead, it's not pratical due to the way the bus bindings have been described. Let's add max-speed to remove the warning. Cc: Alistair Francis <alistair@alistair23.me> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: netdev@vger.kernel.org Cc: Vasily Khoruzhick <anarsoul@gmail.com> Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 ++ 1 file changed, 2 insertions(+)