| Message ID | 20210724192131.GA490422@pc (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | bluetooth: bfusb: update the reference count of udev | expand |
On Sat, Jul 24, 2021 at 08:21:31PM +0100, Salah Triki wrote: > Use usb_get_dev() and usb_put_dev() in order to update the reference > count of udev. What does this fix?
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=520705 ---Test result--- Test Summary: CheckPatch PASS 0.50 seconds GitLint PASS 0.11 seconds BuildKernel PASS 635.97 seconds TestRunner: Setup PASS 415.86 seconds TestRunner: l2cap-tester PASS 2.99 seconds TestRunner: bnep-tester PASS 2.19 seconds TestRunner: mgmt-tester PASS 32.58 seconds TestRunner: rfcomm-tester PASS 2.43 seconds TestRunner: sco-tester PASS 2.35 seconds TestRunner: smp-tester FAIL 2.31 seconds TestRunner: userchan-tester PASS 2.15 seconds Details ############################## Test: CheckPatch - PASS - 0.50 seconds Run checkpatch.pl script with rule in .checkpatch.conf ############################## Test: GitLint - PASS - 0.11 seconds Run gitlint with rule in .gitlint ############################## Test: BuildKernel - PASS - 635.97 seconds Build Kernel with minimal configuration supports Bluetooth ############################## Test: TestRunner: Setup - PASS - 415.86 seconds Setup environment for running Test Runner ############################## Test: TestRunner: l2cap-tester - PASS - 2.99 seconds Run test-runner with l2cap-tester Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: bnep-tester - PASS - 2.19 seconds Run test-runner with bnep-tester Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: mgmt-tester - PASS - 32.58 seconds Run test-runner with mgmt-tester Total: 448, Passed: 445 (99.3%), Failed: 0, Not Run: 3 ############################## Test: TestRunner: rfcomm-tester - PASS - 2.43 seconds Run test-runner with rfcomm-tester Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: sco-tester - PASS - 2.35 seconds Run test-runner with sco-tester Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: smp-tester - FAIL - 2.31 seconds Run test-runner with smp-tester Total: 8, Passed: 7 (87.5%), Failed: 1, Not Run: 0 Failed Test Cases SMP Client - SC Request 2 Failed 0.025 seconds ############################## Test: TestRunner: userchan-tester - PASS - 2.15 seconds Run test-runner with userchan-tester Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0 --- Regards, Linux Bluetooth
diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c index 5a321b4076aa..c9145c914451 100644 --- a/drivers/bluetooth/bfusb.c +++ b/drivers/bluetooth/bfusb.c @@ -623,7 +623,7 @@ static int bfusb_probe(struct usb_interface *intf, const struct usb_device_id *i if (!data) return -ENOMEM; - data->udev = udev; + data->udev = usb_get_dev(udev); data->bulk_in_ep = bulk_in_ep->desc.bEndpointAddress; data->bulk_out_ep = bulk_out_ep->desc.bEndpointAddress; data->bulk_pkt_size = le16_to_cpu(bulk_out_ep->desc.wMaxPacketSize); @@ -699,6 +699,8 @@ static void bfusb_disconnect(struct usb_interface *intf) usb_set_intfdata(intf, NULL); + usb_put_dev(interface_to_usbdev(intf)); + bfusb_close(hdev); hci_unregister_dev(hdev);
Use usb_get_dev() and usb_put_dev() in order to update the reference count of udev. Signed-off-by: Salah Triki <salah.triki@gmail.com> --- drivers/bluetooth/bfusb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)