[vfs,0/2] Fix gfs2 setattr bug

Message

Bob Peterson July 28, 2021, 12:47 p.m. UTC

Hi Al,

Here is a set of two patches from Andreas Gruenbacher to fix a problem
that causes xfstests generic/079 to fail on gfs2. The first patch moves a
chunk of code from notify_change to its own function, may_setattr, so gfs2
can use it. The second patch makes gfs2 use it.

Bob Peterson

Andreas Gruenbacher (2):
  fs: Move notify_change permission checks into may_setattr
  gfs2: Switch to may_setattr in gfs2_setattr

 fs/attr.c          | 50 ++++++++++++++++++++++++++++------------------
 fs/gfs2/inode.c    |  4 ++--
 include/linux/fs.h |  2 ++
 3 files changed, 35 insertions(+), 21 deletions(-)

Comments

Christian Brauner July 28, 2021, 1:14 p.m. UTC | #1

On Wed, Jul 28, 2021 at 07:47:32AM -0500, Bob Peterson wrote:
> Hi Al,
> 
> Here is a set of two patches from Andreas Gruenbacher to fix a problem
> that causes xfstests generic/079 to fail on gfs2. The first patch moves a
> chunk of code from notify_change to its own function, may_setattr, so gfs2
> can use it. The second patch makes gfs2 use it.

lgtm,
Acked-by: Christian Brauner <[e-mail]>