| Message ID | 20210714193542.21857-11-joao.m.martins@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm, sparse-vmemmap: Introduce compound pagemaps | expand |
On Wed, Jul 14, 2021 at 12:36 PM Joao Martins <joao.m.martins@oracle.com> wrote: > > Rather than calculating @pgoff manually, switch to ALIGN() instead. Looks good, Reviewed-by: Dan Williams <dan.j.williams@intel.com> > > Suggested-by: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Joao Martins <joao.m.martins@oracle.com> > --- > drivers/dax/device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dax/device.c b/drivers/dax/device.c > index dd8222a42808..0b82159b3564 100644 > --- a/drivers/dax/device.c > +++ b/drivers/dax/device.c > @@ -234,8 +234,8 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, > * mapped. No need to consider the zero page, or racing > * conflicting mappings. > */ > - pgoff = linear_page_index(vmf->vma, vmf->address > - & ~(fault_size - 1)); > + pgoff = linear_page_index(vmf->vma, > + ALIGN(vmf->address, fault_size)); > for (i = 0; i < fault_size / PAGE_SIZE; i++) { > struct page *page; > > -- > 2.17.1 >
On 7/28/21 8:29 AM, Dan Williams wrote: > On Wed, Jul 14, 2021 at 12:36 PM Joao Martins <joao.m.martins@oracle.com> wrote: >> >> Rather than calculating @pgoff manually, switch to ALIGN() instead. > > Looks good, > > Reviewed-by: Dan Williams <dan.j.williams@intel.com> > Thanks! >> >> Suggested-by: Dan Williams <dan.j.williams@intel.com> >> Signed-off-by: Joao Martins <joao.m.martins@oracle.com> >> --- >> drivers/dax/device.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/dax/device.c b/drivers/dax/device.c >> index dd8222a42808..0b82159b3564 100644 >> --- a/drivers/dax/device.c >> +++ b/drivers/dax/device.c >> @@ -234,8 +234,8 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, >> * mapped. No need to consider the zero page, or racing >> * conflicting mappings. >> */ >> - pgoff = linear_page_index(vmf->vma, vmf->address >> - & ~(fault_size - 1)); >> + pgoff = linear_page_index(vmf->vma, >> + ALIGN(vmf->address, fault_size)); >> for (i = 0; i < fault_size / PAGE_SIZE; i++) { >> struct page *page; >> >> -- >> 2.17.1 >>
diff --git a/drivers/dax/device.c b/drivers/dax/device.c index dd8222a42808..0b82159b3564 100644 --- a/drivers/dax/device.c +++ b/drivers/dax/device.c @@ -234,8 +234,8 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, * mapped. No need to consider the zero page, or racing * conflicting mappings. */ - pgoff = linear_page_index(vmf->vma, vmf->address - & ~(fault_size - 1)); + pgoff = linear_page_index(vmf->vma, + ALIGN(vmf->address, fault_size)); for (i = 0; i < fault_size / PAGE_SIZE; i++) { struct page *page;
Rather than calculating @pgoff manually, switch to ALIGN() instead. Suggested-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Joao Martins <joao.m.martins@oracle.com> --- drivers/dax/device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)