| Message ID | cover.1627391588.git.geliangtang@xiaomi.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | fullmesh path manager support | expand |
On Tue, 2021-07-27 at 21:24 +0800, Geliang Tang wrote: > From: Geliang Tang <geliangtang@xiaomi.com> > > v6: > - drop lookup_subflow_by_addrs() > - pass three arrays instead of 'entries' in fill_local_adresses_vec() > - drop the 'remote' argument of fill_local_addresses_vec > - drop the 'local' argument of fill_remote_addresses_vec > - fix the pm.subflows. > - add limit testcase. > > v5: > - patch 1, add a new helper lookup_address_in_vec. > - patch 2, update pm.subflows in the non-fullmesh case. > - patch 4, add more tests. > - tag: export/20210727T054640 > > v4: > - add new helpers, fill_local/remote_addresses_vec > - add max_subflows checks > - add 'local' into the local addresses array only when no fullmesh > entry found. > - add signal,fullmesh check > > v3: > - the in-kernel fullmesh path manager has been dropped from this > patchset, only keep the fullmesh flag support code. > > v2: > - Implement the fullmesh mode as an extension to the netlink PM, not a > standalone PM as Paolo suggested. > - drop duplicate code. > - add a new per endpoint flag MPTCP_PM_ADDR_FLAG_FULLMESH. > > Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/193 > > Geliang Tang (5): > mptcp: remote addresses fullmesh > mptcp: local addresses fullmesh > selftests: mptcp: set and print the fullmesh flag > selftests: mptcp: add fullmesh testcases > selftests: mptcp: delete uncontinuous removing ids > > include/uapi/linux/mptcp.h | 1 + > net/mptcp/pm_netlink.c | 145 ++++++++++++++++-- > .../testing/selftests/net/mptcp/mptcp_join.sh | 67 +++++++- > tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 16 +- > 4 files changed, 206 insertions(+), 23 deletions(-) LGTM, I added some minor comment on patch 4/5, but could be addressed later/with squash-to patches. Acked-by: Paolo Abeni <pabeni@redhat.com>
On Tue, 27 Jul 2021, Geliang Tang wrote: > From: Geliang Tang <geliangtang@xiaomi.com> > > v6: > - drop lookup_subflow_by_addrs() > - pass three arrays instead of 'entries' in fill_local_adresses_vec() > - drop the 'remote' argument of fill_local_addresses_vec > - drop the 'local' argument of fill_remote_addresses_vec > - fix the pm.subflows. > - add limit testcase. > Thanks for the revisions! Extending the netlink PM is a much better fit. I don't have any comments to add to Paolo and Mattheiu's squash-fix recommendations. Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com> -Mat > v5: > - patch 1, add a new helper lookup_address_in_vec. > - patch 2, update pm.subflows in the non-fullmesh case. > - patch 4, add more tests. > - tag: export/20210727T054640 > > v4: > - add new helpers, fill_local/remote_addresses_vec > - add max_subflows checks > - add 'local' into the local addresses array only when no fullmesh > entry found. > - add signal,fullmesh check > > v3: > - the in-kernel fullmesh path manager has been dropped from this > patchset, only keep the fullmesh flag support code. > > v2: > - Implement the fullmesh mode as an extension to the netlink PM, not a > standalone PM as Paolo suggested. > - drop duplicate code. > - add a new per endpoint flag MPTCP_PM_ADDR_FLAG_FULLMESH. > > Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/193 > > Geliang Tang (5): > mptcp: remote addresses fullmesh > mptcp: local addresses fullmesh > selftests: mptcp: set and print the fullmesh flag > selftests: mptcp: add fullmesh testcases > selftests: mptcp: delete uncontinuous removing ids > > include/uapi/linux/mptcp.h | 1 + > net/mptcp/pm_netlink.c | 145 ++++++++++++++++-- > .../testing/selftests/net/mptcp/mptcp_join.sh | 67 +++++++- > tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 16 +- > 4 files changed, 206 insertions(+), 23 deletions(-) > > -- > 2.31.1 > > > -- Mat Martineau Intel
From: Geliang Tang <geliangtang@xiaomi.com> v6: - drop lookup_subflow_by_addrs() - pass three arrays instead of 'entries' in fill_local_adresses_vec() - drop the 'remote' argument of fill_local_addresses_vec - drop the 'local' argument of fill_remote_addresses_vec - fix the pm.subflows. - add limit testcase. v5: - patch 1, add a new helper lookup_address_in_vec. - patch 2, update pm.subflows in the non-fullmesh case. - patch 4, add more tests. - tag: export/20210727T054640 v4: - add new helpers, fill_local/remote_addresses_vec - add max_subflows checks - add 'local' into the local addresses array only when no fullmesh entry found. - add signal,fullmesh check v3: - the in-kernel fullmesh path manager has been dropped from this patchset, only keep the fullmesh flag support code. v2: - Implement the fullmesh mode as an extension to the netlink PM, not a standalone PM as Paolo suggested. - drop duplicate code. - add a new per endpoint flag MPTCP_PM_ADDR_FLAG_FULLMESH. Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/193 Geliang Tang (5): mptcp: remote addresses fullmesh mptcp: local addresses fullmesh selftests: mptcp: set and print the fullmesh flag selftests: mptcp: add fullmesh testcases selftests: mptcp: delete uncontinuous removing ids include/uapi/linux/mptcp.h | 1 + net/mptcp/pm_netlink.c | 145 ++++++++++++++++-- .../testing/selftests/net/mptcp/mptcp_join.sh | 67 +++++++- tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 16 +- 4 files changed, 206 insertions(+), 23 deletions(-)