| Message ID | 20210729131930.1991-1-zhudi21@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 57fb346cc7d0fc59af70b4650ee10048f61d7b4f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ipvlan: Add handling of NETDEV_UP events | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: ap420073@gmail.com johannes@sipsolutions.net |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 29 Jul 2021 21:19:30 +0800 you wrote: > When an ipvlan device is created on a bond device, the link state > of the ipvlan device may be abnormal. This is because bonding device > allows to add physical network card device in the down state and so > NETDEV_CHANGE event will not be notified to other listeners, so ipvlan > has no chance to update its link status. > > The following steps can cause such problems: > 1) bond0 is down > 2) ip link add link bond0 name ipvlan type ipvlan mode l2 > 3) echo +enp2s7 >/sys/class/net/bond0/bonding/slaves > 4) ip link set bond0 up > > [...] Here is the summary with links: - ipvlan: Add handling of NETDEV_UP events https://git.kernel.org/netdev/net-next/c/57fb346cc7d0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index a707502a0c0f..c0b21a5580d5 100644 --- a/drivers/net/ipvlan/ipvlan_main.c +++ b/drivers/net/ipvlan/ipvlan_main.c @@ -732,6 +732,7 @@ static int ipvlan_device_event(struct notifier_block *unused, port = ipvlan_port_get_rtnl(dev); switch (event) { + case NETDEV_UP: case NETDEV_CHANGE: list_for_each_entry(ipvlan, &port->ipvlans, pnode) netif_stacked_transfer_operstate(ipvlan->phy_dev,
When an ipvlan device is created on a bond device, the link state of the ipvlan device may be abnormal. This is because bonding device allows to add physical network card device in the down state and so NETDEV_CHANGE event will not be notified to other listeners, so ipvlan has no chance to update its link status. The following steps can cause such problems: 1) bond0 is down 2) ip link add link bond0 name ipvlan type ipvlan mode l2 3) echo +enp2s7 >/sys/class/net/bond0/bonding/slaves 4) ip link set bond0 up After these steps, use ip link command, we found ipvlan has NO-CARRIER: ipvlan@bond0: <NO-CARRIER, BROADCAST,MULTICAST,UP,M-DOWN> mtu ...> We can deal with this problem like VLAN: Add handling of NETDEV_UP events. If we receive NETDEV_UP event, we will update the link status of the ipvlan. Signed-off-by: Di Zhu <zhudi21@huawei.com> --- drivers/net/ipvlan/ipvlan_main.c | 1 + 1 file changed, 1 insertion(+)