| Message ID | 20210727171313.2452236-1-adrian.ratiu@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] char: tpm: Kconfig: remove bad i2c cr50 select | expand |
On Tue, Jul 27, 2021 at 08:13:12PM +0300, Adrian Ratiu wrote: > This fixes a minor bug which went unnoticed during the initial > driver upstreaming review: TCG_CR50 does not exist in mainline > kernels, so remove it. > > Fixes: 3a253caaad11 ("char: tpm: add i2c driver for cr50") > Cc: stable@vger.kernel.org > Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> > Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com> > --- These are missing changelog. I guess tags are added, and nothing else? /Jarkko
On Thu, 29 Jul 2021, Jarkko Sakkinen <jarkko@kernel.org> wrote: > On Tue, Jul 27, 2021 at 08:13:12PM +0300, Adrian Ratiu wrote: >> This fixes a minor bug which went unnoticed during the initial >> driver upstreaming review: TCG_CR50 does not exist in mainline >> kernels, so remove it. Fixes: 3a253caaad11 ("char: tpm: add >> i2c driver for cr50") Cc: stable@vger.kernel.org Reviewed-by: >> Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by: Adrian Ratiu >> <adrian.ratiu@collabora.com> --- > > These are missing changelog. I guess tags are added, and nothing > else? Hi. That is correct, I've only added the tags you suggested on the first patch, the second patch is identical. Adrian > > /Jarkko
On Thu, Jul 29, 2021 at 02:10:16PM +0300, Adrian Ratiu wrote: > On Thu, 29 Jul 2021, Jarkko Sakkinen <jarkko@kernel.org> wrote: > > On Tue, Jul 27, 2021 at 08:13:12PM +0300, Adrian Ratiu wrote: > > > This fixes a minor bug which went unnoticed during the initial > > > driver upstreaming review: TCG_CR50 does not exist in mainline > > > kernels, so remove it. Fixes: 3a253caaad11 ("char: tpm: add i2c > > > driver for cr50") Cc: stable@vger.kernel.org Reviewed-by: Jarkko > > > Sakkinen <jarkko@kernel.org> Signed-off-by: Adrian Ratiu > > > <adrian.ratiu@collabora.com> --- > > > > These are missing changelog. I guess tags are added, and nothing else? > > Hi. That is correct, I've only added the tags you suggested on the first > patch, the second patch is identical. OK, cool. I'll pick this up then. Thank you. /Jarkko
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig index 4308f9ca7a43..d6ba644f6b00 100644 --- a/drivers/char/tpm/Kconfig +++ b/drivers/char/tpm/Kconfig @@ -89,7 +89,6 @@ config TCG_TIS_SYNQUACER config TCG_TIS_I2C_CR50 tristate "TPM Interface Specification 2.0 Interface (I2C - CR50)" depends on I2C - select TCG_CR50 help This is a driver for the Google cr50 I2C TPM interface which is a custom microcontroller and requires a custom i2c protocol interface
This fixes a minor bug which went unnoticed during the initial driver upstreaming review: TCG_CR50 does not exist in mainline kernels, so remove it. Fixes: 3a253caaad11 ("char: tpm: add i2c driver for cr50") Cc: stable@vger.kernel.org Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com> --- drivers/char/tpm/Kconfig | 1 - 1 file changed, 1 deletion(-)