| Message ID | 20210730061301.32492-1-zhaoxiao@uniontech.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm:This patch fixes the checkpatch.pl error to msm_drv.c | expand |
On Fri, 30 Jul 2021 at 09:13, zhaoxiao <zhaoxiao@uniontech.com> wrote: > > ERROR: do not initialise statics to false > > Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com> Could you please resend this patch following the style of the rest of patches being submitted to this area? Subject, more detailed patch description, etc. > --- > drivers/gpu/drm/msm/msm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 9b8fa2ad0d84..d9ca4bc9620b 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -59,7 +59,7 @@ static const struct drm_mode_config_helper_funcs mode_config_helper_funcs = { > }; > > #ifdef CONFIG_DRM_MSM_REGISTER_LOGGING > -static bool reglog = false; > +static bool reglog; > MODULE_PARM_DESC(reglog, "Enable register read/write logging"); > module_param(reglog, bool, 0600); > #else > @@ -76,7 +76,7 @@ static char *vram = "16m"; > MODULE_PARM_DESC(vram, "Configure VRAM size (for devices without IOMMU/GPUMMU)"); > module_param(vram, charp, 0); > > -bool dumpstate = false; > +bool dumpstate; > MODULE_PARM_DESC(dumpstate, "Dump KMS state on errors"); > module_param(dumpstate, bool, 0600); > > -- > 2.20.1 > > >
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 9b8fa2ad0d84..d9ca4bc9620b 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -59,7 +59,7 @@ static const struct drm_mode_config_helper_funcs mode_config_helper_funcs = { }; #ifdef CONFIG_DRM_MSM_REGISTER_LOGGING -static bool reglog = false; +static bool reglog; MODULE_PARM_DESC(reglog, "Enable register read/write logging"); module_param(reglog, bool, 0600); #else @@ -76,7 +76,7 @@ static char *vram = "16m"; MODULE_PARM_DESC(vram, "Configure VRAM size (for devices without IOMMU/GPUMMU)"); module_param(vram, charp, 0); -bool dumpstate = false; +bool dumpstate; MODULE_PARM_DESC(dumpstate, "Dump KMS state on errors"); module_param(dumpstate, bool, 0600);
ERROR: do not initialise statics to false Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com> --- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)