| Message ID | 20210728035859.5405-5-tinghan.shen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Mediatek MT8195 SCP support | expand |
On Wed, Jul 28, 2021 at 11:58:59AM +0800, Tinghan Shen wrote: > The SCP clock design is changed on mt8195 that doesn't need to control > SCP clock on kernel side. > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
On Tue 27 Jul 22:58 CDT 2021, Tinghan Shen wrote: > The SCP clock design is changed on mt8195 that doesn't need to control > SCP clock on kernel side. > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > --- > drivers/remoteproc/mtk_scp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 9679cc26895e..250cb946ea37 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -785,7 +785,7 @@ static int scp_probe(struct platform_device *pdev) > if (ret) > goto destroy_mutex; > > - scp->clk = devm_clk_get(dev, "main"); > + scp->clk = devm_clk_get_optional(dev, "main"); This makes the clock optional for mt8183 and mt8192 as well. How about using mtk_scp_of_data to denote if the clock should be acquired? Regards, Bjorn > if (IS_ERR(scp->clk)) { > dev_err(dev, "Failed to get clock\n"); > ret = PTR_ERR(scp->clk); > @@ -877,6 +877,7 @@ static const struct mtk_scp_of_data mt8192_of_data = { > static const struct of_device_id mtk_scp_of_match[] = { > { .compatible = "mediatek,mt8183-scp", .data = &mt8183_of_data }, > { .compatible = "mediatek,mt8192-scp", .data = &mt8192_of_data }, > + { .compatible = "mediatek,mt8195-scp", .data = &mt8192_of_data }, > {}, > }; > MODULE_DEVICE_TABLE(of, mtk_scp_of_match); > -- > 2.18.0 >
diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index 9679cc26895e..250cb946ea37 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c @@ -785,7 +785,7 @@ static int scp_probe(struct platform_device *pdev) if (ret) goto destroy_mutex; - scp->clk = devm_clk_get(dev, "main"); + scp->clk = devm_clk_get_optional(dev, "main"); if (IS_ERR(scp->clk)) { dev_err(dev, "Failed to get clock\n"); ret = PTR_ERR(scp->clk); @@ -877,6 +877,7 @@ static const struct mtk_scp_of_data mt8192_of_data = { static const struct of_device_id mtk_scp_of_match[] = { { .compatible = "mediatek,mt8183-scp", .data = &mt8183_of_data }, { .compatible = "mediatek,mt8192-scp", .data = &mt8192_of_data }, + { .compatible = "mediatek,mt8195-scp", .data = &mt8192_of_data }, {}, }; MODULE_DEVICE_TABLE(of, mtk_scp_of_match);
The SCP clock design is changed on mt8195 that doesn't need to control SCP clock on kernel side. Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> --- drivers/remoteproc/mtk_scp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)