diff mbox series

[bpf-next,v2] selftests/bpf: Test btf__load_vmlinux_btf/btf__load_module_btf APIs

Message ID 20210802160556.1271747-1-hengqi.chen@gmail.com (mailing list archive)
State Superseded
Delegated to: BPF
Headers show
Series [bpf-next,v2] selftests/bpf: Test btf__load_vmlinux_btf/btf__load_module_btf APIs | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for bpf-next
netdev/subject_prefix success Link
netdev/cc_maintainers warning 6 maintainers not CCed: linux-kselftest@vger.kernel.org netdev@vger.kernel.org kpsingh@kernel.org kafai@fb.com songliubraving@fb.com shuah@kernel.org
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch fail ERROR: Bad function definition - void test_btf_module() should probably be void test_btf_module(void) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link

Commit Message

Hengqi Chen Aug. 2, 2021, 4:05 p.m. UTC
Add test for btf__load_vmlinux_btf/btf__load_module_btf APIs. It first
checks that if btrfs module BTF exists, if yes, load module BTF and
check symbol existence.

Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
---
 .../selftests/bpf/prog_tests/btf_module.c     | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/btf_module.c

--
2.25.1

Comments

Andrii Nakryiko Aug. 2, 2021, 9:17 p.m. UTC | #1
On Mon, Aug 2, 2021 at 9:06 AM Hengqi Chen <hengqi.chen@gmail.com> wrote:
>
> Add test for btf__load_vmlinux_btf/btf__load_module_btf APIs. It first
> checks that if btrfs module BTF exists, if yes, load module BTF and
> check symbol existence.
>
> Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
> ---
>  .../selftests/bpf/prog_tests/btf_module.c     | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 tools/testing/selftests/bpf/prog_tests/btf_module.c
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/btf_module.c b/tools/testing/selftests/bpf/prog_tests/btf_module.c
> new file mode 100644
> index 000000000000..9314a46e001c
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/prog_tests/btf_module.c
> @@ -0,0 +1,32 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (c) 2021 Hengqi Chen */
> +
> +#include <test_progs.h>
> +#include <bpf/btf.h>
> +
> +static const char *module_path = "/sys/kernel/btf/btrfs";
> +static const char *module_name = "btrfs";
> +
> +void test_btf_module()
> +{
> +       struct btf *vmlinux_btf, *module_btf;
> +       __s32 type_id;
> +
> +       if (access(module_path, F_OK))
> +               return;

we shouldn't use btrfs module, as it might not be mounted in our CI
environment. Good news is that selftests uses its own custom module to
do various module-related logic. It's already preloaded for all tests,
so you can just assume its existence (unless pre-loading fails, then
error out). See how "bpf_testmod" is used in selftests.

> +
> +       vmlinux_btf = btf__load_vmlinux_btf();
> +       if (!ASSERT_OK_PTR(vmlinux_btf, "could not load vmlinux BTF"))
> +               return;
> +
> +       module_btf = btf__load_module_btf(module_name, vmlinux_btf);
> +       if (!ASSERT_OK_PTR(module_btf, "could not load module BTF"))
> +               goto cleanup;
> +
> +       type_id = btf__find_by_name(module_btf, "btrfs_file_open");
> +       ASSERT_GT(type_id, 0, "func btrfs_file_open not found");
> +
> +cleanup:
> +       btf__free(module_btf);
> +       btf__free(vmlinux_btf);
> +}
> --
> 2.25.1
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/prog_tests/btf_module.c b/tools/testing/selftests/bpf/prog_tests/btf_module.c
new file mode 100644
index 000000000000..9314a46e001c
--- /dev/null
+++ b/tools/testing/selftests/bpf/prog_tests/btf_module.c
@@ -0,0 +1,32 @@ 
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2021 Hengqi Chen */
+
+#include <test_progs.h>
+#include <bpf/btf.h>
+
+static const char *module_path = "/sys/kernel/btf/btrfs";
+static const char *module_name = "btrfs";
+
+void test_btf_module()
+{
+	struct btf *vmlinux_btf, *module_btf;
+	__s32 type_id;
+
+	if (access(module_path, F_OK))
+		return;
+
+	vmlinux_btf = btf__load_vmlinux_btf();
+	if (!ASSERT_OK_PTR(vmlinux_btf, "could not load vmlinux BTF"))
+		return;
+
+	module_btf = btf__load_module_btf(module_name, vmlinux_btf);
+	if (!ASSERT_OK_PTR(module_btf, "could not load module BTF"))
+		goto cleanup;
+
+	type_id = btf__find_by_name(module_btf, "btrfs_file_open");
+	ASSERT_GT(type_id, 0, "func btrfs_file_open not found");
+
+cleanup:
+	btf__free(module_btf);
+	btf__free(vmlinux_btf);
+}