diff mbox series

net: marvell: make the array name static, makes object smaller

Message ID 20210801150647.145728-1-colin.king@canonical.com (mailing list archive)
State Accepted
Commit 628fe1cedda6cc503ec9ca21ec19938f2e625754
Delegated to: Netdev Maintainers
Headers show
Series net: marvell: make the array name static, makes object smaller | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cc_maintainers warning 1 maintainers not CCed: stephen@networkplumber.org
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 7 this patch: 7
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 7 this patch: 7
netdev/header_inline success Link

Commit Message

Colin King Aug. 1, 2021, 3:06 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Don't populate the const array name on the stack but instead it
static. Makes the object code smaller by 28 bytes. Add a missing
const to clean up a checkpatch warning.

Before:
   text    data   bss     dec     hex filename
 124565   31565   384  156514   26362 drivers/net/ethernet/marvell/sky2.o

After:
   text    data   bss     dec     hex filename
 124441   31661   384  156486   26346 drivers/net/ethernet/marvell/sky2.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/marvell/sky2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Aug. 2, 2021, 10:10 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sun,  1 Aug 2021 16:06:47 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate the const array name on the stack but instead it
> static. Makes the object code smaller by 28 bytes. Add a missing
> const to clean up a checkpatch warning.
> 
> Before:
>    text    data   bss     dec     hex filename
>  124565   31565   384  156514   26362 drivers/net/ethernet/marvell/sky2.o
> 
> [...]

Here is the summary with links:
  - net: marvell: make the array name static, makes object smaller
    https://git.kernel.org/netdev/net-next/c/628fe1cedda6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index 743ca96527fa..4f51882d83ca 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -4884,7 +4884,7 @@  static int sky2_test_msi(struct sky2_hw *hw)
 /* This driver supports yukon2 chipset only */
 static const char *sky2_name(u8 chipid, char *buf, int sz)
 {
-	const char *name[] = {
+	static const char *const name[] = {
 		"XL",		/* 0xb3 */
 		"EC Ultra", 	/* 0xb4 */
 		"Extreme",	/* 0xb5 */