| Message ID | 1313386893.25484.1.camel@phoenix (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Axel, On Mon, Aug 15, 2011 at 11:11:33, Axel Lin wrote: > Since commit 5093aec872e5be7a55d8dd2b639e8a3818dc19db > "arm: davinci: Cleanup irq chip code", > the variable 'mask' and 'g' are not being used in gpio_irq_type. > > This patch eliminate below unused variable warnings: > > CC arch/arm/mach-davinci/gpio.o > arch/arm/mach-davinci/gpio.c: In function 'gpio_irq_type': > arch/arm/mach-davinci/gpio.c:234: warning: unused variable 'mask' > arch/arm/mach-davinci/gpio.c:233: warning: unused variable 'g' > > Signed-off-by: Axel Lin <axel.lin@gmail.com> Thanks for the fix! There is a patch in linux-next committed by Russell which moves the DaVinci gpio driver to drivers/gpio/. Can you please redo this fix to apply on linux-next? Once Russell approves, it can go though his patch system so there are no conflicts. Thanks, Sekhar
diff --git a/arch/arm/mach-davinci/gpio.c b/arch/arm/mach-davinci/gpio.c index a8066e8..df0d595 100644 --- a/arch/arm/mach-davinci/gpio.c +++ b/arch/arm/mach-davinci/gpio.c @@ -230,9 +230,6 @@ static void gpio_irq_enable(struct irq_data *d) static int gpio_irq_type(struct irq_data *d, unsigned trigger) { - struct davinci_gpio_regs __iomem *g = irq2regs(d->irq); - u32 mask = (u32) irq_data_get_irq_handler_data(d); - if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING)) return -EINVAL;
Since commit 5093aec872e5be7a55d8dd2b639e8a3818dc19db "arm: davinci: Cleanup irq chip code", the variable 'mask' and 'g' are not being used in gpio_irq_type. This patch eliminate below unused variable warnings: CC arch/arm/mach-davinci/gpio.o arch/arm/mach-davinci/gpio.c: In function 'gpio_irq_type': arch/arm/mach-davinci/gpio.c:234: warning: unused variable 'mask' arch/arm/mach-davinci/gpio.c:233: warning: unused variable 'g' Signed-off-by: Axel Lin <axel.lin@gmail.com> --- arch/arm/mach-davinci/gpio.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)