| Message ID | 1627098243-2742-3-git-send-email-dillon.minfei@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add ilitek ili9341 panel driver | expand |
On Sat, Jul 24, 2021 at 5:44 AM <dillon.minfei@gmail.com> wrote: > From: Dillon Min <dillon.minfei@gmail.com> > > Since the compatible string defined from ilitek,ili9341.yaml is > "st,sf-tc240t-9370-t", "ilitek,ili9341" > > so, append "ilitek,ili9341" to avoid the below dtbs_check warning. > > arch/arm/boot/dts/stm32f429-disco.dt.yaml: display@1: compatible: > ['st,sf-tc240t-9370-t'] is too short > > Fixes: a726e2f000ec ("ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on stm32429-disco board") > Signed-off-by: Dillon Min <dillon.minfei@gmail.com> > Reported-by: kernel test robot <lkp@intel.com> > --- > v4: no change. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Please funnel this patch through the STM and ARM SoC tree. Yours, Linus Walleij
Hi Linus Thanks. On Thu, 5 Aug 2021 at 17:11, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Sat, Jul 24, 2021 at 5:44 AM <dillon.minfei@gmail.com> wrote: > > > From: Dillon Min <dillon.minfei@gmail.com> > > > > Since the compatible string defined from ilitek,ili9341.yaml is > > "st,sf-tc240t-9370-t", "ilitek,ili9341" > > > > so, append "ilitek,ili9341" to avoid the below dtbs_check warning. > > > > arch/arm/boot/dts/stm32f429-disco.dt.yaml: display@1: compatible: > > ['st,sf-tc240t-9370-t'] is too short > > > > Fixes: a726e2f000ec ("ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on stm32429-disco board") > > Signed-off-by: Dillon Min <dillon.minfei@gmail.com> > > Reported-by: kernel test robot <lkp@intel.com> > > --- > > v4: no change. > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Please funnel this patch through the STM and ARM SoC tree. Sure, I will let Alex know. Thanks for your help on this driver. Hi Alex, Should I send v5 with Linus's Reviewed-by tag on this patch? thanks. Best Regards Dillon > > Yours, > Linus Walleij
Hi Dillon On 8/5/21 11:19 AM, Dillon Min wrote: > Hi Linus > > Thanks. > > On Thu, 5 Aug 2021 at 17:11, Linus Walleij <linus.walleij@linaro.org> wrote: >> >> On Sat, Jul 24, 2021 at 5:44 AM <dillon.minfei@gmail.com> wrote: >> >>> From: Dillon Min <dillon.minfei@gmail.com> >>> >>> Since the compatible string defined from ilitek,ili9341.yaml is >>> "st,sf-tc240t-9370-t", "ilitek,ili9341" >>> >>> so, append "ilitek,ili9341" to avoid the below dtbs_check warning. >>> >>> arch/arm/boot/dts/stm32f429-disco.dt.yaml: display@1: compatible: >>> ['st,sf-tc240t-9370-t'] is too short >>> >>> Fixes: a726e2f000ec ("ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on stm32429-disco board") >>> Signed-off-by: Dillon Min <dillon.minfei@gmail.com> >>> Reported-by: kernel test robot <lkp@intel.com> >>> --- >>> v4: no change. >> >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> >> Please funnel this patch through the STM and ARM SoC tree. > > Sure, I will let Alex know. Thanks for your help on this driver. > > Hi Alex, > Should I send v5 with Linus's Reviewed-by tag on this patch? thanks. No, I'll do it. cheers alex > > Best Regards > Dillon > >> >> Yours, >> Linus Walleij
Hi Dillon On 7/24/21 5:44 AM, dillon.minfei@gmail.com wrote: > From: Dillon Min <dillon.minfei@gmail.com> > > Since the compatible string defined from ilitek,ili9341.yaml is > "st,sf-tc240t-9370-t", "ilitek,ili9341" > > so, append "ilitek,ili9341" to avoid the below dtbs_check warning. > > arch/arm/boot/dts/stm32f429-disco.dt.yaml: display@1: compatible: > ['st,sf-tc240t-9370-t'] is too short > > Fixes: a726e2f000ec ("ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on stm32429-disco board") > Signed-off-by: Dillon Min <dillon.minfei@gmail.com> > Reported-by: kernel test robot <lkp@intel.com> > --- > v4: no change. > > arch/arm/boot/dts/stm32f429-disco.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/stm32f429-disco.dts b/arch/arm/boot/dts/stm32f429-disco.dts > index 075ac57d0bf4..6435e099c632 100644 > --- a/arch/arm/boot/dts/stm32f429-disco.dts > +++ b/arch/arm/boot/dts/stm32f429-disco.dts > @@ -192,7 +192,7 @@ > > display: display@1{ > /* Connect panel-ilitek-9341 to ltdc */ > - compatible = "st,sf-tc240t-9370-t"; > + compatible = "st,sf-tc240t-9370-t", "ilitek,ili9341"; > reg = <1>; > spi-3wire; > spi-max-frequency = <10000000>; > Patch applied on stm32-next. I updated commit title to indicate targeted board. regards Alex
diff --git a/arch/arm/boot/dts/stm32f429-disco.dts b/arch/arm/boot/dts/stm32f429-disco.dts index 075ac57d0bf4..6435e099c632 100644 --- a/arch/arm/boot/dts/stm32f429-disco.dts +++ b/arch/arm/boot/dts/stm32f429-disco.dts @@ -192,7 +192,7 @@ display: display@1{ /* Connect panel-ilitek-9341 to ltdc */ - compatible = "st,sf-tc240t-9370-t"; + compatible = "st,sf-tc240t-9370-t", "ilitek,ili9341"; reg = <1>; spi-3wire; spi-max-frequency = <10000000>;