| Message ID | 20210807124903.1237510-1-jun.miao@windriver.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | atm: horizon: Fix spelling mistakes in TX comment | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 3 of 3 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 100 this patch: 100 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 13 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 100 this patch: 100 |
| netdev/header_inline | success | Link |
On Sat, 2021-08-07 at 20:49 +0800, Jun Miao wrote: > It's "mustn't", not "musn't", meaning "shall not". > Let's fix that. Perhaps more useful to change to 'must not' for the non-native speaker. > diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c [] > @@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc) > > > // Part of the job is done by atm_pcr_goal which gives us a PCR > // specification which says: EITHER grab the maximum available PCR > - // (and perhaps a lower bound which we musn't pass), OR grab this > + // (and perhaps a lower bound which we mustn't pass), OR grab this > // amount, rounding down if you have to (and perhaps a lower bound > - // which we musn't pass) OR grab this amount, rounding up if you > - // have to (and perhaps an upper bound which we musn't pass). If any > + // which we mustn't pass) OR grab this amount, rounding up if you > + // have to (and perhaps an upper bound which we mustn't pass). If any > // bounds ARE passed we fail. Note that rounding is only rounding to > // match device limitations, we do not round down to satisfy > // bandwidth availability even if this would not violate any given
On 8/7/21 9:21 PM, Joe Perches wrote: > [Please note: This e-mail is from an EXTERNAL e-mail address] > > On Sat, 2021-08-07 at 20:49 +0800, Jun Miao wrote: >> It's "mustn't", not "musn't", meaning "shall not". >> Let's fix that. > Perhaps more useful to change to 'must not' for the > non-native speaker. Ok, V2 : Suggested-by: Joe Perches <joe@perches.com> Thanks Jun >> diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c > [] What's mean this [] ? >> @@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc) >> >> >> // Part of the job is done by atm_pcr_goal which gives us a PCR >> // specification which says: EITHER grab the maximum available PCR >> - // (and perhaps a lower bound which we musn't pass), OR grab this >> + // (and perhaps a lower bound which we mustn't pass), OR grab this >> // amount, rounding down if you have to (and perhaps a lower bound >> - // which we musn't pass) OR grab this amount, rounding up if you >> - // have to (and perhaps an upper bound which we musn't pass). If any >> + // which we mustn't pass) OR grab this amount, rounding up if you >> + // have to (and perhaps an upper bound which we mustn't pass). If any >> // bounds ARE passed we fail. Note that rounding is only rounding to >> // match device limitations, we do not round down to satisfy >> // bandwidth availability even if this would not violate any given >
diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c index 4f2951cbe69c..9ee494bc5c51 100644 --- a/drivers/atm/horizon.c +++ b/drivers/atm/horizon.c @@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc) // Part of the job is done by atm_pcr_goal which gives us a PCR // specification which says: EITHER grab the maximum available PCR - // (and perhaps a lower bound which we musn't pass), OR grab this + // (and perhaps a lower bound which we mustn't pass), OR grab this // amount, rounding down if you have to (and perhaps a lower bound - // which we musn't pass) OR grab this amount, rounding up if you - // have to (and perhaps an upper bound which we musn't pass). If any + // which we mustn't pass) OR grab this amount, rounding up if you + // have to (and perhaps an upper bound which we mustn't pass). If any // bounds ARE passed we fail. Note that rounding is only rounding to // match device limitations, we do not round down to satisfy // bandwidth availability even if this would not violate any given
It's "mustn't", not "musn't", meaning "shall not". Let's fix that. Signed-off-by: Jun Miao <jun.miao@windriver.com> --- drivers/atm/horizon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)