[0/5] Cleanups and fixup for gup

Message

Miaohe Lin Aug. 7, 2021, 9:36 a.m. UTC

Hi all,
This series contains cleanups to remove unneeded variable, useless
BUG_ON and use helper to improve readability. Also we fix a potential
pgmap refcnt leak. More details can be found in the respective
changelogs. Thanks!

Miaohe Lin (5):
  mm: gup: remove set but unused local variable major
  mm: gup: remove unneed local variable orig_refs
  mm: gup: remove useless BUG_ON in __get_user_pages()
  mm: gup: fix potential pgmap refcnt leak in __gup_device_huge()
  mm: gup: use helper PAGE_ALIGNED in populate_vma_page_range()

 mm/gup.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

Comments

John Hubbard Aug. 8, 2021, 9:13 p.m. UTC | #1

On 8/7/21 2:36 AM, Miaohe Lin wrote:
> Hi all,
> This series contains cleanups to remove unneeded variable, useless
> BUG_ON and use helper to improve readability. Also we fix a potential
> pgmap refcnt leak. More details can be found in the respective
> changelogs. Thanks!
> 
> Miaohe Lin (5):
>    mm: gup: remove set but unused local variable major
>    mm: gup: remove unneed local variable orig_refs
>    mm: gup: remove useless BUG_ON in __get_user_pages()
>    mm: gup: fix potential pgmap refcnt leak in __gup_device_huge()
>    mm: gup: use helper PAGE_ALIGNED in populate_vma_page_range()
> 
>   mm/gup.c | 16 ++++++----------
>   1 file changed, 6 insertions(+), 10 deletions(-)
> 

For the series:

Reviewed-by: John Hubbard <[e-mail]>


thanks,

Claudio Imbrenda Aug. 9, 2021, 9:39 a.m. UTC | #2

On Sat, 7 Aug 2021 17:36:15 +0800
Miaohe Lin <[e-mail]> wrote:

> Hi all,
> This series contains cleanups to remove unneeded variable, useless
> BUG_ON and use helper to improve readability. Also we fix a potential
> pgmap refcnt leak. More details can be found in the respective
> changelogs. Thanks!
> 
> Miaohe Lin (5):
>   mm: gup: remove set but unused local variable major
>   mm: gup: remove unneed local variable orig_refs
>   mm: gup: remove useless BUG_ON in __get_user_pages()
>   mm: gup: fix potential pgmap refcnt leak in __gup_device_huge()
>   mm: gup: use helper PAGE_ALIGNED in populate_vma_page_range()
> 
>  mm/gup.c | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
> 

Whole series (including the fixup for the return value):

Reviewed-by: Claudio Imbrenda <[e-mail]>