| Message ID | 20210807093620.21347-6-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Cleanups and fixup for gup | expand |
On 07.08.21 11:36, Miaohe Lin wrote: > Use helper PAGE_ALIGNED to check if address is aligned to PAGE_SIZE. > Minor readability improvement. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > --- > mm/gup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 8c89e614d4aa..802a3deb50cd 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1471,8 +1471,8 @@ long populate_vma_page_range(struct vm_area_struct *vma, > unsigned long nr_pages = (end - start) / PAGE_SIZE; > int gup_flags; > > - VM_BUG_ON(start & ~PAGE_MASK); > - VM_BUG_ON(end & ~PAGE_MASK); > + VM_BUG_ON(!PAGE_ALIGNED(start)); > + VM_BUG_ON(!PAGE_ALIGNED(end)); > VM_BUG_ON_VMA(start < vma->vm_start, vma); > VM_BUG_ON_VMA(end > vma->vm_end, vma); > mmap_assert_locked(mm); > Making it look more like faultin_vma_page_range(), nice :) Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/mm/gup.c b/mm/gup.c index 8c89e614d4aa..802a3deb50cd 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -1471,8 +1471,8 @@ long populate_vma_page_range(struct vm_area_struct *vma, unsigned long nr_pages = (end - start) / PAGE_SIZE; int gup_flags; - VM_BUG_ON(start & ~PAGE_MASK); - VM_BUG_ON(end & ~PAGE_MASK); + VM_BUG_ON(!PAGE_ALIGNED(start)); + VM_BUG_ON(!PAGE_ALIGNED(end)); VM_BUG_ON_VMA(start < vma->vm_start, vma); VM_BUG_ON_VMA(end > vma->vm_end, vma); mmap_assert_locked(mm);
Use helper PAGE_ALIGNED to check if address is aligned to PAGE_SIZE. Minor readability improvement. Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)