diff mbox series

[bpf-next,4/5] Display test number when listing test names

Message ID 20210809233633.973638-4-fallentree@fb.com (mailing list archive)
State Changes Requested
Delegated to: BPF
Headers show
Series [bpf-next,1/5] Skip loading bpf_testmod when using -l to list tests. | expand

Checks

Context Check Description
netdev/cover_letter warning Series does not have a cover letter
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for bpf-next
netdev/subject_prefix success Link
netdev/cc_maintainers warning 10 maintainers not CCed: daniel@iogearbox.net netdev@vger.kernel.org john.fastabend@gmail.com linux-kselftest@vger.kernel.org shuah@kernel.org songliubraving@fb.com ast@kernel.org yhs@fb.com kpsingh@kernel.org kafai@fb.com
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff fail Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch warning WARNING: Missing commit description - Add an appropriate one
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link

Commit Message

Yucong Sun Aug. 9, 2021, 11:36 p.m. UTC 
---
 tools/testing/selftests/bpf/test_progs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Daniel Borkmann Aug. 9, 2021, 11:55 p.m. UTC | #1 
Hi Yucong,

thanks for your patches!

On 8/10/21 1:36 AM, Yucong Sun wrote:
> ---

Please make sure all of your patches have proper Signed-off-by and at least a
minimal commit message (instead of empty one).

Thanks,
Daniel

>   tools/testing/selftests/bpf/test_progs.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
> index 82d012671552..5cc808992b00 100644
> --- a/tools/testing/selftests/bpf/test_progs.c
> +++ b/tools/testing/selftests/bpf/test_progs.c
> @@ -867,7 +867,8 @@ int main(int argc, char **argv)
>   		}
>   
>   		if (env.list_test_names) {
> -			fprintf(env.stdout, "%s\n", test->test_name);
> +			fprintf(env.stdout, "# %d %s\n",
> +				test->test_num, test->test_name);
>   			env.succ_cnt++;
>   			continue;
>   		}
>
Yucong Sun Aug. 10, 2021, 12:16 a.m. UTC | #2 
Thanks, I re-generated the patch series with a cover letter, also added more description to each patch, PTAL.

Cheers.

On 8/9/21, 4:55 PM, "Daniel Borkmann" <daniel@iogearbox.net> wrote:

    Hi Yucong,

    thanks for your patches!

    On 8/10/21 1:36 AM, Yucong Sun wrote:
    > ---

    Please make sure all of your patches have proper Signed-off-by and at least a
    minimal commit message (instead of empty one).

    Thanks,
    Daniel

    >   tools/testing/selftests/bpf/test_progs.c | 3 ++-
    >   1 file changed, 2 insertions(+), 1 deletion(-)
    > 
    > diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
    > index 82d012671552..5cc808992b00 100644
    > --- a/tools/testing/selftests/bpf/test_progs.c
    > +++ b/tools/testing/selftests/bpf/test_progs.c
    > @@ -867,7 +867,8 @@ int main(int argc, char **argv)
    >   		}
    >   
    >   		if (env.list_test_names) {
    > -			fprintf(env.stdout, "%s\n", test->test_name);
    > +			fprintf(env.stdout, "# %d %s\n",
    > +				test->test_num, test->test_name);
    >   			env.succ_cnt++;
    >   			continue;
    >   		}
    >
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
index 82d012671552..5cc808992b00 100644
--- a/tools/testing/selftests/bpf/test_progs.c
+++ b/tools/testing/selftests/bpf/test_progs.c
@@ -867,7 +867,8 @@  int main(int argc, char **argv)
 		}
 
 		if (env.list_test_names) {
-			fprintf(env.stdout, "%s\n", test->test_name);
+			fprintf(env.stdout, "# %d %s\n",
+				test->test_num, test->test_name);
 			env.succ_cnt++;
 			continue;
 		}