diff mbox series

[bpf-next,v1] bpf: Reconfigure libbpf docs to remove unversioned API

Message ID 20210810020508.280639-1-grantseltzer@gmail.com (mailing list archive)
State Accepted
Commit bb57164920d738076bf91d65af35d8724526c21b
Delegated to: BPF
Headers show
Series [bpf-next,v1] bpf: Reconfigure libbpf docs to remove unversioned API | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for bpf-next
netdev/subject_prefix success Link
netdev/cc_maintainers warning 8 maintainers not CCed: daniel@iogearbox.net netdev@vger.kernel.org john.fastabend@gmail.com songliubraving@fb.com ast@kernel.org yhs@fb.com kpsingh@kernel.org kafai@fb.com
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch warning WARNING: 'seperate' may be misspelled - perhaps 'separate'? WARNING: From:/Signed-off-by: email name mismatch: 'From: grantseltzer <grantseltzer@gmail.com>' != 'Signed-off-by: Grant Seltzer <grantseltzer@gmail.com>' WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link

Commit Message

Grant Seltzer Richman Aug. 10, 2021, 2:05 a.m. UTC
This removes the libbpf_api.rst file from the kernel documentation.
The intention for this file was to pull documentation from comments
above API functions in libbpf. However, due to limitations of the
kernel documentation system, this API documentation could not be
versioned, which is counterintuative to how users expect to use it.
There is also currently no doc comments, making this a blank page.

Once the kernel comment documentation is actually contributed, it
will still exist in the kernel repository, just in the code itself.

A seperate site is being spun up to generate documentaiton from those
comments in a way in which it can be versioned properly.

This also reconfigures the bpf documentation index page to make it
easier to sync to the previously mentioned documentaiton site.

Signed-off-by: Grant Seltzer <grantseltzer@gmail.com>
---
 Documentation/bpf/index.rst             | 10 +--------
 Documentation/bpf/libbpf/libbpf_api.rst | 27 -------------------------
 2 files changed, 1 insertion(+), 36 deletions(-)
 delete mode 100644 Documentation/bpf/libbpf/libbpf_api.rst

Comments

Grant Seltzer Richman Aug. 10, 2021, 2:11 a.m. UTC | #1
On Mon, Aug 9, 2021 at 10:05 PM grantseltzer <grantseltzer@gmail.com> wrote:
>
> This removes the libbpf_api.rst file from the kernel documentation.
> The intention for this file was to pull documentation from comments
> above API functions in libbpf. However, due to limitations of the
> kernel documentation system, this API documentation could not be
> versioned, which is counterintuitive to how users expect to use it.
> There is also currently no doc comments, making this a blank page.
>
> Once the kernel comment documentation is actually contributed, it
> will still exist in the kernel repository, just in the code itself.
>
> A seperate site is being spun up to generate documentaiton from those
> comments in a way in which it can be versioned properly.

For more info regarding the above mentioned separate documentation
site, see https://github.com/libbpf/libbpf/pull/357
patchwork-bot+netdevbpf@kernel.org Aug. 17, 2021, 12:40 a.m. UTC | #2
Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Mon,  9 Aug 2021 22:05:08 -0400 you wrote:
> This removes the libbpf_api.rst file from the kernel documentation.
> The intention for this file was to pull documentation from comments
> above API functions in libbpf. However, due to limitations of the
> kernel documentation system, this API documentation could not be
> versioned, which is counterintuative to how users expect to use it.
> There is also currently no doc comments, making this a blank page.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v1] bpf: Reconfigure libbpf docs to remove unversioned API
    https://git.kernel.org/bpf/bpf-next/c/bb57164920d7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/Documentation/bpf/index.rst b/Documentation/bpf/index.rst
index baea6c2abba5..1ceb5d704a97 100644
--- a/Documentation/bpf/index.rst
+++ b/Documentation/bpf/index.rst
@@ -15,15 +15,7 @@  that goes into great technical depth about the BPF Architecture.
 libbpf
 ======
 
-Libbpf is a userspace library for loading and interacting with bpf programs.
-
-.. toctree::
-   :maxdepth: 1
-
-   libbpf/libbpf
-   libbpf/libbpf_api
-   libbpf/libbpf_build
-   libbpf/libbpf_naming_convention
+Documentation/bpf/libbpf/libbpf.rst is a userspace library for loading and interacting with bpf programs.
 
 BPF Type Format (BTF)
 =====================
diff --git a/Documentation/bpf/libbpf/libbpf_api.rst b/Documentation/bpf/libbpf/libbpf_api.rst
deleted file mode 100644
index f07eecd054da..000000000000
--- a/Documentation/bpf/libbpf/libbpf_api.rst
+++ /dev/null
@@ -1,27 +0,0 @@ 
-.. SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
-
-API
-===
-
-This documentation is autogenerated from header files in libbpf, tools/lib/bpf
-
-.. kernel-doc:: tools/lib/bpf/libbpf.h
-   :internal:
-
-.. kernel-doc:: tools/lib/bpf/bpf.h
-   :internal:
-
-.. kernel-doc:: tools/lib/bpf/btf.h
-   :internal:
-
-.. kernel-doc:: tools/lib/bpf/xsk.h
-   :internal:
-
-.. kernel-doc:: tools/lib/bpf/bpf_tracing.h
-   :internal:
-
-.. kernel-doc:: tools/lib/bpf/bpf_core_read.h
-   :internal:
-
-.. kernel-doc:: tools/lib/bpf/bpf_endian.h
-   :internal:
\ No newline at end of file