| Message ID | 20210810093145.26153-3-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | dt-bindings: clock: samsung: convert to dtschema | expand |
On Tue, 10 Aug 2021 at 12:32, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Document the bindings for Samsung Exynos external to SoC > (oscclk/XXTI/XusbXTI) clock provided on boards. The bindings are > already implemented in most of the Exynos clock drivers and DTS files. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- Just want to mention that remaining users of such fixed clocks can be converted to regular fixed-rate-clock, and then this binding can be removed along with samsung_clk_of_register_fixed_ext() API? Just a thought. > .../clock/samsung,exynos-ext-clock.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/samsung,exynos-ext-clock.yaml > > diff --git a/Documentation/devicetree/bindings/clock/samsung,exynos-ext-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynos-ext-clock.yaml > new file mode 100644 > index 000000000000..64d027dbe3b2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/samsung,exynos-ext-clock.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/samsung,exynos-ext-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung SoC external/osc/XXTI/XusbXTI clock > + > +maintainers: > + - Chanwoo Choi <cw00.choi@samsung.com> > + - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > + - Sylwester Nawrocki <s.nawrocki@samsung.com> > + - Tomasz Figa <tomasz.figa@gmail.com> > + > +description: | > + Samsung SoCs require an external clock supplied through XXTI or XusbXTI pins. > + > +properties: > + compatible: > + enum: > + - samsung,clock-xxti > + - samsung,clock-xusbxti > + - samsung,exynos5420-oscclk > + > + "#clock-cells": > + const: 0 > + > + clock-frequency: true > + > + clock-output-names: > + maxItems: 1 > + > +required: > + - compatible > + - clock-frequency > + > +additionalProperties: false > + > +examples: > + - | > + fixed-rate-clocks { > + clock { > + compatible = "samsung,clock-xxti"; > + clock-frequency = <24000000>; > + }; > + }; > -- > 2.30.2 >
On 10/08/2021 19:49, Sam Protsenko wrote: > On Tue, 10 Aug 2021 at 12:32, Krzysztof Kozlowski > <krzysztof.kozlowski@canonical.com> wrote: >> >> Document the bindings for Samsung Exynos external to SoC >> (oscclk/XXTI/XusbXTI) clock provided on boards. The bindings are >> already implemented in most of the Exynos clock drivers and DTS files. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> --- > > Just want to mention that remaining users of such fixed clocks can be > converted to regular fixed-rate-clock, and then this binding can be > removed along with samsung_clk_of_register_fixed_ext() API? Just a > thought. Removal of samsung_clk_of_register_fixed_ext() would cause ABI break, probably acceptable for these devices. Yet still, someone would have to do it and test it. Best regards, Krzysztof
On Tue, 10 Aug 2021 11:31:39 +0200, Krzysztof Kozlowski wrote: > Document the bindings for Samsung Exynos external to SoC > (oscclk/XXTI/XusbXTI) clock provided on boards. The bindings are > already implemented in most of the Exynos clock drivers and DTS files. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > .../clock/samsung,exynos-ext-clock.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/samsung,exynos-ext-clock.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/clock/samsung,exynos-ext-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynos-ext-clock.yaml new file mode 100644 index 000000000000..64d027dbe3b2 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/samsung,exynos-ext-clock.yaml @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/samsung,exynos-ext-clock.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SoC external/osc/XXTI/XusbXTI clock + +maintainers: + - Chanwoo Choi <cw00.choi@samsung.com> + - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> + - Sylwester Nawrocki <s.nawrocki@samsung.com> + - Tomasz Figa <tomasz.figa@gmail.com> + +description: | + Samsung SoCs require an external clock supplied through XXTI or XusbXTI pins. + +properties: + compatible: + enum: + - samsung,clock-xxti + - samsung,clock-xusbxti + - samsung,exynos5420-oscclk + + "#clock-cells": + const: 0 + + clock-frequency: true + + clock-output-names: + maxItems: 1 + +required: + - compatible + - clock-frequency + +additionalProperties: false + +examples: + - | + fixed-rate-clocks { + clock { + compatible = "samsung,clock-xxti"; + clock-frequency = <24000000>; + }; + };
Document the bindings for Samsung Exynos external to SoC (oscclk/XXTI/XusbXTI) clock provided on boards. The bindings are already implemented in most of the Exynos clock drivers and DTS files. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- .../clock/samsung,exynos-ext-clock.yaml | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/samsung,exynos-ext-clock.yaml