mbox series

[v2,0/8] ASoC: Intel: boards: use software node API

Message ID 20210812224443.170144-1-pierre-louis.bossart@linux.intel.com (mailing list archive)
Headers show
Series ASoC: Intel: boards: use software node API | expand

Message

Pierre-Louis Bossart Aug. 12, 2021, 10:44 p.m. UTC
This is an update on an earlier contribution from Heikki Krogerus

The function device_add_properties() is going to be removed.
Replacing it with software node API equivalents.

Thanks for Hans de Goede and Andy Shevchenko for their comments,
suggestions and Reviewed-by tags on GitHub. The review thread can be
found at https://github.com/thesofproject/linux/pull/3041)

v2 changes: feedback from Andy and Hans
Better error handling
Codec reference is kept until the .remove callback
Remove bus search to find device

v1 changes from Heikki's patches:
Avoid the use of devm_ routines for Baytrail machine drivers.

Heikki Krogerus (1):
  ASoC: Intel: boards: use software node API in Atom boards

Pierre-Louis Bossart (7):
  ASoC: Intel: boards: harden codec property handling
  ASoC: Intel: boards: handle errors with acpi_dev_get_first_match_dev()
  ASoC: Intel: boards: get codec device with ACPI instead of bus search
  ASoC: Intel: sof_sdw: pass card information to init/exit functions
  ASoC: Intel: sof_sdw_rt711*: keep codec device reference until remove
  ASoC: Intel: use software node API in SoundWire machines
  ASoC: Intel: remove device_properties for Atom boards

 sound/soc/intel/boards/bytcht_es8316.c      | 31 ++++++++--
 sound/soc/intel/boards/bytcr_rt5640.c       | 57 ++++++++++++++-----
 sound/soc/intel/boards/bytcr_rt5651.c       | 63 ++++++++++++++-------
 sound/soc/intel/boards/sof_sdw.c            | 20 ++++---
 sound/soc/intel/boards/sof_sdw_common.h     | 37 +++++++-----
 sound/soc/intel/boards/sof_sdw_max98373.c   |  3 +-
 sound/soc/intel/boards/sof_sdw_rt1308.c     |  3 +-
 sound/soc/intel/boards/sof_sdw_rt1316.c     |  3 +-
 sound/soc/intel/boards/sof_sdw_rt5682.c     |  3 +-
 sound/soc/intel/boards/sof_sdw_rt700.c      |  3 +-
 sound/soc/intel/boards/sof_sdw_rt711.c      | 51 +++++++++--------
 sound/soc/intel/boards/sof_sdw_rt711_sdca.c | 52 +++++++++--------
 sound/soc/intel/boards/sof_sdw_rt715.c      |  3 +-
 sound/soc/intel/boards/sof_sdw_rt715_sdca.c |  3 +-
 14 files changed, 221 insertions(+), 111 deletions(-)

Comments

Andy Shevchenko Aug. 13, 2021, 10:30 a.m. UTC | #1
On Thu, Aug 12, 2021 at 05:44:35PM -0500, Pierre-Louis Bossart wrote:
> This is an update on an earlier contribution from Heikki Krogerus
> 
> The function device_add_properties() is going to be removed.
> Replacing it with software node API equivalents.
> 
> Thanks for Hans de Goede and Andy Shevchenko for their comments,
> suggestions and Reviewed-by tags on GitHub. The review thread can be
> found at https://github.com/thesofproject/linux/pull/3041)

For all non-commented
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> v2 changes: feedback from Andy and Hans
> Better error handling
> Codec reference is kept until the .remove callback
> Remove bus search to find device
> 
> v1 changes from Heikki's patches:
> Avoid the use of devm_ routines for Baytrail machine drivers.
> 
> Heikki Krogerus (1):
>   ASoC: Intel: boards: use software node API in Atom boards
> 
> Pierre-Louis Bossart (7):
>   ASoC: Intel: boards: harden codec property handling
>   ASoC: Intel: boards: handle errors with acpi_dev_get_first_match_dev()
>   ASoC: Intel: boards: get codec device with ACPI instead of bus search
>   ASoC: Intel: sof_sdw: pass card information to init/exit functions
>   ASoC: Intel: sof_sdw_rt711*: keep codec device reference until remove
>   ASoC: Intel: use software node API in SoundWire machines
>   ASoC: Intel: remove device_properties for Atom boards
> 
>  sound/soc/intel/boards/bytcht_es8316.c      | 31 ++++++++--
>  sound/soc/intel/boards/bytcr_rt5640.c       | 57 ++++++++++++++-----
>  sound/soc/intel/boards/bytcr_rt5651.c       | 63 ++++++++++++++-------
>  sound/soc/intel/boards/sof_sdw.c            | 20 ++++---
>  sound/soc/intel/boards/sof_sdw_common.h     | 37 +++++++-----
>  sound/soc/intel/boards/sof_sdw_max98373.c   |  3 +-
>  sound/soc/intel/boards/sof_sdw_rt1308.c     |  3 +-
>  sound/soc/intel/boards/sof_sdw_rt1316.c     |  3 +-
>  sound/soc/intel/boards/sof_sdw_rt5682.c     |  3 +-
>  sound/soc/intel/boards/sof_sdw_rt700.c      |  3 +-
>  sound/soc/intel/boards/sof_sdw_rt711.c      | 51 +++++++++--------
>  sound/soc/intel/boards/sof_sdw_rt711_sdca.c | 52 +++++++++--------
>  sound/soc/intel/boards/sof_sdw_rt715.c      |  3 +-
>  sound/soc/intel/boards/sof_sdw_rt715_sdca.c |  3 +-
>  14 files changed, 221 insertions(+), 111 deletions(-)
> 
> -- 
> 2.25.1
>
Pierre-Louis Bossart Aug. 13, 2021, 1:33 p.m. UTC | #2
On 8/13/21 5:30 AM, Andy Shevchenko wrote:
> On Thu, Aug 12, 2021 at 05:44:35PM -0500, Pierre-Louis Bossart wrote:
>> This is an update on an earlier contribution from Heikki Krogerus
>>
>> The function device_add_properties() is going to be removed.
>> Replacing it with software node API equivalents.
>>
>> Thanks for Hans de Goede and Andy Shevchenko for their comments,
>> suggestions and Reviewed-by tags on GitHub. The review thread can be
>> found at https://github.com/thesofproject/linux/pull/3041)
> 
> For all non-commented
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks Andy for the review, I'll resend a v3 later today with your
suggested changes and your Reviewed-by tag added.
>> v2 changes: feedback from Andy and Hans
>> Better error handling
>> Codec reference is kept until the .remove callback
>> Remove bus search to find device
>>
>> v1 changes from Heikki's patches:
>> Avoid the use of devm_ routines for Baytrail machine drivers.
>>
>> Heikki Krogerus (1):
>>   ASoC: Intel: boards: use software node API in Atom boards
>>
>> Pierre-Louis Bossart (7):
>>   ASoC: Intel: boards: harden codec property handling
>>   ASoC: Intel: boards: handle errors with acpi_dev_get_first_match_dev()
>>   ASoC: Intel: boards: get codec device with ACPI instead of bus search
>>   ASoC: Intel: sof_sdw: pass card information to init/exit functions
>>   ASoC: Intel: sof_sdw_rt711*: keep codec device reference until remove
>>   ASoC: Intel: use software node API in SoundWire machines
>>   ASoC: Intel: remove device_properties for Atom boards
>>
>>  sound/soc/intel/boards/bytcht_es8316.c      | 31 ++++++++--
>>  sound/soc/intel/boards/bytcr_rt5640.c       | 57 ++++++++++++++-----
>>  sound/soc/intel/boards/bytcr_rt5651.c       | 63 ++++++++++++++-------
>>  sound/soc/intel/boards/sof_sdw.c            | 20 ++++---
>>  sound/soc/intel/boards/sof_sdw_common.h     | 37 +++++++-----
>>  sound/soc/intel/boards/sof_sdw_max98373.c   |  3 +-
>>  sound/soc/intel/boards/sof_sdw_rt1308.c     |  3 +-
>>  sound/soc/intel/boards/sof_sdw_rt1316.c     |  3 +-
>>  sound/soc/intel/boards/sof_sdw_rt5682.c     |  3 +-
>>  sound/soc/intel/boards/sof_sdw_rt700.c      |  3 +-
>>  sound/soc/intel/boards/sof_sdw_rt711.c      | 51 +++++++++--------
>>  sound/soc/intel/boards/sof_sdw_rt711_sdca.c | 52 +++++++++--------
>>  sound/soc/intel/boards/sof_sdw_rt715.c      |  3 +-
>>  sound/soc/intel/boards/sof_sdw_rt715_sdca.c |  3 +-
>>  14 files changed, 221 insertions(+), 111 deletions(-)
>>
>> -- 
>> 2.25.1
>>
>